[Cuis-dev] Non-ASCII characters in source code files Was: TrueType font import problems

Juan Vuletich juan at cuis.st
Sun Sep 17 17:17:59 PDT 2023


Hi Bernhard,

On 9/14/2023 5:19 PM, Bernhard Pieber via Cuis-dev wrote:
> Hi Juan,
>
> Thanks for the clarification. I can now understand the changes in String>>#iso8859s15ToRTFEncoding in 0b58898 and in StyleSet>>#createFeaturesParagraphStyleSet and StyleSet>>#createSampleParagraphStyleSet in 57ce260. It is really great how well this works!
>
> The changes in RTFConversionTest>>#textSample6 in c1d67b5 and in StyledTextTest>>#testOldInstanceDeserialization in 57ce260 look dubious to me, though.

I think they are OK. #textSample6 was always that weird. You can replace 
it with more sensible stuff, if you wish. Still, I think it is OK. 
Besides, I see no issue in #testOldInstanceDeserialization.


> I decided to create the PR for StyledTextEditor anyway:
> https://github.com/Cuis-Smalltalk/StyledTextEditor/pull/7
>
> With these changes STE can be loaded again. There are no more test failures and errors than before the font improvement. Feel free to improve my code. ;-)
>
> Cheers,
> Bernhard
>

Nice. Very few tests fail now. Cool!

Thanks,

-- 
Juan Vuletich
cuis.st
github.com/jvuletich
researchgate.net/profile/Juan-Vuletich
independent.academia.edu/JuanVuletich
patents.justia.com/inventor/juan-manuel-vuletich
linkedin.com/in/juan-vuletich-75611b3
twitter.com/JuanVuletich



More information about the Cuis-dev mailing list