<div dir="ltr"><div>Hi Phil,</div><div>Thanks for trying it.</div><div>The most obvious difference I see with what PluggableButtonMorph does is the choice of color for highlighting, but that also depends on the theme. Notice that highlighting and selection are different things, and right now highlighting is not used much except to give user immediate feedback in case the model takes a while to update. In Cuis default theme the highlight color seems inadequate tho, it should be
less salient than the actual selection color, but it looks good in a
dark theme. You're suggesting matching the colors for list item highlighting with button mouseOver highlighting? Perhaps that would make sense even without the changes I made, or perhaps should be made more configurable in the theme, right now the selected row uses 'Theme current listHighlightFocused: owner hasKeyabordFocus' and highlighted row used the same but 'duller', perhaps we should add a 'listSelectionFocused:' differentiate them in the theme.<br></div><div>What I did doesn't seem to interfere with keyboard selection. I see it disappears when using the keyboard, and I see the original keyboard selection behavior, do you see other problems? We seem to lose the immediate feedback on click, tho, because the item is already highlighted when you click, but still the new behavior seems more lively...<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, May 25, 2019 at 2:38 AM Phil B <<a href="mailto:pbpublist@gmail.com">pbpublist@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Luciano,<div><br></div><div>Interesting idea but I'd suggest a different approach. See how PluggableButtonMorph does it via #mouseEnter:, #mouseLeave: and #drawRoundGradientLookOn:. If for whatever reason you don't want to match the style of button mouseover, you probably should use a different visual indicator than what is used currently for keyboard focus / selection so it's clear to the user *what* you're indicating.</div><div><br></div><div>Thanks,</div><div>Phil</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 24, 2019 at 3:24 PM Luciano Notarfrancesco via Cuis-dev <<a href="mailto:cuis-dev@lists.cuis.st" target="_blank">cuis-dev@lists.cuis.st</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Ok, this is more like it, but still not sure if this is the intended use of highlightedRow, let me know.<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 24, 2019 at 7:05 PM Luciano Notarfrancesco <<a href="mailto:luchiano@gmail.com" target="_blank">luchiano@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hm, I just tested it with the default Cuis theme and it is weird because it keeps the item highlighted after the pointer leaves the list, seems confusing... didn't notice it with my theme because I use black background. This needs a little more thought, sorry..<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 24, 2019 at 6:55 PM Luciano Notarfrancesco <<a href="mailto:luchiano@gmail.com" target="_blank">luchiano@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>The other day I looked at Squeak and saw how the PluggableListMorph highlights the item under the mouse pointer. I don't remember paying attention to it before, but it seems pretty common, I'm seeing it now in gmail for example. This changeset adds a line of code to do that, let me know if you like it or if it's annoying.</div><div><br></div></div>
</blockquote></div>
</blockquote></div>
-- <br>
Cuis-dev mailing list<br>
<a href="mailto:Cuis-dev@lists.cuis.st" target="_blank">Cuis-dev@lists.cuis.st</a><br>
<a href="https://lists.cuis.st/mailman/listinfo/cuis-dev" rel="noreferrer" target="_blank">https://lists.cuis.st/mailman/listinfo/cuis-dev</a><br>
</blockquote></div>
</blockquote></div>