<div dir="ltr">Great! Thanks! </div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, May 25, 2019 at 8:31 PM Andres Valloud <<a href="mailto:ten@smallinteger.com">ten@smallinteger.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">How about >20% faster in general? I also fixed up comments that referenced methods and variables that didn't exist, etc. I strongly suspect this iteration can be made to run faster still. On 5/25/19 11:19, Luciano Notarfrancesco via Cuis-dev wrote: > Hi Hernan, > Thanks for integrating! Next time I should provide tests... > Yes, it is expected behavior, it was made like that in order to > enumerate combinations as fast as possible without stressing the GC (I > wonder how much difference does it make nowadays, tho). I thought that > the name 'atATimeDo' was a remainder that the array is being reused in > each iteration, but actually groupsOf:atATimeDo: doesn't reuse the > array, and permutationsDo: reuses the array. IMHO groupsOf:do: and > combinationsOf:do: would be nicer names, but not a big deal. > > > On Sat, May 25, 2019 at 1:06 PM Hernan Wilkinson > <<a href="mailto:hernan.wilkinson@10pines.com" target="_blank">hernan.wilkinson@10pines.com</a> <mailto:<a href="mailto:hernan.wilkinson@10pines.com" target="_blank">hernan.wilkinson@10pines.com</a>>> wrote: > > Hi Luciano, > thank you for the fix. It is integrated now and I added a couple > of tests to SequenceableCollectionTest, one when k is cero and > another for the normal case. > > When I wrote the test for the normal case I notice that the > collection passed as parameter to the block it is always the name > and therefore the following test fails: > testCombinationsAtATimeDoWorksAsExpected > > | combinations | > > combinations := OrderedCollection new. > 'abc' combinations: 2 atATimeDo: [ :combination | combinations add: > combination]. > > self assert: 3 equals: combinations size. > self assert: (combinations includes: #($a $b)). > self assert: (combinations includes: #($a $c)). > self assert: (combinations includes: #($b $c)). > > To make it pass I had to make a copy of combination. > ... > 'abc' combinations: 2 atATimeDo: [ :combination | combinations add: > combination *copy*]. > .... > > Is that the expected behavior? It looks weird to me... I would > expect combination to be different collections on each iteration... > > Cheers! > Hernan. > > On Thu, May 23, 2019 at 1:13 PM Luciano Notarfrancesco via Cuis-dev > <<a href="mailto:cuis-dev@lists.cuis.st" target="_blank">cuis-dev@lists.cuis.st</a> <mailto:<a href="mailto:cuis-dev@lists.cuis.st" target="_blank">cuis-dev@lists.cuis.st</a>>> wrote: > > The method was failing for the corner case of "combinations of 0 > elements". Here's the fix. > -- > Cuis-dev mailing list > <a href="mailto:Cuis-dev@lists.cuis.st" target="_blank">Cuis-dev@lists.cuis.st</a> <mailto:<a href="mailto:Cuis-dev@lists.cuis.st" target="_blank">Cuis-dev@lists.cuis.st</a>> > <a href="https://lists.cuis.st/mailman/listinfo/cuis-dev" rel="noreferrer" target="_blank">https://lists.cuis.st/mailman/listinfo/cuis-dev</a> > > > > -- > *Hernán Wilkinson > Agile Software Development, Teaching & Coaching* > *Phone: +54-011*-4893-2057 > *Twitter: @HernanWilkinson* > *site: <a href="http://www.10Pines.com" rel="noreferrer" target="_blank">http://www.10Pines.com</a> <<a href="http://www.10pines.com/" rel="noreferrer" target="_blank">http://www.10pines.com/</a>>* > Address: Alem 896, Floor 6, Buenos Aires, Argentina > > </blockquote></div>