<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Very nice! This is now at GitHub.<br>
<br>
Apologies for the delay in review.<br>
<pre class="moz-signature" cols="72">--
Juan Vuletich
<a class="moz-txt-link-abbreviated" href="http://www.cuis-smalltalk.org">www.cuis-smalltalk.org</a>
<a class="moz-txt-link-freetext" href="https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev">https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev</a>
<a class="moz-txt-link-freetext" href="https://github.com/jvuletich">https://github.com/jvuletich</a>
<a class="moz-txt-link-freetext" href="https://www.linkedin.com/in/juan-vuletich-75611b3">https://www.linkedin.com/in/juan-vuletich-75611b3</a>
@JuanVuletich</pre>
<br>
On 5/26/2019 4:48 AM, Luciano Notarfrancesco via Cuis-dev wrote:
<blockquote
cite="mid:CAL5GDyo2Qa_kXpx6-AwjrRLn6mdqNwDGds9QQByt-bvWJCGEVQ@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>Thanks! Here's an attempt to make it more consistent across
light and dark themes using alpha instead of duller. Also, it
should be more subtle and more clearly distinct from an actual
selection as per Phil's suggestions (tried to follow the way
it seems to be done in Windows 8.1 for example).</div>
<div>The changeset also adds exactly the same behavior to
hierarchical lists, so now the file list window is consistent
too.<br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Sat, May 25, 2019 at 8:00
PM Juan Vuletich <<a moz-do-not-send="true"
href="mailto:juan@jvuletich.org">juan@jvuletich.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
<div bgcolor="#ffffff"> On 5/24/2019 4:27 PM, Luciano
Notarfrancesco via Cuis-dev wrote:
<blockquote type="cite">
<div dir="ltr">Ok, this is more like it, but still not
sure if this is the intended use of highlightedRow, let
me know.<br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Fri, May 24, 2019
at 7:05 PM Luciano Notarfrancesco <<a
moz-do-not-send="true"
href="mailto:luchiano@gmail.com" target="_blank">luchiano@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin: 0px 0px
0px 0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
<div dir="ltr">Hm, I just tested it with the default
Cuis theme and it is weird because it keeps the item
highlighted after the pointer leaves the list,
seems confusing... didn't notice it with my theme
because I use black background. This needs a little
more thought, sorry..<br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Fri, May 24,
2019 at 6:55 PM Luciano Notarfrancesco <<a
moz-do-not-send="true"
href="mailto:luchiano@gmail.com" target="_blank">luchiano@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin: 0px
0px 0px 0.8ex; border-left: 1px solid rgb(204,
204, 204); padding-left: 1ex;">
<div dir="ltr">
<div>The other day I looked at Squeak and saw
how the PluggableListMorph highlights the item
under the mouse pointer. I don't remember
paying attention to it before, but it seems
pretty common, I'm seeing it now in gmail for
example. This changeset adds a line of code to
do that, let me know if you like it or if it's
annoying.</div>
<div><br>
</div>
</div>
</blockquote>
</div>
</blockquote>
</div>
</blockquote>
<br>
Thanks Luciano! Now at GitHub. I added a follow up, to avoid
highlight when mouse pointer is over the scrollbar.<br>
<br>
Cheers,<br>
<pre class="gmail-m_196843016663328131moz-signature" cols="72">--
Juan Vuletich
<a moz-do-not-send="true" class="gmail-m_196843016663328131moz-txt-link-abbreviated" href="http://www.cuis-smalltalk.org" target="_blank">www.cuis-smalltalk.org</a>
<a moz-do-not-send="true" class="gmail-m_196843016663328131moz-txt-link-freetext" href="https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev" target="_blank">https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev</a>
<a moz-do-not-send="true" class="gmail-m_196843016663328131moz-txt-link-freetext" href="https://github.com/jvuletich" target="_blank">https://github.com/jvuletich</a>
<a moz-do-not-send="true" class="gmail-m_196843016663328131moz-txt-link-freetext" href="https://www.linkedin.com/in/juan-vuletich-75611b3" target="_blank">https://www.linkedin.com/in/juan-vuletich-75611b3</a>
@JuanVuletich</pre>
</div>
</blockquote>
</div>
</blockquote>
<br>
<br>
</body>
</html>