<div><div dir="auto">Yes, it was indeed :-)</div></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 21 Aug 2019 at 09:44 Juan Vuletich <<a href="mailto:juan@jvuletich.org">juan@jvuletich.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><u></u>
<div bgcolor="#ffffff" text="#000000">
Wow, thanks. The old code was slow and ugly!<br>
<br>
Integrating it.<br>
<br>
Cheers,<br>
<pre class="m_6471499305348504281moz-signature" cols="72">--
Juan Vuletich
<a class="m_6471499305348504281moz-txt-link-abbreviated" href="http://www.cuis-smalltalk.org" target="_blank">www.cuis-smalltalk.org</a>
<a class="m_6471499305348504281moz-txt-link-freetext" href="https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev" target="_blank">https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev</a>
<a class="m_6471499305348504281moz-txt-link-freetext" href="https://github.com/jvuletich" target="_blank">https://github.com/jvuletich</a>
<a class="m_6471499305348504281moz-txt-link-freetext" href="https://www.linkedin.com/in/juan-vuletich-75611b3" target="_blank">https://www.linkedin.com/in/juan-vuletich-75611b3</a>
@JuanVuletich</pre></div><div bgcolor="#ffffff" text="#000000">
<br>
On 8/21/2019 9:26 AM, Hernan Wilkinson via Cuis-dev wrote:
<blockquote type="cite">
<div dir="ltr">Hi,
<div> attached is a cs that changes the implementation of
#allSubclasses and #withAllSubclasses and generates
performance improvement drastically.</div>
<div> </div>
<div> Just as a quick example, with the current implementation:</div>
<div> Time millisecondsToRun: [ 100 timesRepeat: [Behavior
withAllSubclasses ]] 1140 .</div>
<div> </div>
<div> With the proposed change:<br>
Time millisecondsToRun: [ 100 timesRepeat: [Behavior
withAllSubclasses2 ]] . 73 <br clear="all">
<div><br>
</div>
<div> In the type checker of LiveTyping, checking Behavior
goes from 9.5 seconds to 5 seconds only with that change.</div>
<div> </div>
<div> One difference between the current and proposed version,
is that the current returns a Set while the proposed version
returns an OrderedCollection. </div>
<div> I looked carefully if that could break something and it
does not. I've been using the image with this new
implementation and everything works fine.</div>
<div><br>
</div>
<div> Juan, please take a look at it and integrate it if you
think it is useful.</div>
<div> Hernan.</div>
<div><br>
</div>
-- <br>
<div dir="ltr" class="m_6471499305348504281gmail_signature" data-smartmail="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div><span style="font-family:tahoma,sans-serif;font-size:xx-small;border-collapse:collapse"><strong><span style="font-size:8pt"><span><span style="font-size:small"><font size="2"><span style="font-weight:normal"><span style="font-weight:bold">Hernán
Wilkinson</span><br>
Agile Software
Development, Teaching
& Coaching</span></font></span></span></span></strong></span></div>
<div><span style="font-family:tahoma,sans-serif;font-size:xx-small;border-collapse:collapse"><strong><span style="font-size:8pt"><span><span style="font-size:small"><font size="2"><span style="font-weight:normal">Phone: +54-011</span></font></span></span></span></strong></span><font size="2" face="tahoma, sans-serif">-4893-2057</font></div>
<div><strong style="font-family:tahoma,sans-serif;font-size:xx-small"><span style="font-size:8pt"><span style="font-size:small"><font size="2"><span style="font-weight:normal">Twitter:
@HernanWilkinson</span></font></span></span></strong></div>
<div><span style="font-family:tahoma,sans-serif;font-size:xx-small;border-collapse:collapse"><strong><span style="font-size:8pt"><span><span style="font-size:small"><font size="2"><span style="font-weight:normal">site: <a href="http://www.10pines.com/" style="color:rgb(17,65,112)" target="_blank">http://www.10Pines.com</a></span></font></span></span></span></strong></span></div>
<div><font face="tahoma, sans-serif"><span style="border-collapse:collapse">Address:
Alem 896</span></font>, Floor 6,
Buenos Aires, Argentina</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</blockquote></div></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature">Sent from a fat finger unaware device</div>