<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Wow, thanks. The old code was slow and ugly!<br>
<br>
Integrating it.<br>
<br>
Cheers,<br>
<pre class="moz-signature" cols="72">--
Juan Vuletich
<a class="moz-txt-link-abbreviated" href="http://www.cuis-smalltalk.org">www.cuis-smalltalk.org</a>
<a class="moz-txt-link-freetext" href="https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev">https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev</a>
<a class="moz-txt-link-freetext" href="https://github.com/jvuletich">https://github.com/jvuletich</a>
<a class="moz-txt-link-freetext" href="https://www.linkedin.com/in/juan-vuletich-75611b3">https://www.linkedin.com/in/juan-vuletich-75611b3</a>
@JuanVuletich</pre>
<br>
On 8/21/2019 9:26 AM, Hernan Wilkinson via Cuis-dev wrote:
<blockquote
cite="mid:CAJAbP8jWomriQK24MR-6-9M8GjUBPb-Ni_hsmUxqfnO46HZC9w@mail.gmail.com"
type="cite">
<div dir="ltr">Hi,
<div> attached is a cs that changes the implementation of
#allSubclasses and #withAllSubclasses and generates
performance improvement drastically.</div>
<div> </div>
<div> Just as a quick example, with the current implementation:</div>
<div> Time millisecondsToRun: [ 100 timesRepeat: [Behavior
withAllSubclasses ]] 1140 .</div>
<div> </div>
<div> With the proposed change:<br>
Time millisecondsToRun: [ 100 timesRepeat: [Behavior
withAllSubclasses2 ]] . 73 <br clear="all">
<div><br>
</div>
<div> In the type checker of LiveTyping, checking Behavior
goes from 9.5 seconds to 5 seconds only with that change.</div>
<div> </div>
<div> One difference between the current and proposed version,
is that the current returns a Set while the proposed version
returns an OrderedCollection. </div>
<div> I looked carefully if that could break something and it
does not. I've been using the image with this new
implementation and everything works fine.</div>
<div><br>
</div>
<div> Juan, please take a look at it and integrate it if you
think it is useful.</div>
<div> Hernan.</div>
<div><br>
</div>
-- <br>
<div dir="ltr" class="gmail_signature"
data-smartmail="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div><span style="font-family:
tahoma,sans-serif; font-size:
xx-small; border-collapse:
collapse;"><strong><span
style="font-size: 8pt;"><span><span
style="font-size: small;"><font
size="2"><span
style="font-weight:
normal;"><span
style="font-weight:
bold;">Hernán
Wilkinson</span><br>
Agile Software
Development, Teaching
& Coaching</span></font></span></span></span></strong></span></div>
<div><span style="font-family:
tahoma,sans-serif; font-size:
xx-small; border-collapse:
collapse;"><strong><span
style="font-size: 8pt;"><span><span
style="font-size: small;"><font
size="2"><span
style="font-weight:
normal;">Phone: +54-011</span></font></span></span></span></strong></span><font
size="2" face="tahoma, sans-serif">-4893-2057</font></div>
<div><strong style="font-family:
tahoma,sans-serif; font-size:
xx-small;"><span style="font-size:
8pt;"><span style="font-size:
small;"><font size="2"><span
style="font-weight: normal;">Twitter:
@HernanWilkinson</span></font></span></span></strong></div>
<div><span style="font-family:
tahoma,sans-serif; font-size:
xx-small; border-collapse:
collapse;"><strong><span
style="font-size: 8pt;"><span><span
style="font-size: small;"><font
size="2"><span
style="font-weight:
normal;">site: <a
moz-do-not-send="true"
href="http://www.10pines.com/" style="color: rgb(17, 65, 112);"
target="_blank">http://www.10Pines.com</a></span></font></span></span></span></strong></span></div>
<div><font face="tahoma, sans-serif"><span
style="border-collapse: collapse;">Address:
Alem 896</span></font>, Floor 6,
Buenos Aires, Argentina</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</body>
</html>