<div dir="ltr">Yep there's some weird stuff out there. I don't think that should discourage the change as I agree with the logic of your objection. I just suspect there's more to be done in preparation for the change before actually making it. (i.e. in addition to the core image, shouldn't all the packages in the Cuis repo also be fixed before flipping the switch?)<div> </div><div>I'm raising the flag because 'save as' was literally the first thing I tried after applying updates. My cursory glance tells me this is going to be painful before my own code is even involved...</div></div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Oct 13, 2019 at 8:27 PM Andres Valloud via Cuis-dev <<a href="mailto:cuis-dev@lists.cuis.st">cuis-dev@lists.cuis.st</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Yeah, I was just looking at that, pondering this bit: | wasCog isCog | isCog _ Smalltalk isRunningCog. [ wasCog _ self imageFormatVersionFromFile allMask: 1 ] on: Error do: [ :ignore | "probably save-as to non-existing file" ^ true ]. Obviously, everybody knows that's what the error was, probably :P. Andres. On 10/13/19 17:25, Phil B wrote: > Just did a quick look at senders of #on:do: and found these: > > AndreasSystemProfiler>canWork > Browser>contents:notifying: > FeatureRequirement>require > FeatureRequirement>satisfyRequirementsAndInstall > MethodNode>generatePreSpur:using: > MethodNode>generateSpur:using: > RefactoringApplier>createAndValueHandlingExceptions: > SmalltalkEditor>renameTemporary: > SmalltalkEditor>withClassDefinitionNodeAndClassDo:ifErrorsParsing: > SmalltalkEditor>withMethodNodeAndClassDo:ifErrorsParsing: > SystemDictionary>okayToSave > > That's ~15% of #on:do: senders in the base image *directly* returning > within the block. (i.e. I didn't check any of the blocks passed as > parameters which might also do so or any of the other ways this might > occur) I don't think this change is fully baked... > > > On Sun, Oct 13, 2019 at 8:00 PM Phil B <<a href="mailto:pbpublist@gmail.com" target="_blank">pbpublist@gmail.com</a> > <mailto:<a href="mailto:pbpublist@gmail.com" target="_blank">pbpublist@gmail.com</a>>> wrote: > > It looks like we have at least some changes in the core image to > resolve. World menu->Save as... now fails. Has a scan of the image > been done to identify where these cases might be buried? > > On Sun, Oct 13, 2019 at 9:48 AM Juan Vuletich via Cuis-dev > <<a href="mailto:cuis-dev@lists.cuis.st" target="_blank">cuis-dev@lists.cuis.st</a> <mailto:<a href="mailto:cuis-dev@lists.cuis.st" target="_blank">cuis-dev@lists.cuis.st</a>>> wrote: > > Hi Folks, > > Some time ago, Andrés (with just a tad of help from me) fixed a > problem > in Exception handling. If exception handler blocks do non-local > return > (^stuff), they will skip execution of part of the Exception > handling > system code, breaking exception return values and possibly other > 'bad > things'. > > I just pushed to GitHub a few updates with this work. Now, if an > exception handler does a non-local return, an Error will be > raised. We > also fixed a couple of places in the image where this was being > done. > BaseImageTests pass. > > This updates have some risk of breaking your code. If you you > get this > error: 'Exception handler blocks must not do non local returns', > then > you need to adjust your code. See updates #3917 to #3922 for the > changes > done to the base image. > > Thanks, > > -- > Juan Vuletich > <a href="http://www.cuis-smalltalk.org" rel="noreferrer" target="_blank">www.cuis-smalltalk.org</a> <<a href="http://www.cuis-smalltalk.org" rel="noreferrer" target="_blank">http://www.cuis-smalltalk.org</a>> > <a href="https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev" rel="noreferrer" target="_blank">https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev</a> > <a href="https://github.com/jvuletich" rel="noreferrer" target="_blank">https://github.com/jvuletich</a> > <a href="https://www.linkedin.com/in/juan-vuletich-75611b3" rel="noreferrer" target="_blank">https://www.linkedin.com/in/juan-vuletich-75611b3</a> > @JuanVuletich > > -- > Cuis-dev mailing list > <a href="mailto:Cuis-dev@lists.cuis.st" target="_blank">Cuis-dev@lists.cuis.st</a> <mailto:<a href="mailto:Cuis-dev@lists.cuis.st" target="_blank">Cuis-dev@lists.cuis.st</a>> > <a href="https://lists.cuis.st/mailman/listinfo/cuis-dev" rel="noreferrer" target="_blank">https://lists.cuis.st/mailman/listinfo/cuis-dev</a> > -- Cuis-dev mailing list <a href="mailto:Cuis-dev@lists.cuis.st" target="_blank">Cuis-dev@lists.cuis.st</a> <a href="https://lists.cuis.st/mailman/listinfo/cuis-dev" rel="noreferrer" target="_blank">https://lists.cuis.st/mailman/listinfo/cuis-dev</a> </blockquote></div>