<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
On 10/27/2019 12:05 AM, Hernan Wilkinson via Cuis-dev wrote:
<blockquote
cite="mid:CAJAbP8hk1ZzCq7PbVDAxqZG36mTJSqYUvgcrr8HrY-+xQ++k1Q@mail.gmail.com"
type="cite">
<div dir="ltr">Hi,
<div> attached are two more refactorings of the changes model</div>
<div><br>
</div>
<div>Cheers!</div>
<div>Hernan.<br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr" class="gmail_signature"
data-smartmail="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div><span style="font-family:
tahoma,sans-serif; font-size:
xx-small; border-collapse:
collapse;"><strong><span
style="font-size: 8pt;"><span><span
style="font-size: small;"><font
size="2"><span
style="font-weight:
normal;"><span
style="font-weight:
bold;">Hernán
Wilkinson</span><br>
Agile Software
Development, Teaching
& Coaching</span></font></span></span></span></strong></span></div>
<div><span style="font-family:
tahoma,sans-serif; font-size:
xx-small; border-collapse:
collapse;"><strong><span
style="font-size: 8pt;"><span><span
style="font-size: small;"><font
size="2"><span
style="font-weight:
normal;">Phone: +54-011</span></font></span></span></span></strong></span><font
size="2" face="tahoma, sans-serif">-4893-2057</font></div>
<div><strong style="font-family:
tahoma,sans-serif; font-size:
xx-small;"><span style="font-size:
8pt;"><span style="font-size:
small;"><font size="2"><span
style="font-weight: normal;">Twitter:
@HernanWilkinson</span></font></span></span></strong></div>
<div><span style="font-family:
tahoma,sans-serif; font-size:
xx-small; border-collapse:
collapse;"><strong><span
style="font-size: 8pt;"><span><span
style="font-size: small;"><font
size="2"><span
style="font-weight:
normal;">site: <a
moz-do-not-send="true"
href="http://www.10pines.com/" style="color: rgb(17, 65, 112);"
target="_blank">http://www.10Pines.com</a></span></font></span></span></span></strong></span></div>
<div><font face="tahoma, sans-serif"><span
style="border-collapse: collapse;">Address:
Alem 896</span></font>, Floor 6,
Buenos Aires, Argentina</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<br>
Hi Hernán,<br>
<br>
I just reviewed the changes. These are very good additions, and
complete quite a bit our changes model.<br>
<br>
Still I have a couple of comments / questions:<br>
<br>
1) In #classDefinitionRecordFrom: the category is retrieved from
'tokens last' even if the call to #stampFrom: means that the method
should handle a possible stamp. I guess a method #categoryFrom: ,
similar to #stampFrom: is in order, right?<br>
<br>
2) In #stampFrom: I suggest making the last line read "^ stamp
ifNil: [ '' ]", so we can review changes like your #3930 (already
loaded) without a walkback.<br>
<br>
3) After loading this changes, an evaluation of "ClassOrganizer
allInstancesDo: [:co | co removeEmptyCategories]." is in order.<br>
<br>
4) Maybe not related to all these, but
#test03SuiteForNoTestCaseClassAndNoTestClassLooksForReferencesInTests
fails because Object testCaseClass = ObjectTest (even if unrelated I
believe you wrote both the failing test and ObjectTest class).<br>
<br>
Cheers,<br>
<pre class="moz-signature" cols="72">--
Juan Vuletich
<a class="moz-txt-link-abbreviated" href="http://www.cuis-smalltalk.org">www.cuis-smalltalk.org</a>
<a class="moz-txt-link-freetext" href="https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev">https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev</a>
<a class="moz-txt-link-freetext" href="https://github.com/jvuletich">https://github.com/jvuletich</a>
<a class="moz-txt-link-freetext" href="https://www.linkedin.com/in/juan-vuletich-75611b3">https://www.linkedin.com/in/juan-vuletich-75611b3</a>
@JuanVuletich</pre>
</body>
</html>