<div dir="ltr">Hi Juan,<div> attached is a .cs with the changes you suggested, good point!</div><div> Also the changes for the test that was failing :-)</div><div><br></div><div>Cheers!</div><div>Hernan.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Oct 28, 2019 at 4:57 PM Juan Vuletich via Cuis-dev <<a href="mailto:cuis-dev@lists.cuis.st">cuis-dev@lists.cuis.st</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><u></u> <div bgcolor="#ffffff"> <br> Integrated.<br> <br> BTW (inline),<br> <br> On 10/28/2019 10:57 AM, Juan Vuletich via Cuis-dev wrote: <blockquote type="cite"> On 10/27/2019 12:05 AM, Hernan Wilkinson via Cuis-dev wrote: <blockquote type="cite"> <div dir="ltr">Hi, <div> attached are two more refactorings of the changes model</div> <div><br> </div> <div>Cheers!</div> <div>Hernan.<br clear="all"> <div><br> </div> -- <br> <div dir="ltr"> <div dir="ltr"> <div> <div dir="ltr"> <div dir="ltr"> <div dir="ltr"> <div dir="ltr"> <div dir="ltr"> <div dir="ltr"> <div dir="ltr"> <div dir="ltr"> <div><span style="font-family:tahoma,sans-serif;font-size:xx-small;border-collapse:collapse"><strong><span style="font-size:8pt"><span><span style="font-size:small"><font size="2"><span style="font-weight:normal"><span style="font-weight:bold">Hernán Wilkinson</span><br> Agile Software Development, Teaching & Coaching</span></font></span></span></span></strong></span></div> <div><span style="font-family:tahoma,sans-serif;font-size:xx-small;border-collapse:collapse"><strong><span style="font-size:8pt"><span><span style="font-size:small"><font size="2"><span style="font-weight:normal">Phone: +54-011</span></font></span></span></span></strong></span><font size="2" face="tahoma, sans-serif">-4893-2057</font></div> <div><strong style="font-family:tahoma,sans-serif;font-size:xx-small"><span style="font-size:8pt"><span style="font-size:small"><font size="2"><span style="font-weight:normal">Twitter: @HernanWilkinson</span></font></span></span></strong></div> <div><span style="font-family:tahoma,sans-serif;font-size:xx-small;border-collapse:collapse"><strong><span style="font-size:8pt"><span><span style="font-size:small"><font size="2"><span style="font-weight:normal">site: <a href="http://www.10pines.com/" style="color:rgb(17,65,112)" target="_blank">http://www.10Pines.com</a></span></font></span></span></span></strong></span></div> <div><font face="tahoma, sans-serif"><span style="border-collapse:collapse">Address: Alem 896</span></font>, Floor 6, Buenos Aires, Argentina</div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </blockquote> <br> Hi Hernán,<br> <br> I just reviewed the changes. These are very good additions, and complete quite a bit our changes model.<br> <br> Still I have a couple of comments / questions:<br> <br> 1) In #classDefinitionRecordFrom: the category is retrieved from 'tokens last' even if the call to #stampFrom: means that the method should handle a possible stamp. I guess a method #categoryFrom: , similar to #stampFrom: is in order, right?<br> <br> 2) In #stampFrom: I suggest making the last line read "^ stamp ifNil: [ '' ]", so we can review changes like your #3930 (already loaded) without a walkback.<br> <br> 3) After loading this changes, an evaluation of "ClassOrganizer allInstancesDo: [:co | co removeEmptyCategories]." is in order.<br> </blockquote> <br> Done as part of #3941.<br> <br> <blockquote type="cite"> <br> 4) Maybe not related to all these, but #test03SuiteForNoTestCaseClassAndNoTestClassLooksForReferencesInTests fails because Object testCaseClass = ObjectTest (even if unrelated I believe you wrote both the failing test and ObjectTest class).<br> <br> Cheers,<br> <pre cols="72">-- Juan Vuletich <a href="http://www.cuis-smalltalk.org" target="_blank">www.cuis-smalltalk.org</a> <a href="https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev" target="_blank">https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev</a> <a href="https://github.com/jvuletich" target="_blank">https://github.com/jvuletich</a> <a href="https://www.linkedin.com/in/juan-vuletich-75611b3" target="_blank">https://www.linkedin.com/in/juan-vuletich-75611b3</a> @JuanVuletich</pre> </blockquote> <br> Cheers,<br> <pre cols="72">-- Juan Vuletich <a href="http://www.cuis-smalltalk.org" target="_blank">www.cuis-smalltalk.org</a> <a href="https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev" target="_blank">https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev</a> <a href="https://github.com/jvuletich" target="_blank">https://github.com/jvuletich</a> <a href="https://www.linkedin.com/in/juan-vuletich-75611b3" target="_blank">https://www.linkedin.com/in/juan-vuletich-75611b3</a> @JuanVuletich</pre> </div> -- <br> Cuis-dev mailing list<br> <a href="mailto:Cuis-dev@lists.cuis.st" target="_blank">Cuis-dev@lists.cuis.st</a><br> <a href="https://lists.cuis.st/mailman/listinfo/cuis-dev" rel="noreferrer" target="_blank">https://lists.cuis.st/mailman/listinfo/cuis-dev</a><br> </blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div><span style="font-family:tahoma,sans-serif;font-size:xx-small;border-collapse:collapse"><strong><span style="font-size:8pt"><span><span style="font-size:small"><font size="2"><span style="font-weight:normal"><span style="font-weight:bold">Hernán Wilkinson</span><br>Agile Software Development, Teaching & Coaching</span></font></span></span></span></strong></span></div><div><span style="font-family:tahoma,sans-serif;font-size:xx-small;border-collapse:collapse"><strong><span style="font-size:8pt"><span><span style="font-size:small"><font size="2"><span style="font-weight:normal">Phone: +54-011</span></font></span></span></span></strong></span><font face="tahoma, sans-serif" size="2">-4893-2057</font></div><div><strong style="font-family:tahoma,sans-serif;font-size:xx-small"><span style="font-size:8pt"><span style="font-size:small"><font size="2"><span style="font-weight:normal">Twitter: @HernanWilkinson</span></font></span></span></strong></div><div><span style="font-family:tahoma,sans-serif;font-size:xx-small;border-collapse:collapse"><strong><span style="font-size:8pt"><span><span style="font-size:small"><font size="2"><span style="font-weight:normal">site: <a href="http://www.10pines.com/" style="color:rgb(17,65,112)" target="_blank">http://www.10Pines.com</a></span></font></span></span></span></strong></span></div><div><font face="tahoma, sans-serif"><span style="border-collapse:collapse">Address: Alem 896</span></font>, Floor 6, Buenos Aires, Argentina</div></div></div></div></div></div></div></div></div></div></div></div>