<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Hi Phil,<br>
<br>
Great stuff! (inline)<br>
<br>
On 1/10/2020 2:23 AM, Phil B wrote:
<blockquote
cite="mid:CAMJMOeh8L17xs0v-Dhf-=2QcPdtG7T_fYwskGw9t5TgG9uAPKQ@mail.gmail.com"
type="cite">
<div dir="ltr">OK, scratch the previous color idea: how about
green (add), blue (change) and red (delete)? See attached for a
first cut of the proposed color scheme. The implementation is
ugly and hacky but it works (sort of)... still thinking about
the best approach.</div>
</blockquote>
<br>
Too late for having doubts! I already pushed it to GitHub. There
were a few bugs, especially with class methods (made evident by
browsing this very change set). I included #4016 with the fixes.
Anyway, if you come up with another approach that you prefer, just
post again.<br>
<br>
While doing this, I found some ugly code (not part of what you did,
but somewhat related), and removed it in #4015. You (all) might want
to take a look at the kind of code that makes my eyes hurt.<br>
<br>
<blockquote
cite="mid:CAMJMOeh8L17xs0v-Dhf-=2QcPdtG7T_fYwskGw9t5TgG9uAPKQ@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>One additional thing I was thinking about was extending the
list coloring to categories so I did that for deleted methods
since it was easy. Not sure if I'm going to have time right
now to go that far as it has more issues to deal with, but I
wanted to play around with the concept.<br>
</div>
</div>
</blockquote>
<br>
Good.<br>
<br>
<blockquote
cite="mid:CAMJMOeh8L17xs0v-Dhf-=2QcPdtG7T_fYwskGw9t5TgG9uAPKQ@mail.gmail.com"
type="cite">
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Thu, Jan 9, 2020 at 10:04
PM Phil B <<a moz-do-not-send="true"
href="mailto:pbpublist@gmail.com">pbpublist@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
<div dir="ltr">If it looks good, I'd say go ahead and
integrate it. I saw your color changes so I've been playing
around with it and my current thinking is that this is going
to require some invasive changes in other areas so probably
better to do the list stuff as a separate changeset.</div>
</blockquote>
</div>
</blockquote>
<br>
:)<br>
<br>
<blockquote
cite="mid:CAMJMOeh8L17xs0v-Dhf-=2QcPdtG7T_fYwskGw9t5TgG9uAPKQ@mail.gmail.com"
type="cite">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin: 0px 0px 0px
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
<div dir="ltr">
<div>Also, since we're fixing things: are you OK if I change
the diff coloring from reds for adds and blue for deletes
to blue for adds and red for deletes? This has been
bugging me forever: in every diff tool I've ever used red
means deleted!</div>
</div>
<br>
</blockquote>
</div>
</blockquote>
<br>
Of course!<br>
<br>
Thanks,<br>
<pre class="moz-signature" cols="72">--
Juan Vuletich
<a class="moz-txt-link-abbreviated" href="http://www.cuis-smalltalk.org">www.cuis-smalltalk.org</a>
<a class="moz-txt-link-freetext" href="https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev">https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev</a>
<a class="moz-txt-link-freetext" href="https://github.com/jvuletich">https://github.com/jvuletich</a>
<a class="moz-txt-link-freetext" href="https://www.linkedin.com/in/juan-vuletich-75611b3">https://www.linkedin.com/in/juan-vuletich-75611b3</a>
@JuanVuletich</pre>
</body>
</html>