<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Hi Nahuel,<br>
<br>
Thanks. This is great!<br>
<br>
Still, there's something I don't really like in the changes, and it
is adding domain specific knowledge to general, basic classes.<br>
<br>
Something I've been doing over the years in Cuis, that improves
consistency and understandability, is to clean up base classes.
Number should only consist of stuff related to Numbers. Same for
String, Collections, etc. If you compare Object, the Collection
hierarchy, the Number hierarchy, etc, in Cuis against Squeak, you'll
see a lot of that cleanup that has been done. Please help us keep
improving Cuis in this way too.<br>
<br>
You added three methods to Interval that are specific to parsing
source code. I think a much better place for them is as class
methods in Refactoring, perhaps in a 'services' category. They would
be available for other Refactorings to use, but they wouldn't
scatter behavior that is specific to Refactorings to the rest of the
system. May I ask you to do this change?<br>
<br>
Additionally, I'd like to ask you (and everyone!) to pick a
meaningful filenames for ChangeSets. Especially for the bigger ones.<br>
<br>
Thanks,<br>
<pre class="moz-signature" cols="72">--
Juan Vuletich
<a class="moz-txt-link-abbreviated" href="http://www.cuis-smalltalk.org">www.cuis-smalltalk.org</a>
<a class="moz-txt-link-freetext" href="https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev">https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev</a>
<a class="moz-txt-link-freetext" href="https://github.com/jvuletich">https://github.com/jvuletich</a>
<a class="moz-txt-link-freetext" href="https://www.linkedin.com/in/juan-vuletich-75611b3">https://www.linkedin.com/in/juan-vuletich-75611b3</a>
@JuanVuletich</pre>
<br>
On 4/17/2020 11:11 PM, Hernan Wilkinson via Cuis-dev wrote:
<blockquote
cite="mid:CAJAbP8ivgWCqZRrYtLSW-TZVHoDpbSdxg4Sfqz6_CbdxZ6cGjQ@mail.gmail.com"
type="cite">
<div dir="ltr">Great! so cool to have this refactoring in Cuis!
Congratulation Nahuel! and thank you :-)<br>
<div><br>
</div>
<div>It is integrated and on github.</div>
<div>BTW, I moved Preferences class>>withTemporaryValue:
temporaryValue of: aPreferenceName do: aBlock to the tests
package as an extension because it is used only by the tests</div>
<div><br>
</div>
<div>Thanks again!</div>
<div>Hernan</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Mon, Apr 13, 2020 at 2:28
PM Nahuel Garbezza via Cuis-dev <<a moz-do-not-send="true"
href="mailto:cuis-dev@lists.cuis.st">cuis-dev@lists.cuis.st</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
<div dir="ltr">Forwarding because I've included a gif and it
exceeded the allowed mail size :)<br>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">---------- Forwarded
message ---------<br>
De: <strong class="gmail_sendername" dir="auto">Nahuel
Garbezza</strong> <span dir="auto"><<a
moz-do-not-send="true"
href="mailto:n.garbezza@gmail.com" target="_blank">n.garbezza@gmail.com</a>></span><br>
Date: lun., 13 de abr. de 2020 a la(s) 00:21<br>
Subject: [ChangeSet] Extract Temporary - alpha version!<br>
To: Cuis Smalltalk <<a moz-do-not-send="true"
href="mailto:cuis-dev@lists.cuis.st" target="_blank">cuis-dev@lists.cuis.st</a>><br>
</div>
<br>
<br>
<div dir="ltr">Hi!<br>
<div><br>
</div>
<div>I'm excited to share this refactoring I've been
implementing in the last month: the "extract
temporary" refactoring.</div>
<div><br>
</div>
<div>The most basic functionality is included, and there
are some edge cases I'll be addressing in the next
weeks. It has basic error handling so if you try to
extract an invalid text you should see a message
explaining the problem. It has a menu entry for it and
it has the (J) shortcut (that is close to the (K)
shortcut for the extract method).</div>
<div><br>
</div>
<div>The goal is to collect feedback about it, so let me
know if you have any issues with it, or things to
improve in general.</div>
<div><br>
</div>
<div>I'm also attaching a changeset for the tests, and
some refactorings on the extract method refactoring as
well.</div>
<div><br>
</div>
<div>Here's a quick demo of it: <a
moz-do-not-send="true"
href="https://gfycat.com/gaseousobedienthornet"
target="_blank">https://gfycat.com/gaseousobedienthornet</a></div>
<div><br>
</div>
<div>Thanks!</div>
<div>Nahuel.</div>
</div>
</div>
</div>
-- <br>
Cuis-dev mailing list<br>
<a moz-do-not-send="true" href="mailto:Cuis-dev@lists.cuis.st"
target="_blank">Cuis-dev@lists.cuis.st</a><br>
<a moz-do-not-send="true"
href="https://lists.cuis.st/mailman/listinfo/cuis-dev"
rel="noreferrer" target="_blank">https://lists.cuis.st/mailman/listinfo/cuis-dev</a><br>
</blockquote>
</div>
<br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr" class="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div><span style="font-family:
tahoma,sans-serif; font-size: xx-small;
border-collapse: collapse;"><strong><span
style="font-size: 8pt;"><span><span
style="font-size: small;"><font
size="2"><span
style="font-weight: normal;"><span
style="font-weight: bold;">Hernán
Wilkinson</span><br>
Agile Software Development,
Teaching & Coaching</span></font></span></span></span></strong></span></div>
<div><span style="font-family:
tahoma,sans-serif; font-size: xx-small;
border-collapse: collapse;"><strong><span
style="font-size: 8pt;"><span><span
style="font-size: small;"><font
size="2"><span
style="font-weight: normal;">Phone:
+54-011</span></font></span></span></span></strong></span><font
size="2" face="tahoma, sans-serif">-4893-2057</font></div>
<div><strong style="font-family:
tahoma,sans-serif; font-size: xx-small;"><span
style="font-size: 8pt;"><span
style="font-size: small;"><font
size="2"><span style="font-weight:
normal;">Twitter:
@HernanWilkinson</span></font></span></span></strong></div>
<div><span style="font-family:
tahoma,sans-serif; font-size: xx-small;
border-collapse: collapse;"><strong><span
style="font-size: 8pt;"><span><span
style="font-size: small;"><font
size="2"><span
style="font-weight: normal;">site: <a
moz-do-not-send="true"
href="http://www.10pines.com/"
style="color: rgb(17, 65,
112);" target="_blank">http://www.10Pines.com</a></span></font></span></span></span></strong></span></div>
<div><font face="tahoma, sans-serif"><span
style="border-collapse: collapse;">Address:
Alem 896</span></font>, Floor 6,
Buenos Aires, Argentina</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>