<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Hi Phil,<br>
<br>
On 5/8/2020 2:32 AM, Phil B via Cuis-dev wrote:
<blockquote
cite="mid:CAMJMOejZbGOiBXXS8b2eqs2a97DkEsp5A88X1EGnKnF4EbyePg@mail.gmail.com"
type="cite">
<div dir="ltr">I just ran a quick test... yes, let's please have a
fast save option! When I eliminated the
#releaseClassCachedState sends from the save process (and the
corresponding #initClassCachedState on the other side of the
save), the save took *maybe* 1/4 of a second.</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Fri, May 8, 2020 at 1:00 AM
Phil B <<a moz-do-not-send="true"
href="mailto:pbpublist@gmail.com">pbpublist@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
<div dir="ltr">I noticed that this method is significantly
slowing down image saves... taking upwards of 10 seconds.
Partially it's due to my Morphs now wiping and recreating a
bunch of state each save. But it's also partially due just
to the overhead of Morph allSubInstancesDo: [:ea| ] taking
~3-4 seconds to execute per save. (in an image with ~2k
morphs, which isn't that hard to get to)
<div><br>
<div>If the goal is to minimize saved image file size,
could we have options for a 'fast save' vs a 'small
save'? Unless I'm going to email/publish an image, I'd
prefer the save to be fast rather than small.</div>
</div>
</div>
</blockquote>
</div>
</blockquote>
<br>
We already have that. When you do a 'save as new version',
additional, more expensive cleanup is done.<br>
<br>
The problem here is that recently I added a 'Morph
allSubInstancesDo: [:ea| ]' on every image save. Apologies. Fix now
on GitHub.<br>
<br>
Thanks,<br>
<pre class="moz-signature" cols="72">--
Juan Vuletich
<a class="moz-txt-link-abbreviated" href="http://www.cuis-smalltalk.org">www.cuis-smalltalk.org</a>
<a class="moz-txt-link-freetext" href="https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev">https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev</a>
<a class="moz-txt-link-freetext" href="https://github.com/jvuletich">https://github.com/jvuletich</a>
<a class="moz-txt-link-freetext" href="https://www.linkedin.com/in/juan-vuletich-75611b3">https://www.linkedin.com/in/juan-vuletich-75611b3</a>
@JuanVuletich</pre>
</body>
</html>