<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Hi Hernán,<br>
<br>
The attaches to this message are all the changesets for this thread,
renumbered to reflect latest pushed updates.<br>
<br>
(inline)<br>
<br>
On 5/24/2020 6:01 PM, Hernan Wilkinson via Cuis-dev wrote:
<blockquote
cite="mid:CAJAbP8iqQ9dN3vfvF9232YM=wYRFPL0MM3v6SQ9EqaLaFkmymw@mail.gmail.com"
type="cite">
<div dir="ltr">Hi guys,
<div> nice work! thank you for making Cuis better every day.</div>
<div> I took a quick look at the code and I have some questions:</div>
<div>1) Why Inspector implements messages like #object: anObject
basicAt: index and the ones in that category? <br>
</div>
</div>
</blockquote>
<br>
To use the mirror primitives. This has two potential benefits
(although with regular objects it doesn't make any difference):<br>
- Inspecting a proxy or any other subclass of ProtoObject that uses
the DNU mechanism doesn't trigger it<br>
- Objects that might redefine those low level methods can no longer
"fool" the inspector.<br>
For that very same reason we removed #object.<br>
<br>
<blockquote
cite="mid:CAJAbP8iqQ9dN3vfvF9232YM=wYRFPL0MM3v6SQ9EqaLaFkmymw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>2) Object basicInspect does not use the basic inspector
anymore... why is that? The idea is to get rid off the
BasicInspector?</div>
</div>
</blockquote>
<br>
Yep. Just a regular inspector will do. We removed BasicInspector.
BasicInspector was moot.<br>
<br>
<blockquote
cite="mid:CAJAbP8iqQ9dN3vfvF9232YM=wYRFPL0MM3v6SQ9EqaLaFkmymw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div> I found a problem using the autocomplete in the
inspector's workspace panel because the message #object was
removed from Inspector. I'm not sure what's the idea behind
removing that message but adding it agin made the autocomplete
work.<br>
</div>
</div>
</blockquote>
<br>
Leaking the object outside the Inspector could lead to uncontrolled
materialization of proxies. That's why we removed #object. In this
case, all what was needed was #objectClass. I just made the change.
It is attached.<br>
<br>
<blockquote
cite="mid:CAJAbP8iqQ9dN3vfvF9232YM=wYRFPL0MM3v6SQ9EqaLaFkmymw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div> The Dictionary and Set inspector do not handle correctly
the remove/remove key/rename key when they are empty, but I
just verified that that error existed before.</div>
</div>
</blockquote>
<br>
Thanks for the report! Fix for that also attached.<br>
<br>
<blockquote
cite="mid:CAJAbP8iqQ9dN3vfvF9232YM=wYRFPL0MM3v6SQ9EqaLaFkmymw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div> I hope this helps.</div>
<div><br>
</div>
<div>Cheers!</div>
<div>Hernan.</div>
<div> </div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Sun, May 24, 2020 at 4:40
PM ken.dickey--- via Cuis-dev <<a moz-do-not-send="true"
href="mailto:cuis-dev@lists.cuis.st" target="_blank">cuis-dev@lists.cuis.st</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">On 2020-05-24 14:44, Andres Valloud via
Cuis-dev wrote:<br>
> Hi Ken, I can see the uncommenting of the code in
fileSize... just to<br>
> make sure, are you implying that this change is related
to the<br>
> inspector work? I do not immediately see how that would
be.<br>
<br>
No idea really. I just updated, loaded the changesets and use
of the <br>
FileList brought up the debugger.<br>
<br>
Guilt by association?<br>
<br>
<br>
> On 5/24/20 07:33, ken.dickey--- via Cuis-dev wrote:<br>
>> On 2020-05-24 12:32, Juan Vuletich via Cuis-dev
wrote:<br>
>>> On 5/22/2020 8:08 PM, Juan Vuletich via Cuis-dev
wrote:<br>
>>>> Hi Folks,<br>
>>>> <br>
>>>> Andrés Valloud and I found a couple of bugs
and inconsistencies in <br>
>>>> the Inspector hierarchy. If you don't mind
crashing your image you <br>
>>>> might try `(1 to: 2000) asFloat64Array`, or
inspecting an <br>
>>>> OrderedCollection with an object that fails
in #printOn:, and cycle <br>
>>>> the collection with the arrow keys.<br>
>>>> <br>
>>>> We did quite some refactor and cleanup. The
result is attached. <br>
>>>> Please take a look.<br>
>> <br>
>> FileEntry>>fileSize came up nil in FileList.
Lost cache update line <br>
>> (attached).<br>
>> <br>
>> FYI,<br>
>> -KenD<br>
>> <br>
-- <br>
Cuis-dev mailing list<br>
<a moz-do-not-send="true" href="mailto:Cuis-dev@lists.cuis.st"
target="_blank">Cuis-dev@lists.cuis.st</a><br>
<a moz-do-not-send="true"
href="https://lists.cuis.st/mailman/listinfo/cuis-dev"
rel="noreferrer" target="_blank">https://lists.cuis.st/mailman/listinfo/cuis-dev</a><br>
</blockquote>
</div>
<br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr">
<div dir="ltr">
<div>
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div><span style="font-family:
tahoma,sans-serif; font-size: xx-small;
border-collapse: collapse;"><strong><span
style="font-size: 8pt;"><span><span
style="font-size: small;"><font
size="2"><span
style="font-weight: normal;"><span
style="font-weight: bold;">Hernán
Wilkinson</span><br>
Agile Software Development,
Teaching & Coaching</span></font></span></span></span></strong></span></div>
<div><span style="font-family:
tahoma,sans-serif; font-size: xx-small;
border-collapse: collapse;"><strong><span
style="font-size: 8pt;"><span><span
style="font-size: small;"><font
size="2"><span
style="font-weight: normal;">Phone:
+54-011</span></font></span></span></span></strong></span><font
size="2" face="tahoma, sans-serif">-4893-2057</font></div>
<div><strong style="font-family:
tahoma,sans-serif; font-size: xx-small;"><span
style="font-size: 8pt;"><span
style="font-size: small;"><font
size="2"><span style="font-weight:
normal;">Twitter:
@HernanWilkinson</span></font></span></span></strong></div>
<div><span style="font-family:
tahoma,sans-serif; font-size: xx-small;
border-collapse: collapse;"><strong><span
style="font-size: 8pt;"><span><span
style="font-size: small;"><font
size="2"><span
style="font-weight: normal;">site: <a
moz-do-not-send="true"
href="http://www.10pines.com/"
style="color: rgb(17, 65,
112);" target="_blank">http://www.10Pines.com</a></span></font></span></span></span></strong></span></div>
<div><font face="tahoma, sans-serif"><span
style="border-collapse: collapse;">Address:
Alem 896</span></font>, Floor 6,
Buenos Aires, Argentina</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<br>
Thanks,<br>
<pre class="moz-signature" cols="72">--
Juan Vuletich
<a class="moz-txt-link-abbreviated" href="http://www.cuis-smalltalk.org">www.cuis-smalltalk.org</a>
<a class="moz-txt-link-freetext" href="https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev">https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev</a>
<a class="moz-txt-link-freetext" href="https://github.com/jvuletich">https://github.com/jvuletich</a>
<a class="moz-txt-link-freetext" href="https://www.linkedin.com/in/juan-vuletich-75611b3">https://www.linkedin.com/in/juan-vuletich-75611b3</a>
@JuanVuletich</pre>
</body>
</html>