<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
On 5/25/2020 7:35 PM, Hernan Wilkinson via Cuis-dev wrote:
<blockquote
cite="mid:CAJAbP8hyskzV2FU=9eG3AECgG==aRjeN1c2JQNRTVa-tFS0Y5w@mail.gmail.com"
type="cite">
<div dir="ltr">
<div dir="ltr">Hi Nahuel!<br>
<div> thank you for the improvements and fixes. All tests are
passing 💪💪</div>
<div> It is integrated.</div>
</div>
<div><br>
</div>
I have a few minor comments:
<div>1) I think I would change the error message "{variable}
cannot be used as temporary variable name because it is an
instance variable defined in XX" for "{variable} cannot be
used as temporary variable name because it is defined as
instance variable in XX"</div>
<div>What do English native speakers think it is best?</div>
<div>2) When doing the extract method if you select as selector
to extract the code the same as the method you are performing
the extract method, it will do it but the extracted code will
be lost. I think in that case it should not be a warning but
an error... only in that case :-)</div>
<div><br>
</div>
<div>Cheers!</div>
<div>Hernan.<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Mon, May 25, 2020 at
1:20 AM Nahuel Garbezza via Cuis-dev <<a
moz-do-not-send="true"
href="mailto:cuis-dev@lists.cuis.st">cuis-dev@lists.cuis.st</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
<div dir="ltr">Hi!
<div><br>
</div>
<div>Attached is a changeset with the following changes
(and their corresponding tests):</div>
<div><br>
</div>
<div>[extract temporary / rename temporary]<br>
- fix error message for instance variable already
defined in class<br>
- allow to perform the refactoring in a debugger<br>
<br>
[extract method]<br>
- extracting to an existing selector (in the current
class or any superclass) now raises a warning<br>
- allow to perform the refactoring in a debugger<br>
- improve error messages and validation logic<br>
<br>
[documentation]<br>
- add a comment on RefactoringPrecondition class<br>
</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Nahuel.</div>
</div>
-- <br>
Cuis-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:Cuis-dev@lists.cuis.st" target="_blank">Cuis-dev@lists.cuis.st</a><br>
<a moz-do-not-send="true"
href="https://lists.cuis.st/mailman/listinfo/cuis-dev"
rel="noreferrer" target="_blank">https://lists.cuis.st/mailman/listinfo/cuis-dev</a><br>
</blockquote>
</div>
<br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr" class="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div><span style="font-family:
tahoma,sans-serif; font-size:
xx-small; border-collapse:
collapse;"><strong><span
style="font-size: 8pt;"><span><span
style="font-size: small;"><font
size="2"><span
style="font-weight:
normal;"><span
style="font-weight:
bold;">Hernán
Wilkinson</span><br>
Agile Software
Development, Teaching
& Coaching</span></font></span></span></span></strong></span></div>
<div><span style="font-family:
tahoma,sans-serif; font-size:
xx-small; border-collapse:
collapse;"><strong><span
style="font-size: 8pt;"><span><span
style="font-size: small;"><font
size="2"><span
style="font-weight:
normal;">Phone: +54-011</span></font></span></span></span></strong></span><font
size="2" face="tahoma, sans-serif">-4893-2057</font></div>
<div><strong style="font-family:
tahoma,sans-serif; font-size:
xx-small;"><span style="font-size:
8pt;"><span style="font-size:
small;"><font size="2"><span
style="font-weight: normal;">Twitter:
@HernanWilkinson</span></font></span></span></strong></div>
<div><span style="font-family:
tahoma,sans-serif; font-size:
xx-small; border-collapse:
collapse;"><strong><span
style="font-size: 8pt;"><span><span
style="font-size: small;"><font
size="2"><span
style="font-weight:
normal;">site: <a
moz-do-not-send="true"
href="http://www.10pines.com/" style="color: rgb(17, 65, 112);"
target="_blank">http://www.10Pines.com</a></span></font></span></span></span></strong></span></div>
<div><font face="tahoma, sans-serif"><span
style="border-collapse: collapse;">Address:
Alem 896</span></font>, Floor 6,
Buenos Aires, Argentina</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<br>
Nice!<br>
<pre class="moz-signature" cols="72">--
Juan Vuletich
<a class="moz-txt-link-abbreviated" href="http://www.cuis-smalltalk.org">www.cuis-smalltalk.org</a>
<a class="moz-txt-link-freetext" href="https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev">https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev</a>
<a class="moz-txt-link-freetext" href="https://github.com/jvuletich">https://github.com/jvuletich</a>
<a class="moz-txt-link-freetext" href="https://www.linkedin.com/in/juan-vuletich-75611b3">https://www.linkedin.com/in/juan-vuletich-75611b3</a>
@JuanVuletich</pre>
</body>
</html>