<div dir="ltr">Hi!<div><br></div><div>Attached is a changeset for the updated error message, plus another suggestion from Hernan about SourceCodeInterval's #asSourceCodeInterval.</div><div><br></div><div>Thanks,</div><div>Nahuel</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">El lun., 25 de may. de 2020 a la(s) 20:02, Hernan Wilkinson via Cuis-dev (<a href="mailto:cuis-dev@lists.cuis.st">cuis-dev@lists.cuis.st</a>) escribió:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Thanks Andres!<br><div>Nahuel, could you change that error message as Andres suggests?</div><div><br></div><div>Hernan.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, May 25, 2020 at 7:47 PM Andres Valloud via Cuis-dev <<a href="mailto:cuis-dev@lists.cuis.st" target="_blank">cuis-dev@lists.cuis.st</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">{variable} cannot be used as [a] temporary variable name because it is <br> defined as [an] instance variable in XX.<br> <br> On 5/25/20 15:35, Hernan Wilkinson via Cuis-dev wrote:<br> > Hi Nahuel!<br> > thank you for the improvements and fixes. All tests are passing 💪💪<br> > It is integrated.<br> > <br> > I have a few minor comments:<br> > 1) I think I would change the error message "{variable} cannot be used <br> > as temporary variable name because it is an instance variable defined in <br> > XX" for "{variable} cannot be used as temporary variable name because it <br> > is defined as instance variable in XX"<br> > What do English native speakers think it is best?<br> > 2) When doing the extract method if you select as selector to extract <br> > the code the same as the method you are performing the extract method, <br> > it will do it but the extracted code will be lost. I think in that case <br> > it should not be a warning but an error... only in that case :-)<br> > <br> > Cheers!<br> > Hernan.<br> > On Mon, May 25, 2020 at 1:20 AM Nahuel Garbezza via Cuis-dev <br> > <<a href="mailto:cuis-dev@lists.cuis.st" target="_blank">cuis-dev@lists.cuis.st</a> <mailto:<a href="mailto:cuis-dev@lists.cuis.st" target="_blank">cuis-dev@lists.cuis.st</a>>> wrote:<br> > <br> > Hi!<br> > <br> > Attached is a changeset with the following changes (and their<br> > corresponding tests):<br> > <br> > [extract temporary / rename temporary]<br> > - fix error message for instance variable already defined in class<br> > - allow to perform the refactoring in a debugger<br> > <br> > [extract method]<br> > - extracting to an existing selector (in the current class or any<br> > superclass) now raises a warning<br> > - allow to perform the refactoring in a debugger<br> > - improve error messages and validation logic<br> > <br> > [documentation]<br> > - add a comment on RefactoringPrecondition class<br> > <br> > Thanks,<br> > Nahuel.<br> > -- <br> > Cuis-dev mailing list<br> > <a href="mailto:Cuis-dev@lists.cuis.st" target="_blank">Cuis-dev@lists.cuis.st</a> <mailto:<a href="mailto:Cuis-dev@lists.cuis.st" target="_blank">Cuis-dev@lists.cuis.st</a>><br> > <a href="https://lists.cuis.st/mailman/listinfo/cuis-dev" rel="noreferrer" target="_blank">https://lists.cuis.st/mailman/listinfo/cuis-dev</a><br> > <br> > <br> > <br> > -- <br> > *Hernán Wilkinson<br> > Agile Software Development, Teaching & Coaching*<br> > *Phone: +54-011*-4893-2057<br> > *Twitter: @HernanWilkinson*<br> > *site: <a href="http://www.10Pines.com" rel="noreferrer" target="_blank">http://www.10Pines.com</a> <<a href="http://www.10pines.com/" rel="noreferrer" target="_blank">http://www.10pines.com/</a>>*<br> > Address: Alem 896, Floor 6, Buenos Aires, Argentina<br> > <br> -- <br> Cuis-dev mailing list<br> <a href="mailto:Cuis-dev@lists.cuis.st" target="_blank">Cuis-dev@lists.cuis.st</a><br> <a href="https://lists.cuis.st/mailman/listinfo/cuis-dev" rel="noreferrer" target="_blank">https://lists.cuis.st/mailman/listinfo/cuis-dev</a><br> </blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr"><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div><span style="font-family:tahoma,sans-serif;font-size:xx-small;border-collapse:collapse"><strong><span style="font-size:8pt"><span><span style="font-size:small"><font size="2"><span style="font-weight:normal"><span style="font-weight:bold">Hernán Wilkinson</span><br>Agile Software Development, Teaching & Coaching</span></font></span></span></span></strong></span></div><div><span style="font-family:tahoma,sans-serif;font-size:xx-small;border-collapse:collapse"><strong><span style="font-size:8pt"><span><span style="font-size:small"><font size="2"><span style="font-weight:normal">Phone: +54-011</span></font></span></span></span></strong></span><font face="tahoma, sans-serif" size="2">-4893-2057</font></div><div><strong style="font-family:tahoma,sans-serif;font-size:xx-small"><span style="font-size:8pt"><span style="font-size:small"><font size="2"><span style="font-weight:normal">Twitter: @HernanWilkinson</span></font></span></span></strong></div><div><span style="font-family:tahoma,sans-serif;font-size:xx-small;border-collapse:collapse"><strong><span style="font-size:8pt"><span><span style="font-size:small"><font size="2"><span style="font-weight:normal">site: <a href="http://www.10pines.com/" style="color:rgb(17,65,112)" target="_blank">http://www.10Pines.com</a></span></font></span></span></span></strong></span></div><div><font face="tahoma, sans-serif"><span style="border-collapse:collapse">Address: Alem 896</span></font>, Floor 6, Buenos Aires, Argentina</div></div></div></div></div></div></div></div></div></div></div></div> -- <br> Cuis-dev mailing list<br> <a href="mailto:Cuis-dev@lists.cuis.st" target="_blank">Cuis-dev@lists.cuis.st</a><br> <a href="https://lists.cuis.st/mailman/listinfo/cuis-dev" rel="noreferrer" target="_blank">https://lists.cuis.st/mailman/listinfo/cuis-dev</a><br> </blockquote></div>