<div dir="ltr">Juan,<div><br></div><div>Much better, thanks.</div><div><br></div><div>FYI, in #drawWorldComputeDamage:repair:rootMorphs:rootMorphsDamage: it is possible for morphBounds in 'r intersect: morphBounds' to be nil.  Not sure yet if this is something in my code that still needs to be updated for the latest changes or if I'm hitting a case you hadn't anticipated.  I'm mentioning it because I'm wondering if there should be a #displayFullBoundsOrBogus (i.e. to be used by #drawWorldComputeDamage:repair:rootMorphs:rootMorphsDamage:) or should this case just not ever be happening?</div><div><br></div><div>Thanks,</div><div>Phil</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Aug 18, 2020 at 3:58 PM Juan Vuletich via Cuis-dev <<a href="mailto:cuis-dev@lists.cuis.st">cuis-dev@lists.cuis.st</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><u></u>

  
    
    
  
  <div bgcolor="#ffffff">
    I see. Please try the fixes I just pushed. Note that I pushed a
    modified version of #4352.<br>
    <br>
    Thanks,<br>
    <br>
    On 8/18/2020 3:33 PM, Phil B via Cuis-dev wrote:
    <blockquote type="cite">
      <div dir="ltr">Easier to show than describe: <a href="https://www.youtube.com/watch?v=E8lwDvqo0vo" target="_blank">https://www.youtube.com/watch?v=E8lwDvqo0vo</a>
        (screen damage both after the save and after restarting the
        image)</div>
      <br>
      <div class="gmail_quote">
        <div dir="ltr" class="gmail_attr">On Tue, Aug 18, 2020 at 6:27
          AM Juan Vuletich <<a href="mailto:juan@jvuletich.org" target="_blank">juan@jvuletich.org</a>>
          wrote:<br>
        </div>
        <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
          <div bgcolor="#ffffff"> On 8/18/2020 12:28 AM, Phil B via
            Cuis-dev wrote:
            <blockquote type="cite">
              <div dir="ltr">OK, sorry about this... I was hoping that
                getting to the latest updates would fix a display damage
                update bug that looks like it was introduced sometime
                after 4249, but it didn't.  Thinking I might have some
                other issue going on with my image, I tried starting
                with the 4342 image from the repo, updated it to 4352,
                then save and quit.  When I restart the image, the
                entire screen is white until I start forcing display
                damage (bring up the world menu, move windows around
                etc)... do you see this issue?   I'm
                running sqcogspur64linuxht-20200219 in case it matters.<br>
                <div><br>
                </div>
                <div>Thanks,</div>
                <div>Phil</div>
              </div>
            </blockquote>
            <br>
            Does the problem persist if you save as new version? If not,
            just do it.<br>
            <br>
            Des the latest image from GitHub (#4342) have the problem?
            If so, please provide the most detailed steps to reproduce
            you can. Think that it's all I have to start understanding
            the problem.<br>
            <br>
            Can the problem be reproduced again once the image is
            running? If so, again, detailed steps to reproduce, please.<br>
            <br>
            Thanks,<br>
            <br>
            <blockquote type="cite"><br>
              <div class="gmail_quote">
                <div dir="ltr" class="gmail_attr">On Mon, Aug 17, 2020
                  at 11:10 PM Phil B <<a href="mailto:pbpublist@gmail.com" target="_blank">pbpublist@gmail.com</a>>

                  wrote:<br>
                </div>
                <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
                  <div dir="ltr">Juan,
                    <div><br>
                    </div>
                    <div>Ahh!  That was the clarity I needed... it never
                      occurred to me that the issue would be that we
                      were saving the image using subtly different
                      methods and that would result in the
                      different behavior.  Now I get it and it's
                      working.
                      <div><br>
                      </div>
                      <div>Thanks,</div>
                      <div>Phil</div>
                    </div>
                  </div>
                  <br>
                  <div class="gmail_quote">
                    <div dir="ltr" class="gmail_attr">On Mon, Aug 17,
                      2020 at 10:04 PM Juan Vuletich <<a href="mailto:JuanVuletich@zoho.com" target="_blank">JuanVuletich@zoho.com</a>>
                      wrote:<br>
                    </div>
                    <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
                      <div bgcolor="#ffffff"> On 8/17/2020 9:18 PM, Phil
                        B via Cuis-dev wrote:
                        <blockquote type="cite">
                          <div dir="ltr">
                            <div dir="ltr">Juan,</div>
                            <br>
                            <div class="gmail_quote">
                              <div dir="ltr" class="gmail_attr">On Mon,
                                Aug 17, 2020 at 7:06 PM Juan Vuletich
                                <<a href="mailto:juan@jvuletich.org" target="_blank">juan@jvuletich.org</a>>

                                wrote:<br>
                              </div>
                              <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
                                <div bgcolor="#ffffff"> On 8/17/2020
                                  2:36 PM, Phil B via Cuis-dev wrote:
                                  <blockquote type="cite">
                                    <div dir="ltr">I tried updating
                                      straight through from
                                      4322->4351 (i.e. ignoring the
                                      message on 4342 saying I need to
                                      restart, since that would be the
                                      only way to avoid hanging after
                                      4342) </div>
                                  </blockquote>
                                  <br>
                                  No, the message says you "need to
                                  restart the image update". Transcript
                                  shows: 'Please restart [Install New
                                  Updates].'<br>
                                </div>
                              </blockquote>
                              <div><br>
                              </div>
                              <div>Right, but the issue is if I save and
                                quit, the image hangs on restart.  I
                                didn't expect it to work, but even with
                                your revised 4342, I'm still stuck
                                trying to restart after 4342 is applied.</div>
                              <div> </div>
                              <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
                                <div bgcolor="#ffffff"> <br>
                                  <blockquote type="cite">
                                    <div dir="ltr">but it still white
                                      screens for me on restart.  Does
                                      the world state fix need to be
                                      applied either right before or
                                      right after 4342? (I'm OK with a
                                      manual step if fixing it in the
                                      update changesets isn't feasible,
                                      I just need to know what the fix
                                      is and when to apply it)</div>
                                  </blockquote>
                                  <br>
                                  The fixes I did were to add a Delay
                                  wait in #4342, and the new #4350. But
                                  there is no need to apply them by
                                  hand. Just restart the update install.<br>
                                  <br>
                                  So, don't exit the image. Just do
                                  World / Changes... / Install New
                                  Updates. That should load the new
                                  updates, up to #4351. After that,
                                  saving and restarting should work.<br>
                                </div>
                              </blockquote>
                              <div><br>
                              </div>
                              <div>You see the contradiction, right?  If
                                I'm starting from 4322, and per your
                                previous statement, I *must* save and
                                quit after 4342 so I can restart. 
                                However, at that point things hang so I
                                can't apply anything after that.  I was
                                going straight through thinking 'this is
                                the only way I can see to accomplish
                                what Juan's saying... despite the update
                                telling me something different'   So
                                I've tried both restarting after 4342 as
                                well as going straight through: neither
                                results in a working image for me.</div>
                              <div> </div>
                            </div>
                          </div>
                        </blockquote>
                        <br>
                        No contradiction. Just misunderstanding. I'm
                        doing it again right now:<br>
                        <br>
                        - Start the image you provided, (previously
                        added a copy of an updated CoreUpdates/ folder).<br>
                        - Open the World menu / Changes... / Install New
                        Updates<br>
                        - Enter initials: jmv. Confirm it's me. Accept
                        the warning.<br>
                        - Wait a sec until update #4342 is installed,
                        and Transcript says "Please restart [Install New
                        Updates]."<br>
                        - Open the World menu / Changes... / Install New
                        Updates<br>
                        - Updates up to 4351 get installed.<br>
                        - Save as New Version.<br>
                        - Quit<br>
                        <br>
                        Saved image starts without problem.<br>
                        <br>
                        I found that if instead of Save as New Version,
                        you just Save and Quit, the resulting image
                        can't start. I just added another update to
                        GitHub for that case.<br>
                        <br>
                        Please try again now.<br>
                        <br>
                        Thanks,<br>
                        <pre cols="72">-- 
Juan Vuletich
<a href="http://www.cuis-smalltalk.org" target="_blank">www.cuis-smalltalk.org</a>
<a href="https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev" target="_blank">https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev</a>
<a href="https://github.com/jvuletich" target="_blank">https://github.com/jvuletich</a>
<a href="https://www.linkedin.com/in/juan-vuletich-75611b3" target="_blank">https://www.linkedin.com/in/juan-vuletich-75611b3</a>
@JuanVuletich</pre>
                      </div>
                    </blockquote>
                  </div>
                </blockquote>
              </div>
            </blockquote>
            <br>
            <br>
            <pre cols="72">-- 
Juan Vuletich
<a href="http://www.cuis-smalltalk.org" target="_blank">www.cuis-smalltalk.org</a>
<a href="https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev" target="_blank">https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev</a>
<a href="https://github.com/jvuletich" target="_blank">https://github.com/jvuletich</a>
<a href="https://www.linkedin.com/in/juan-vuletich-75611b3" target="_blank">https://www.linkedin.com/in/juan-vuletich-75611b3</a>
@JuanVuletich</pre>
          </div>
        </blockquote>
      </div>
    </blockquote>
    <br>
    <br>
    <pre cols="72">-- 
Juan Vuletich
<a href="http://www.cuis-smalltalk.org" target="_blank">www.cuis-smalltalk.org</a>
<a href="https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev" target="_blank">https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev</a>
<a href="https://github.com/jvuletich" target="_blank">https://github.com/jvuletich</a>
<a href="https://www.linkedin.com/in/juan-vuletich-75611b3" target="_blank">https://www.linkedin.com/in/juan-vuletich-75611b3</a>
@JuanVuletich</pre>
  </div>

-- <br>
Cuis-dev mailing list<br>
<a href="mailto:Cuis-dev@lists.cuis.st" target="_blank">Cuis-dev@lists.cuis.st</a><br>
<a href="https://lists.cuis.st/mailman/listinfo/cuis-dev" rel="noreferrer" target="_blank">https://lists.cuis.st/mailman/listinfo/cuis-dev</a><br>
</blockquote></div>