<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 9/23/2020 7:37 PM, Hernan Wilkinson via Cuis-dev wrote:
<blockquote
cite="mid:CAJAbP8ggdqBRV1jKocsw=VhFsEf34FjBTrX6FEVs0yq5AHULNg@mail.gmail.com"
type="cite">
<div dir="ltr">Hi,
<div> I'm attaching a cs that implements the message
request:orCancel: in StringRequestMorph because it was being
used in some packages not part of the main image.</div>
<div> The cs also changes some methods in StringRequestMorph to
make the more readable.</div>
<div><br>
</div>
</div>
</blockquote>
<br>
Integrated and @ GitHub.<br>
<br>
<blockquote
cite="mid:CAJAbP8ggdqBRV1jKocsw=VhFsEf34FjBTrX6FEVs0yq5AHULNg@mail.gmail.com"
type="cite">
<div dir="ltr">
<div> I'd also like to mention that I think we should improve
our communication when removing a method or changing a message
name. In this case the deleted method was request:onCancel:
and the keyword onCancel: used before in StringRequestMorph
was changed to orCancel: and that broke many things in some
packages we use in CuisUniverstiy.</div>
<div> One way to minimize this type of errors is to send
#deprecatedMethod before removing or renaming a message,
leaving the original method sending this message and after a
month or so, send an email to the list telling the methods
that will be removed (that is, senders or #deprecatedMethod).
I think that would help a bit.</div>
<div> If there are other ideas, please let's talk about them.</div>
<div><br>
</div>
</div>
</blockquote>
<br>
That would help. Something else we should be doing, is when we post
a change set for review, we'd specify (in the message body) the
methods we are asking to remove. That should give others the
opportunity to start the discussion earlier.<br>
<br>
Additionally, something I do and I suggest everyone should do, is
when removing methods or classes, load all the packages in the
Cuis-Smalltalk GitHub organization, to look for senders or
references. We'd also include other packages that are well
maintained but outside the organization, like CuisUniversity. We'd
add them to AllPackages.pck.st, and also to pullAllRepos.sh,
statusAllRepos.sh and clonePackageRepos.sh, maybe using a subfolder
for each repo and/or each owner.<br>
<br>
Doing this would raise awareness of possible problems as early as
possible, without slowing down possible cleanup.<br>
<br>
<blockquote
cite="mid:CAJAbP8ggdqBRV1jKocsw=VhFsEf34FjBTrX6FEVs0yq5AHULNg@mail.gmail.com"
type="cite">
<div dir="ltr">
<div> Cheers!</div>
<div> Hernan.</div>
<div><br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr" class="gmail_signature"
data-smartmail="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div><span style="font-family:
tahoma,sans-serif; font-size:
xx-small; border-collapse:
collapse;"><strong><span
style="font-size: 8pt;"><span><span
style="font-size: small;"><font
size="2"><span
style="font-weight:
normal;"><span
style="font-weight:
bold;">Hernán
Wilkinson</span><br>
Agile Software
Development, Teaching
& Coaching</span></font></span></span></span></strong></span></div>
<div><span style="font-family:
tahoma,sans-serif; font-size:
xx-small; border-collapse:
collapse;"><strong><span
style="font-size: 8pt;"><span><span
style="font-size: small;"><font
size="2"><span
style="font-weight:
normal;">Phone: +54-011</span></font></span></span></span></strong></span><font
size="2" face="tahoma, sans-serif">-4893-2057</font></div>
<div><strong style="font-family:
tahoma,sans-serif; font-size:
xx-small;"><span style="font-size:
8pt;"><span style="font-size:
small;"><font size="2"><span
style="font-weight: normal;">Twitter:
@HernanWilkinson</span></font></span></span></strong></div>
<div><span style="font-family:
tahoma,sans-serif; font-size:
xx-small; border-collapse:
collapse;"><strong><span
style="font-size: 8pt;"><span><span
style="font-size: small;"><font
size="2"><span
style="font-weight:
normal;">site: <a
moz-do-not-send="true"
href="http://www.10pines.com/" style="color: rgb(17, 65, 112);"
target="_blank">http://www.10Pines.com</a></span></font></span></span></span></strong></span></div>
<div><font face="tahoma, sans-serif"><span
style="border-collapse: collapse;">Address:
Alem 896</span></font>, Floor 6,
Buenos Aires, Argentina</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<br>
Thanks,<br>
<pre class="moz-signature" cols="72">--
Juan Vuletich
<a class="moz-txt-link-abbreviated" href="http://www.cuis-smalltalk.org">www.cuis-smalltalk.org</a>
<a class="moz-txt-link-freetext" href="https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev">https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev</a>
<a class="moz-txt-link-freetext" href="https://github.com/jvuletich">https://github.com/jvuletich</a>
<a class="moz-txt-link-freetext" href="https://www.linkedin.com/in/juan-vuletich-75611b3">https://www.linkedin.com/in/juan-vuletich-75611b3</a>
@JuanVuletich</pre>
</body>
</html>