<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Oct 14, 2020 at 9:27 AM Juan Vuletich via Cuis-dev <<a href="mailto:cuis-dev@lists.cuis.st">cuis-dev@lists.cuis.st</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><u></u>
<div bgcolor="#ffffff">
On 10/14/2020 8:58 AM, Hernan Wilkinson via Cuis-dev wrote:
<blockquote type="cite">
<div dir="ltr">Hi Juan,
<div> I like the idea, I also have problems understanding those
classes and the names are not good as you say.</div>
<div> Regarding StringMorph renamed to LabelMorph, shouldn't it
be LabelWidget? or will it be a subclass of Morph? ... if it
will be a subclass of WidgetMorph, I would call it LabelMorph
or LabelWidget. <br>
</div>
</div>
</blockquote>
<br>
All widgets should be in the WidgetMorph hierarchy. WidgetMorph is
subclass of Morph. But using the suffix 'Widget' for Label means it
should also be used for all the other Widgets, that are almost all
of the Morph hierarchy. I'd leave it with a 'Morph' suffix, at least
for now.<br>
<br>
Phil said he'd prefer not to rename it, and leave it as StringMorph.
If no one has strong opinions, we can ditch that idea.<br></div></blockquote><div><br></div><div>fine with me</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#ffffff">
<br>
<blockquote type="cite">
<div dir="ltr">
<div> Regarding the migration, I think we have to find a way for
all the current packages to be aware of these changes... It
would be great to have all the affected packages loaded so
when renaming the classes that would rename all its references
in packages and then you could provide the changes of them...
do you see that possible? (of course that what it means all
packages has to be decided). If not, we need to look for a way
to facilitate the migration.</div>
</div>
</blockquote>
<br>
What I always do is do these kind of changes after loading
<a href="http://AllPackages.pck.st" target="_blank">AllPackages.pck.st</a>. This includes all the repos in the
Cuis-Smalltalk GitHub organization. So, I also update all those
packages. But I don't check any packages besides those. </div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#ffffff">
<br>
In any case, I'm also suggesting a <a href="http://DeprecatedMorphs.pck.st" target="_blank">DeprecatedMorphs.pck.st</a> package.<br></div></blockquote><div><br></div><div>Ok... we have a lot of packages outside the cuis-smaltalk repo but that will help. </div><div>It would be nice to have a better source code management system where those changes are applied automatically... anyway, just missing OOSCM</div><div><br></div><div>Hernan.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#ffffff">
<br>
Thanks,<br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div><br>
</div>
<div> Cheers!</div>
<div> Hernan.</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, Oct 13, 2020 at 5:22
PM Juan Vuletich <<a href="mailto:juan@jvuletich.org" target="_blank">juan@jvuletich.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 10/13/2020 2:44 PM, Phil B via Cuis-dev
wrote:<br>
> Juan,<br>
><br>
> Not wild about the StringMorph->LabelMorph idea...
looks like <br>
> rearranging the lawn furniture to me as the existing name
seems <br>
> accurate and clear.<br>
<br>
Ok. Let's listen to other opinions. Leaving it like it is is
also ok for me.<br>
<br>
> Re: the rest, hopefully the final step would be to merge
<br>
> RectangleLikeMorph and BorderedRect back into
RectangleMorph and move <br>
> it to someplace like goodies.<br>
<br>
I think we can do better than that. RectangleLikeMorph and
BorderedRect <br>
can't be rotated, for instance. We'd include a basic library
of vector <br>
graphics shapes to play with. We're slowly walking in that
direction.<br>
<br>
> The first question new users often have re: Morphic is
'how do I <br>
> instantiate or create my own Morph?' and a clean
RectangleMorph would <br>
> provide that as a trivial Morph for instantiating and
subclassing. <br>
> (i.e. rather than deprecating it and prolonging the
confusion/pain, <br>
> keep a cleaned up version around specifically for
tutorials/testing <br>
> where you don't have to worry about features creeping in
over the <br>
> years breaking things)<br>
<br>
I agree with the concern, but I don't like RectangleMorph or <br>
BorderedRectMorph for that. Squeak has a pretty nice set of
morphs to <br>
play with. Cuis doesn't include them because they look ugly
without a <br>
good vector engine, and because the implementation of scaling
and <br>
rotation is not good enough. VectorGraphics allows to do all
that and <br>
more, with nicer code and better looks.<br>
<br>
> Also, make sure the widget class is explicitly documented
as abstract <br>
> just like Morph should be (how many times have we had
people confused <br>
> about why instantiating Morph has problems?)<br>
<br>
But Morph, RectangleMorph and BorderedRectMorph, all can be
instantiated <br>
and used. If something breaks, please tell.<br>
<br>
><br>
> Thanks,<br>
> Phil<br>
><br>
<br>
Thanks,<br>
<br>
-- <br>
Juan Vuletich<br>
<a href="http://www.cuis-smalltalk.org" rel="noreferrer" target="_blank">www.cuis-smalltalk.org</a><br>
<a href="https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev" rel="noreferrer" target="_blank">https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev</a><br>
<a href="https://github.com/jvuletich" rel="noreferrer" target="_blank">https://github.com/jvuletich</a><br>
<a href="https://www.linkedin.com/in/juan-vuletich-75611b3" rel="noreferrer" target="_blank">https://www.linkedin.com/in/juan-vuletich-75611b3</a><br>
@JuanVuletich<br>
<br>
</blockquote>
</div>
<br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr">
<div dir="ltr">
<div><span style="font-size:xx-small;border-collapse:collapse">
<div style="font-size:small">
<div><span style="font-family:tahoma,sans-serif;font-size:xx-small;border-collapse:collapse"><strong><span style="font-size:8pt"><span style="font-size:small"><font size="2"><span style="font-weight:normal"><span style="font-weight:bold">Hernán
Wilkinson</span><br>
Agile Software Development, Teaching &
Coaching</span></font></span></span></strong></span></div>
<div><span style="font-family:tahoma,sans-serif;font-size:xx-small;border-collapse:collapse"><strong><span style="font-size:8pt"><span style="font-size:small"><font size="2"><span style="font-weight:normal">Phone:
+54-011</span></font></span></span></strong></span><font size="2" face="tahoma, sans-serif">-4893-2057</font></div>
<div><strong style="font-family:tahoma,sans-serif;font-size:xx-small"><span style="font-size:8pt"><span style="font-size:small"><font size="2"><span style="font-weight:normal">Twitter:
@HernanWilkinson</span></font></span></span></strong></div>
<div><span style="font-family:tahoma,sans-serif;font-size:xx-small;border-collapse:collapse"><strong><span style="font-size:8pt"><span style="font-size:small"><font size="2"><span style="font-weight:normal">site: <a href="http://www.10pines.com/" style="color:rgb(17,65,112)" target="_blank">http://www.10Pines.com</a></span></font></span></span></strong></span></div>
<div><font face="tahoma, sans-serif"><span style="border-collapse:collapse">Address: Alem
896</span></font>, Floor 6, Buenos Aires,
Argentina</div>
</div>
</span></div>
</div>
</div>
</blockquote>
<br>
<br>
<pre cols="72">--
Juan Vuletich
<a href="http://www.cuis-smalltalk.org" target="_blank">www.cuis-smalltalk.org</a>
<a href="https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev" target="_blank">https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev</a>
<a href="https://github.com/jvuletich" target="_blank">https://github.com/jvuletich</a>
<a href="https://www.linkedin.com/in/juan-vuletich-75611b3" target="_blank">https://www.linkedin.com/in/juan-vuletich-75611b3</a>
@JuanVuletich</pre>
</div>
-- <br>
Cuis-dev mailing list<br>
<a href="mailto:Cuis-dev@lists.cuis.st" target="_blank">Cuis-dev@lists.cuis.st</a><br>
<a href="https://lists.cuis.st/mailman/listinfo/cuis-dev" rel="noreferrer" target="_blank">https://lists.cuis.st/mailman/listinfo/cuis-dev</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><span style="font-size:xx-small;border-collapse:collapse"><div style="font-size:small"><div><span style="font-family:tahoma,sans-serif;font-size:xx-small;border-collapse:collapse"><strong><span style="font-size:8pt"><span style="font-size:small"><font size="2"><span style="font-weight:normal"><span style="font-weight:bold">Hernán Wilkinson</span><br>Agile Software Development, Teaching & Coaching</span></font></span></span></strong></span></div><div><span style="font-family:tahoma,sans-serif;font-size:xx-small;border-collapse:collapse"><strong><span style="font-size:8pt"><span style="font-size:small"><font size="2"><span style="font-weight:normal">Phone: +54-011</span></font></span></span></strong></span><font face="tahoma, sans-serif" size="2">-4893-2057</font></div><div><strong style="font-family:tahoma,sans-serif;font-size:xx-small"><span style="font-size:8pt"><span style="font-size:small"><font size="2"><span style="font-weight:normal">Twitter: @HernanWilkinson</span></font></span></span></strong></div><div><span style="font-family:tahoma,sans-serif;font-size:xx-small;border-collapse:collapse"><strong><span style="font-size:8pt"><span style="font-size:small"><font size="2"><span style="font-weight:normal">site: <a href="http://www.10pines.com/" style="color:rgb(17,65,112)" target="_blank">http://www.10Pines.com</a></span></font></span></span></strong></span></div><div><font face="tahoma, sans-serif"><span style="border-collapse:collapse">Address: Alem 896</span></font>, Floor 6, Buenos Aires, Argentina</div></div></span></div></div></div></div>