<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Integrated.<br>
<br>
Thanks!<br>
<br>
On 12/9/2020 9:25 PM, Mauro Rizzi via Cuis-dev wrote:
<blockquote
cite="mid:CAMLYRA2d=5qBbsmdtbmbuGD=r7o67FB7yFLS=7NmRvnAd-g5aQ@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>Hello Juan,</div>
<div><br>
</div>
<div>I discovered the renameCategory option uses the class side
of StringRequestMorph to make the request and made the
appropriate changes so it follows the same behaviour as every
other dialogue.</div>
<div><br>
</div>
<div>I'm unsure what you need to add this so I'm attaching two
changesets, one that includes both this fix and the previous
one and one that only includes the fix.</div>
<div>Note: The fix changeset (The one made in Dec09) requires
the first changeset to be installed to work.</div>
<div><br>
</div>
<div>Cheers!</div>
<div><b>Mauro Rizzi</b><br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">El mar, 8 dic 2020 a las
17:32, Juan Vuletich (<<a moz-do-not-send="true"
href="mailto:juan@jvuletich.org">juan@jvuletich.org</a>>)
escribió:<br>
</div>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
<div bgcolor="#ffffff"> On 12/7/2020 8:58 PM, Mauro Rizzi via
Cuis-dev wrote:
<blockquote type="cite">
<div dir="ltr">
<div>Oops!</div>
<div><br>
</div>
<div>What I thought was a bug because of this changeset
is actually standard behaviour so the changeset
actually works as intended.</div>
<div><br>
</div>
<div>I'll happily look into any errors you guys can
find!</div>
<div><br>
</div>
<div>Cheers!</div>
<div><b>Mauro Rizzi</b><br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">El lun, 7 dic 2020 a
las 18:30, Mauro Rizzi (<<a moz-do-not-send="true"
href="mailto:mrizzi@fi.uba.ar" target="_blank">mrizzi@fi.uba.ar</a>>)
escribió:<br>
</div>
<blockquote class="gmail_quote" style="margin: 0px 0px
0px 0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
<div dir="ltr">
<div>Hello everyone, <br>
</div>
<div><br>
</div>
<div>I didn't go deep enough testing it and now
realized things like the debugger will
automatically focus the last created
StringRequestMorph in its composition so maybe
this isn't the final solution.</div>
<div><br>
</div>
<div>I'm looking into coming up with a fix.</div>
<div><br>
</div>
<div>Cheers!</div>
<div><b>Mauro Rizzi</b><br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">El lun, 7 dic 2020
a las 16:38, Mauro Rizzi (<<a
moz-do-not-send="true"
href="mailto:mrizzi@fi.uba.ar" target="_blank">mrizzi@fi.uba.ar</a>>)
escribió:<br>
</div>
<blockquote class="gmail_quote" style="margin: 0px
0px 0px 0.8ex; border-left: 1px solid rgb(204,
204, 204); padding-left: 1ex;">
<div dir="ltr">
<div>Hello everyone!</div>
<div><br>
</div>
<div>I got tired of having to click on text
boxes every time I tried to rename something
(when using click to focus) and decided to do
something about it.</div>
<div><br>
</div>
<div>Attached you'll find a changeset that makes
it so those string request dialogue boxes
automatically gain focus when created (It
seems to be standard behaviour for the rest of
the system but not for this particular class).</div>
<div><br>
</div>
<div>I would also like to request this change be
introduced to the base image.</div>
<div><br>
</div>
<div>If you check the changeset the changes to
the base codebase are minimal, and judging by
the left over " textPane focusText." comment
they were intended to exist at some point.</div>
<div><br>
</div>
<div>Only thing I'm unsure about is if I should
check that we're on the click to focus setting
or not.<br>
</div>
<div><br>
</div>
<div>Cheers!</div>
<div><b>Mauro Rizzi</b><br>
</div>
</div>
</blockquote>
</div>
</blockquote>
</div>
</blockquote>
<br>
Integrated.<br>
<br>
Thanks!<br>
<pre cols="72">--
Juan Vuletich
<a moz-do-not-send="true" href="http://www.cuis-smalltalk.org" target="_blank">www.cuis-smalltalk.org</a>
<a moz-do-not-send="true" href="https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev" target="_blank">https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev</a>
<a moz-do-not-send="true" href="https://github.com/jvuletich" target="_blank">https://github.com/jvuletich</a>
<a moz-do-not-send="true" href="https://www.linkedin.com/in/juan-vuletich-75611b3" target="_blank">https://www.linkedin.com/in/juan-vuletich-75611b3</a>
@JuanVuletich</pre>
</div>
</blockquote>
</div>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Juan Vuletich
<a class="moz-txt-link-abbreviated" href="http://www.cuis-smalltalk.org">www.cuis-smalltalk.org</a>
<a class="moz-txt-link-freetext" href="https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev">https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev</a>
<a class="moz-txt-link-freetext" href="https://github.com/jvuletich">https://github.com/jvuletich</a>
<a class="moz-txt-link-freetext" href="https://www.linkedin.com/in/juan-vuletich-75611b3">https://www.linkedin.com/in/juan-vuletich-75611b3</a>
@JuanVuletich</pre>
</body>
</html>