<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<br>
Hi Hernan,<br>
<br>
. forget the code and test. I can rewrite it from scratch with test.
I actually changed<br>
existing code for "politeness" ;) <br>
<br>
. for me it is very important to have this matter fixed, well and
for the future.<br>
It is not good to have standard lib functionality disseminated in my
application packages.<br>
<br>
. since I found Linux stdlib has a function to do well what i want i
will use that name(s)<br>
to avoid confusion and recycle already existing function names.
"getline" and "getdelim".<br>
<br>
. if you really dislike this functions I can put them in OSProcess
and maybe <br>
just link the C version only for Linux/BSD. So much I think they are
valuable in the server environment.<br>
<br>
. to fix this i need maybe 1-2 days. If i need to link the C
functions I don't know, since I never tried.<br>
<br>
So, let me know, if you are not against these functions I am open to
implement them well.<br>
<br>
<br>
===== Extra considerations whose reading is secondary
==================<br>
<br>
. your fix was one step in the right direction but not enough, you
also need to<br>
bring back the stream pointer to the last existant $A. This is to
say: too complex.<br>
A good method must do all its chore, not leave us back the dirty
business and special conditions.<br>
<br>
. I understand the concision, small core etc. On the other side, i <br>
run Cuis on the servers. the most important thing there is on
servers are files and<br>
sockets. You must read from there all of the time. It must be easy
and idiot proof,<br>
rock solid and resistant to concurrent processing as far as
possible.<br>
<br>
. I see that Python and Ruby standard library do it wrong, at bit
better than Cuis 'upTo' does.<br>
but still bad. They leave you the '\n' at the end, but, if any
process goes on writing<br>
'f1.txt' Ruby and Python lost the half backed record ! <br>
-------- Linux<br>
<span style="font-family:monospace"><span
style="color:#000000;background-color:#ffffff;">$> printf
'line-1\nline-2\nline-TRAP' > f1.txt<br>
# python<br>
$> </span></span><span style="font-family:monospace"><span
style="color:#000000;background-color:#ffffff;"><span
style="font-family:monospace"><span
style="color:#000000;background-color:#ffffff;">python3.9 -c
"f=open('f1.txt','r'); print(f.readlines())" </span><br>
</span>=> </span></span><span style="font-family:monospace"><span
style="color:#000000;background-color:#ffffff;"><span
style="font-family:monospace"><span
style="color:#000000;background-color:#ffffff;">['line-1\n',
'line-2\n', 'line-TRAP']</span><br>
# ruby <br>
$> </span></span></span><span
style="font-family:monospace"><span
style="color:#000000;background-color:#ffffff;"><span
style="font-family:monospace"><span
style="font-family:monospace"><span
style="color:#000000;background-color:#ffffff;">ruby -e
"f=open('f1.txt','r'); puts f.readlines().to_s; "
</span><br>
=> ["line-1\n", "line-2\n", "line-TRAP"]<br>
# both Python and Ruby ate the half backed record ! bad !<br>
</span></span>---------------------------------------------------------<br>
</span></span><br>
. C and CommonLisp standard libraries have a way to do it right:<br>
-) CL read-line.
<a class="moz-txt-link-freetext" href="http://www.lispworks.com/documentation/HyperSpec/Body/f_rd_lin.htm#read-line">http://www.lispworks.com/documentation/HyperSpec/Body/f_rd_lin.htm#read-line</a>
<br>
-) C getline. <a class="moz-txt-link-freetext" href="https://man7.org/linux/man-pages/man3/getline.3.html">https://man7.org/linux/man-pages/man3/getline.3.html</a><br>
<br>
. I understand I am probably the only one running Cuis in the server
so I am the first<br>
to step into a few particular problems.<br>
<br>
. In my opinion Cuis in the Server can be a good match, up to now i
have 2 small<br>
company services working and a big one project in continuous
development. <br>
Time will tell. Sturdiness, undertandability and ease of
modification were my top priority.<br>
Up to now things are at least working.<br>
<br>
======================================================<br>
<br>
bye<br>
Nicola<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<div class="moz-cite-prefix">On 10/21/21 14:53, Hernan Wilkinson
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAJAbP8hzu7maC8VB1s0Jg7t1RZUGQEiaeoJOENYFMNX9iWkpHQ@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">Hi Nicola,
<div> I see your point regarding the functionality of upTo:, but
you can easily overcome that using #peekBack. Using you
example: </div>
<div>-----</div>
<div>s _ 'hello-1Ahello-2Ahel'.<br>
'/tmp/test.txt' asFileEntry fileContents: s.<br>
<br>
st1 _ '/tmp/test.txt' asFileEntry readStream .<br>
<br>
st1 upTo: $A. " 'hello-1' "</div>
<div>st1 upTo: $A. " 'hello-2' "<br>
st1 upTo: $A. " 'hel' " </div>
<div>(st1 atEnd and: [ st1 peekBack ~= $A ]) ifTrue: [ self
error: 'End of file without delimiter ]. <br>
</div>
<div>------</div>
<div> </div>
<div> Regarding my concern of adding this functionality to Cuis,
we are trying to have a compact set of classes and methods to
reduce complexity (or at least not increase it) and help
newcomers to understand it and oldies to remember it :-) . We
are also trying to add more and more tests because it is the
only way to keep a system from becoming a legacy one and to
reduce the fear it produces to change something.</div>
<div> The strictUpTo:startPos: you are sending is almost a copy
of the upTo: method, with a few lines changed. Even though the
functionality makes sense (although right now you are the only
one needing it and as I said, you can use peekBack to overcome
it), adding that method adds repeated code which in the long
term makes it more difficult to understand and maintain, even
more because it does not have tests.</div>
<div> So I hope you understand that as maintainers of Cuis, we
want to be loyal to the goals I mentioned before and keep Cuis
as clean and simple as possible. If you can refactor what you
sent to avoid having repeated code with #upTo: and add tests
that verify the functionality of both methods (strictUpTo: and
upTo:), that will make our task easier and meet the goals we
have. If you think this does not make sense to you, or you do
not have the time to do it, it is completely understandable
and in that case I suggest for you to have it as an extension
of the StandardFileStream class or just use the peekBack
message as I showed.</div>
<div> I hope you understand my concern and agree with me. If
not, please let me know.</div>
<div><br>
</div>
<div>Cheers!</div>
<div>Hernan.</div>
<div><br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, Oct 19, 2021 at 10:32
AM Nicola Mingotti <<a href="mailto:nmingotti@gmail.com"
moz-do-not-send="true" class="moz-txt-link-freetext">nmingotti@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div> <br>
Hi Hernan,<br>
<br>
In all frankness, in I would wipe out the old 'upTo' because
its behavior is a bit "wild".<br>
<br>
On the other side, I understand it may create problems in
retro-compatibility, that is why for<br>
the moment i propose to add a new method which behaves a bit
better.<br>
<br>
I hope this example explains the problem:<br>
-------------------------------------------------------<br>
s _ 'hello-1Ahello-2Ahel'.<br>
'/tmp/test.txt' asFileEntry fileContents: s. <br>
<br>
st1 _ '/tmp/test.txt' asFileEntry readStream . <br>
<br>
st1 upTo: $A. " 'hello-1' "<br>
st1 upTo: $A. " 'hello-2' "<br>
st1 upTo: $A. " 'hel' " "(*)"<br>
------------------------------------------------------<br>
(*) You can't establish in any way if you actually found an
"A" terminated block or just hit the end of file<br>
(*) If you hit the end of file you eat an incomplete record,
this is another problem, maybe another process<br>
was going to end writing that record but you will never
know. <br>
<br>
Maybe there is another method around that performs similarly
to 'strictUpTp', if there is I did not find it, sorry.<br>
<br>
IMHO, In a scale of importance from 0 to 10, this method,
for a programmer, >= 8.<br>
I would definitely not put it into an external package, too
much fundamental.<br>
<br>
bye<br>
Nicola<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<div>On 10/19/21 14:44, Hernan Wilkinson wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hi Nicola!<br>
<div> I was wondering, why are you suggesting adding
them to the base? Is it not enough to implement them
as an extension in your package? </div>
<div> Also, I think that any new functionality should
come with its corresponding tests to help the
maintenance and understanding of the functionality.</div>
<div><br>
</div>
<div>Cheers!</div>
<div>Hernan.</div>
<div><br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, Oct 19, 2021
at 7:04 AM Nicola Mingotti via Cuis-dev <<a
href="mailto:cuis-dev@lists.cuis.st" target="_blank"
moz-do-not-send="true" class="moz-txt-link-freetext">cuis-dev@lists.cuis.st</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px
0px 0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div> <font size="4"><font face="monospace">Hi Juan,
guys,<br>
<br>
I would like to add to Cuis the 2 methods i
attach here. One is a helper method.<br>
<br>
-----------<br>
StandardFileStream strictUpTo: delim.<br>
-----------<br>
<br>
Differently from 'upTo: delim' this method:<br>
1. Does not return stuff if it does not find
'delim'.<br>
2. Does not upgrade the position on the stream
if does not find 'delim'.<br>
3. If it finds 'delim' returns a chunk that
includes it.<br>
<br>
I am parsing log files at the moment, this is
very much useful.<br>
<br>
NOTE. Up to now I tested only on small files.<br>
<br>
bye<br>
Nicola<br>
<br>
<br>
<br>
<br>
</font></font> </div>
-- <br>
Cuis-dev mailing list<br>
<a href="mailto:Cuis-dev@lists.cuis.st"
target="_blank" moz-do-not-send="true"
class="moz-txt-link-freetext">Cuis-dev@lists.cuis.st</a><br>
<a
href="https://lists.cuis.st/mailman/listinfo/cuis-dev"
rel="noreferrer" target="_blank"
moz-do-not-send="true" class="moz-txt-link-freetext">https://lists.cuis.st/mailman/listinfo/cuis-dev</a><br>
</blockquote>
</div>
<br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr">
<div dir="ltr"><span
style="font-size:xx-small;border-collapse:collapse">
<div style="font-size:small"><a
href="https://10pines.com/"
style="font-family:Roboto,Helvetica,Arial,sans-serif;font-size:medium"
target="_blank" moz-do-not-send="true"><img
src="https://10pines.github.io/email-signature/10pines-firma@2x.png"
style="margin-bottom: 0.5em;"
moz-do-not-send="true" width="108"></a><span
style="color:rgb(0,0,0);font-family:Roboto,Helvetica,Arial,sans-serif;font-size:medium"></span>
<h1 style="margin:0px;font-size:14px">Hernán
Wilkinson</h1>
<h2 style="margin:0px 0px
1em;font-size:14px;color:rgb(100,100,100)">Software
Developer & Coach</h2>
<p
style="margin:0px;color:rgb(100,100,100);font-size:12px">Alem
896, Floor 6, Buenos Aires, Argentina</p>
<p
style="margin:0px;color:rgb(100,100,100);font-size:12px">+54
11 6091 3125</p>
<p
style="margin:0px;color:rgb(100,100,100);font-size:12px">@HernanWilkinson</p>
</div>
</span></div>
</div>
</blockquote>
<br>
</div>
</blockquote>
</div>
<br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr" class="gmail_signature">
<div dir="ltr"><span
style="font-size:xx-small;border-collapse:collapse">
<div style="font-size:small"><a href="https://10pines.com/"
style="font-family:Roboto,Helvetica,Arial,sans-serif;font-size:medium"
target="_blank" moz-do-not-send="true"><img
src="https://10pines.github.io/email-signature/10pines-firma@2x.png"
style="margin-bottom: 0.5em;" moz-do-not-send="true"
width="108"></a><span
style="color:rgb(0,0,0);font-family:Roboto,Helvetica,Arial,sans-serif;font-size:medium"></span>
<h1 style="margin:0px;font-size:14px">Hernán Wilkinson</h1>
<h2 style="margin:0px 0px
1em;font-size:14px;color:rgb(100,100,100)">Software
Developer & Coach</h2>
<p
style="margin:0px;color:rgb(100,100,100);font-size:12px">Alem
896, Floor 6, Buenos Aires, Argentina</p>
<p
style="margin:0px;color:rgb(100,100,100);font-size:12px">+54
11 6091 3125</p>
<p
style="margin:0px;color:rgb(100,100,100);font-size:12px">@HernanWilkinson</p>
</div>
</span></div>
</div>
</blockquote>
<br>
</body>
</html>