<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=Windows-1252"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="#954F72" style="word-wrap:break-word"> <div class="WordSection1"> <div> Hi Juan, all,<o:p></o:p> Happy to hear from you :)<o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt;box-sizing: border-box;margin:1rem 0px 1rem 0.5ch;padding-left:2ch;border-left:var(--border-color);color:var(--accent-color);font-variant-ligatures: normal;font-variant-caps: normal;orphans: 2;text-align:start;widows: 2;-webkit-text-stroke-width: 0px;text-decoration-thickness: initial;text-decoration-style: initial;text-decoration-color: initial;overflow:hidden;word-spacing:0px"> Hello Jaromir, Folks,<o:p></o:p> I took a look at the code, and it looks correct to me, although I don't understand this well enough to be sure. All the tests you wrote last year pass, and that is great.<o:p></o:p> I think we'd integrate this. Still, I think it could be good to keep the current #terminate as a separate method, maybe #terminateFromForkedProcess, just in case it proves useful in the future.<o:p></o:p> </blockquote> <p class="md-end-block" style="box-sizing: border-box;line-height:inherit;orphans: 4;margin:1rem 0px;white-space:pre-wrap;font-variant-ligatures: normal;font-variant-caps: normal;text-align:start;widows: 2;-webkit-text-stroke-width: 0px;text-decoration-thickness: initial;text-decoration-style: initial;text-decoration-color: initial;word-spacing:0px"> Thanks very much for reviewing the code; I think this is a good idea to keep the older version, at least for a while. I'm really happy it's been stable and nobody complained :)<o:p></o:p> <p class="md-end-block" style="box-sizing: border-box;line-height:inherit;orphans: 4;margin:1rem 0px;white-space:pre-wrap;font-variant-ligatures: normal;font-variant-caps: normal;text-align:start;widows: 2;-webkit-text-stroke-width: 0px;text-decoration-thickness: initial;text-decoration-style: initial;text-decoration-color: initial;word-spacing:0px"> This new approach of one process using two stacks simplifies the code substantially but let's keep an eye on it, for sure. Later, if this terminate proves as stable as the current one, the exact same approach could be used for exception unwinds too (ContextPart>>resume: etc).<o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt;box-sizing: border-box;margin:1rem 0px 1rem 0.5ch;padding-left:2ch;border-left:var(--border-color);color:var(--accent-color);font-variant-ligatures: normal;font-variant-caps: normal;orphans: 2;text-align:start;widows: 2;-webkit-text-stroke-width: 0px;text-decoration-thickness: initial;text-decoration-style: initial;text-decoration-color: initial;overflow:hidden;word-spacing:0px"> I'd be very thankful if others could take a look, and better yet, try it and see if it brings any trouble.<o:p></o:p> </blockquote> <p class="md-end-block" style="box-sizing: border-box;line-height:inherit;orphans: 4;margin:1rem 0px;white-space:pre-wrap;font-variant-ligatures: normal;font-variant-caps: normal;text-align:start;widows: 2;-webkit-text-stroke-width: 0px;text-decoration-thickness: initial;text-decoration-style: initial;text-decoration-color: initial;word-spacing:0px"> That would be great, thanks again; any concerns or suspicions, please tell me.<o:p></o:p> <p class="md-end-block" style="box-sizing: border-box;line-height:inherit;orphans: 4;margin:1rem 0px;white-space:pre-wrap;font-variant-ligatures: normal;font-variant-caps: normal;text-align:start;widows: 2;-webkit-text-stroke-width: 0px;text-decoration-thickness: initial;text-decoration-style: initial;text-decoration-color: initial;word-spacing:0px"> Best regards,<o:p></o:p> <p class="md-end-block" style="box-sizing: border-box;line-height:inherit;orphans: 4;margin:1rem 0px;white-space:pre-wrap;font-variant-ligatures: normal;font-variant-caps: normal;text-align:start;widows: 2;-webkit-text-stroke-width: 0px;text-decoration-thickness: initial;text-decoration-style: initial;text-decoration-color: initial;word-spacing:0px"> Jaromir<o:p></o:p> <p class="md-end-block" style="box-sizing: border-box;line-height:inherit;orphans: 4;margin:1rem 0px;white-space:pre-wrap;font-variant-ligatures: normal;font-variant-caps: normal;text-align:start;widows: 2;-webkit-text-stroke-width: 0px;text-decoration-thickness: initial;text-decoration-style: initial;text-decoration-color: initial;word-spacing:0px"> --<o:p></o:p> <p class="md-end-block" style="box-sizing: border-box;line-height:inherit;orphans: 4;margin:1rem 0px;white-space:pre-wrap;font-variant-ligatures: normal;font-variant-caps: normal;text-align:start;widows: 2;-webkit-text-stroke-width: 0px;text-decoration-thickness: initial;text-decoration-style: initial;text-decoration-color: initial;word-spacing:0px"> Jaromir Matas<o:p></o:p> </div> <o:p> </o:p> <o:p> </o:p> <div style="mso-element:para-border-div;border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: <a href="mailto:cuis-dev@lists.cuis.st">Juan Vuletich via Cuis-dev</a> Sent: Monday, January 24, 2022 18:15 To: <a href="mailto:cuis-dev@lists.cuis.st">Discussion of Cuis Smalltalk</a> Cc: <a href="mailto:JuanVuletich@zoho.com">Juan Vuletich</a>; <a href="mailto:ten@smallinteger.com"> Andres Valloud</a>; <a href="mailto:mail@jaromir.net">Jaromir Matas</a>; <a href="mailto:hernan.wilkinson@10pines.com"> Hernan Wilkinson</a> Subject: Re: [Cuis-dev] Improved version of #terminate </div> <o:p> </o:p> On 1/18/2022 4:07 PM, Jaromir Matas via Cuis-dev wrote: <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> Hi Juan, all,<o:p></o:p> <o:p></o:p> I'm enclosing a new version of #terminate; I thought you might be interested to take a look and indeed, I'd be very much interested in your opinion. The termination functionality and semantics remains intact but the code is simplified and addresses Eliot's concerns regarding active process termination being done via another process. The enclosed code executes both active and suspended process�s termination directly by the process being terminated thus maintaining the invariant that the unwind blocks are executed by the same process that created them (this is the only real disadvantage of the current terminate; it�s not process faithful). The technique used is to create a parallel stack for the process being terminated and run the unwinds conveniently from there :) (thorough comments included). <o:p> </o:p> <o:p></o:p> I'm also enclosing some updated tests to reflect the new approach to the active process termination. If you were interested, I'd be happy to also provide updated examples and add some more tests later.<o:p></o:p> <o:p></o:p> Best regards,<o:p></o:p> <o:p></o:p> Jaromir<o:p></o:p> <o:p></o:p> </blockquote> Hello Jaromir, Folks, I took a look at the code, and it looks correct to me, although I don't understand this well enough to be sure. All the tests you wrote last year pass, and that is great. I think we'd integrate this. Still, I think it could be good to keep the current #terminate as a separate method, maybe #terminateFromForkedProcess, just in case it proves useful in the future. I'd be very thankful if others could take a look, and better yet, try it and see if it brings any trouble. Thanks! <o:p></o:p> <pre>-- </pre> <pre>Juan Vuletich</pre> <pre><a href="http://www.cuis-smalltalk.org">www.cuis-smalltalk.org</a></pre> <pre><a href="https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev">https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev</a></pre> <pre><a href="https://github.com/jvuletich">https://github.com/jvuletich</a></pre> <pre><a href="https://www.linkedin.com/in/juan-vuletich-75611b3">https://www.linkedin.com/in/juan-vuletich-75611b3</a></pre> <pre><a href="https://independent.academia.edu/JuanVuletich">https://independent.academia.edu/JuanVuletich</a></pre> <pre><a href="https://www.researchgate.net/profile/Juan-Vuletich">https://www.researchgate.net/profile/Juan-Vuletich</a></pre> <pre><a href="https://patents.justia.com/inventor/juan-manuel-vuletich">https://patents.justia.com/inventor/juan-manuel-vuletich</a></pre> <pre>@JuanVuletich</pre> <o:p> </o:p> </div> </body> </html>