<div dir="ltr">Sorry, the change set in last message included two instance variables in HierarchicalListMorph I didn't intend to include (originally from Gerald's code, that later I changed to be consistent with PluggableListMorph). You can remove them manually, or use this change set instead.<div>BTW, I'm not sure if this is a bug, but I'm seeing multiple copies of a class definition in file outs of changesets. For example, look at the changeset for the recent core update 5232.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Jun 12, 2022 at 2:16 PM Luciano Notarfrancesco <<a href="mailto:luchiano@gmail.com">luchiano@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">I implemented DND in HierarchicalListMorph following the implementation in PluggableListMorph in order to be more consistent. I also fixed a bug in DND of the PlugglableListMorph (when the dropActionSelector had only 1 argument, it received the target item instead of the dropped item), and simplified it a little bit. And I also added back DND of classes into system categories in the Browser.<div>There's still one little problem: during DND into a HierarchicalListMorph the target item is not highlighted. I'll look into that soon. Other than that, everything seems to work fine, but please review and let me know of any problems.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Jun 12, 2022 at 7:14 AM Luciano Notarfrancesco <<a href="mailto:luchiano@gmail.com" target="_blank">luchiano@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><span style="border-color:rgb(0,0,0);color:rgb(0,0,0)">Juan, if you didn’t have time yet I’ll take a look today and see if I can also add back dnd to the system categories list.</span><br></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, 12 Jun 2022 at 12:48 AM Gerald Klix <<a href="mailto:cuis.01@klix.ch" target="_blank">cuis.01@klix.ch</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Juan,<br> <br> please review the attached package,<br> it contains sub-classes of all the hierarchical<br> list morph classes. These morph class<br> support drag and drop.<br> <br> I tested the classes by using<br> them in Haver's module tools.<br> They still work!<br> <br> <br> HTH and Best Regards,<br> <br> Gerald<br> <br> <br> <br> <br> On 6/7/22 20:20, Juan Vuletich wrote:<br> > Please do! That would be helpful.<br> > <br> > I'd love to review that code to integrate it in the base image.<br> > <br> > Thanks,<br> > <br> > On 5/27/2022 1:06 PM, Gerald Klix via Cuis-dev wrote:<br> >> Should I port the aforementioned Haver package to Cuis, meaning remove <br> >> the module stuff?<br> >> That would cost me two hours including testing. That one contains an <br> >> IndentingListItemMorph<br> >> with drag and drop support.<br> >><br> >> Juan, what do you think?<br> >><br> >><br> >> Best Regards,<br> >><br> >> Gerald<br> >><br> >> On May 27 2022, at 5:30 pm, Luciano Notarfrancesco <br> >> <<a href="mailto:luchiano@gmail.com" target="_blank">luchiano@gmail.com</a>> wrote:<br> >><br> >> Yes, that’s the reason, we should add drag&drop to hierarchical <br> >> lists…<br> >><br> >> On Fri, 27 May 2022 at 10:01 PM Gerald Klix via Cuis-dev<br> >> <<a href="mailto:cuis-dev@lists.cuis.st" target="_blank">cuis-dev@lists.cuis.st</a> <mailto:<a href="mailto:cuis-dev@lists.cuis.st" target="_blank">cuis-dev@lists.cuis.st</a>>> wrote:<br> >><br> >> I messed around with the IndentingListItemMorph class quite a<br> >> lot, therefore I can answer that one from the top of my had.<br> >> The builtin IndentingListItemMorph used for the category list<br> >> has no (working) support for drag and drop.<br> >><br> >> See:<br> >> <br> >> <a href="https://hg.sr.ht/~cy-de-fect/HaverOnCuis/browse/haver/ui/DNDIndentingListItemMorph.pck.st" rel="noreferrer" target="_blank">https://hg.sr.ht/~cy-de-fect/HaverOnCuis/browse/haver/ui/DNDIndentingListItemMorph.pck.st</a> <br> >><br> >> <br> >> <<a href="https://hg.sr.ht/%7Ecy-de-fect/HaverOnCuis/browse/haver/ui/DNDIndentingListItemMorph.pck.st" rel="noreferrer" target="_blank">https://hg.sr.ht/%7Ecy-de-fect/HaverOnCuis/browse/haver/ui/DNDIndentingListItemMorph.pck.st</a>> <br> >><br> >><br> >><br> >> HTH and Best Regards,<br> >><br> >> Gerald<br> >><br> >> On May 27 2022, at 4:55 pm, Hernan Wilkinson via Cuis-dev<br> >> <<a href="mailto:cuis-dev@lists.cuis.st" target="_blank">cuis-dev@lists.cuis.st</a> <mailto:<a href="mailto:cuis-dev@lists.cuis.st" target="_blank">cuis-dev@lists.cuis.st</a>>> wrote:<br> >><br> >> Hi Luciano,<br> >> Before the change you made to make the system category<br> >> look like a tree (nice!), we could drag a class and drop<br> >> it into a system category to categorized the class into<br> >> the dropped category. That does not work anymore.<br> >> I have the feeling that you mentioned why, but I do not<br> >> recall.<br> >> Is there a reason for this? is it too difficult to make<br> >> it work again?<br> >><br> >> Thanks!<br> >> Hernan.<br> >> --<br> >> Cuis-dev mailing list<br> >> <a href="mailto:Cuis-dev@lists.cuis.st" target="_blank">Cuis-dev@lists.cuis.st</a> <mailto:<a href="mailto:Cuis-dev@lists.cuis.st" target="_blank">Cuis-dev@lists.cuis.st</a>><br> >> <a href="https://lists.cuis.st/mailman/listinfo/cuis-dev" rel="noreferrer" target="_blank">https://lists.cuis.st/mailman/listinfo/cuis-dev</a><br> >><br> >> --<br> >> Cuis-dev mailing list<br> >> <a href="mailto:Cuis-dev@lists.cuis.st" target="_blank">Cuis-dev@lists.cuis.st</a> <mailto:<a href="mailto:Cuis-dev@lists.cuis.st" target="_blank">Cuis-dev@lists.cuis.st</a>><br> >> <a href="https://lists.cuis.st/mailman/listinfo/cuis-dev" rel="noreferrer" target="_blank">https://lists.cuis.st/mailman/listinfo/cuis-dev</a><br> >><br> > <br> > <br> </blockquote></div></div> </blockquote></div> </blockquote></div>