<div dir="auto">Sure, anytime is ok. Let me know if this implementation works for you or if you have any requirements not covered by this implementation so we can think further how to improve it.</div><div dir="auto"><br></div><div dir="auto">On Mon, 13 Jun 2022 at 3:14 PM Gerald Klix <<a href="mailto:cuis.01@klix.ch">cuis.01@klix.ch</a>> wrote:<br></div><div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)"><div>Hi Luciano,</div><br><div>Thanks for your work.</div><div>I only spent 3 minutes using Emacs to browse over the code.</div><div>I only found some small things to nitpick at the method-level.</div><br><div>I fast do you need more detailed feedback?</div><div>Is Wendsday evening (GMT) early enough?</div><br><br><div>Best Regards,</div><br><div>Gerald</div><br><div>On Jun 12 2022, at 6:18 pm, Luciano Notarfrancesco <<a href="mailto:luchiano@gmail.com" target="_blank">luchiano@gmail.com</a>> wrote:</div><blockquote><div><div>Sorry, the change set in last message included two instance variables in HierarchicalListMorph I didn't intend to include (originally from Gerald's code, that later I changed to be consistent with PluggableListMorph). You can remove them manually, or use this change set instead.</div><div>BTW, I'm not sure if this is a bug, but I'm seeing multiple copies of a class definition in file outs of changesets. For example, look at the changeset for the recent core update 5232.</div></div><br><div class="gmail_quote"><div class="gmail_attr"><div>On Sun, Jun 12, 2022 at 2:16 PM Luciano Notarfrancesco <<a href="mailto:luchiano@gmail.com" title="mailto:luchiano@gmail.com" target="_blank">luchiano@gmail.com</a>> wrote:</div></div><blockquote><div><div>I implemented DND in HierarchicalListMorph following the implementation in PluggableListMorph in order to be more consistent. I also fixed a bug in DND of the PlugglableListMorph (when the dropActionSelector had only 1 argument, it received the target item instead of the dropped item), and simplified it a little bit. And I also added back DND of classes into system categories in the Browser.</div><div>There's still one little problem: during DND into a HierarchicalListMorph the target item is not highlighted. I'll look into that soon. Other than that, everything seems to work fine, but please review and let me know of any problems.</div></div><br><div class="gmail_quote"><div class="gmail_attr"><div>On Sun, Jun 12, 2022 at 7:14 AM Luciano Notarfrancesco <<a href="mailto:luchiano@gmail.com" title="mailto:luchiano@gmail.com" target="_blank">luchiano@gmail.com</a>> wrote:</div></div><blockquote><div><div>Juan, if you didn’t have time yet I’ll take a look today and see if I can also add back dnd to the system categories list.</div></div><div><br><div class="gmail_quote"><div class="gmail_attr"><div>On Sun, 12 Jun 2022 at 12:48 AM Gerald Klix <<a href="mailto:cuis.01@klix.ch" title="mailto:cuis.01@klix.ch" target="_blank">cuis.01@klix.ch</a>> wrote:</div></div><blockquote><div>Hi Juan,</div><br><div>please review the attached package,</div><div>it contains sub-classes of all the hierarchical</div><div>list morph classes. These morph class</div><div>support drag and drop.</div><br><div>I tested the classes by using</div><div>them in Haver's module tools.</div><div>They still work!</div><br><br><div>HTH and Best Regards,</div><br><div>Gerald</div><br><br><br><br><div>On 6/7/22 20:20, Juan Vuletich wrote:</div><div>> Please do! That would be helpful.</div><div>> </div><div>> I'd love to review that code to integrate it in the base image.</div><div>> </div><div>> Thanks,</div><div>> </div><div>> On 5/27/2022 1:06 PM, Gerald Klix via Cuis-dev wrote:</div><div>>> Should I port the aforementioned Haver package to Cuis, meaning remove </div><div>>> the module stuff?</div><div>>> That would cost me two hours including testing. That one contains an </div><div>>> IndentingListItemMorph</div><div>>> with drag and drop support.</div><div>>></div><div>>> Juan, what do you think?</div><div>>></div><div>>></div><div>>> Best Regards,</div><div>>></div><div>>> Gerald</div><div>>></div><div>>> On May 27 2022, at 5:30 pm, Luciano Notarfrancesco </div><div>>> <<a href="mailto:luchiano@gmail.com" title="mailto:luchiano@gmail.com" target="_blank">luchiano@gmail.com</a>> wrote:</div><div>>></div><div>>> Yes, that’s the reason, we should add drag&drop to hierarchical </div><div>>> lists…</div><div>>></div><div>>> On Fri, 27 May 2022 at 10:01 PM Gerald Klix via Cuis-dev</div><div>>> <<a href="mailto:cuis-dev@lists.cuis.st" title="mailto:cuis-dev@lists.cuis.st" target="_blank">cuis-dev@lists.cuis.st</a> <mailto:<a href="mailto:cuis-dev@lists.cuis.st" title="mailto:cuis-dev@lists.cuis.st" target="_blank">cuis-dev@lists.cuis.st</a>>> wrote:</div><div>>></div><div>>> I messed around with the IndentingListItemMorph class quite a</div><div>>> lot, therefore I can answer that one from the top of my had.</div><div>>> The builtin IndentingListItemMorph used for the category list</div><div>>> has no (working) support for drag and drop.</div><div>>></div><div>>> See:</div><div>>> </div><div>>> <a href="https://hg.sr.ht/~cy-de-fect/HaverOnCuis/browse/haver/ui/DNDIndentingListItemMorph.pck.st" title="https://hg.sr.ht/~cy-de-fect/HaverOnCuis/browse/haver/ui/DNDIndentingListItemMorph.pck.st" target="_blank">https://hg.sr.ht/~cy-de-fect/HaverOnCuis/browse/haver/ui/DNDIndentingListItemMorph.pck.st</a> </div><div>>></div><div>>> </div><div>>> <<a href="https://hg.sr.ht/%7Ecy-de-fect/HaverOnCuis/browse/haver/ui/DNDIndentingListItemMorph.pck.st" title="https://hg.sr.ht/%7Ecy-de-fect/HaverOnCuis/browse/haver/ui/DNDIndentingListItemMorph.pck.st" target="_blank">https://hg.sr.ht/%7Ecy-de-fect/HaverOnCuis/browse/haver/ui/DNDIndentingListItemMorph.pck.st</a>> </div><div>>></div><div>>></div><div>>></div><div>>> HTH and Best Regards,</div><div>>></div><div>>> Gerald</div><div>>></div><div>>> On May 27 2022, at 4:55 pm, Hernan Wilkinson via Cuis-dev</div><div>>> <<a href="mailto:cuis-dev@lists.cuis.st" title="mailto:cuis-dev@lists.cuis.st" target="_blank">cuis-dev@lists.cuis.st</a> <mailto:<a href="mailto:cuis-dev@lists.cuis.st" title="mailto:cuis-dev@lists.cuis.st" target="_blank">cuis-dev@lists.cuis.st</a>>> wrote:</div><div>>></div><div>>> Hi Luciano,</div><div>>> Before the change you made to make the system category</div><div>>> look like a tree (nice!), we could drag a class and drop</div><div>>> it into a system category to categorized the class into</div><div>>> the dropped category. That does not work anymore.</div><div>>> I have the feeling that you mentioned why, but I do not</div><div>>> recall.</div><div>>> Is there a reason for this? is it too difficult to make</div><div>>> it work again?</div><div>>></div><div>>> Thanks!</div><div>>> Hernan.</div><div>>> --</div><div>>> Cuis-dev mailing list</div><div>>> <a href="mailto:Cuis-dev@lists.cuis.st" title="mailto:Cuis-dev@lists.cuis.st" target="_blank">Cuis-dev@lists.cuis.st</a> <mailto:<a href="mailto:Cuis-dev@lists.cuis.st" title="mailto:Cuis-dev@lists.cuis.st" target="_blank">Cuis-dev@lists.cuis.st</a>></div><div>>> <a href="https://lists.cuis.st/mailman/listinfo/cuis-dev" title="https://lists.cuis.st/mailman/listinfo/cuis-dev" target="_blank">https://lists.cuis.st/mailman/listinfo/cuis-dev</a></div><div>>></div><div>>> --</div><div>>> Cuis-dev mailing list</div><div>>> <a href="mailto:Cuis-dev@lists.cuis.st" title="mailto:Cuis-dev@lists.cuis.st" target="_blank">Cuis-dev@lists.cuis.st</a> <mailto:<a href="mailto:Cuis-dev@lists.cuis.st" title="mailto:Cuis-dev@lists.cuis.st" target="_blank">Cuis-dev@lists.cuis.st</a>></div><div>>> <a href="https://lists.cuis.st/mailman/listinfo/cuis-dev" title="https://lists.cuis.st/mailman/listinfo/cuis-dev" target="_blank">https://lists.cuis.st/mailman/listinfo/cuis-dev</a></div><div>>></div><div>> </div><div>> </div></blockquote></div></div></blockquote></div></blockquote></div></blockquote></blockquote></div></div>