<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html; charset=UTF-8" http-equiv="Content-Type"> </head> <body bgcolor="#ffffff" text="#000000"> Hi Hilaire, On 7/9/2022 6:00 AM, Hilaire Fernandes via Cuis-dev wrote: <blockquote cite="mid:707791d3-2868-9d04-e8ad-e09664461a8a@drgeo.eu" type="cite"> <meta http-equiv="content-type" content="text/html; charset=UTF-8"> Hi Juan, Since your update 5355 the accept: visitor is gone from the Preference class. Although not used in the core image, it is needed to visit Preference in third party application. I copy and paste it below so you merge it back: Preference>>accept: aVisitor | visitMethod | self isTypeAClass ifTrue: [ visitMethod _ ('visit', type name, 'Preference:') asSymbol ] ifFalse: [visitMethod _ ('visit', type species asString, 'Preference:') asSymbol ]. ^ aVisitor perform: visitMethod with: self </blockquote> Added it back. Apologies. <blockquote cite="mid:707791d3-2868-9d04-e8ad-e09664461a8a@drgeo.eu" type="cite"> Also I noted your edit of the type method: Preference>>type (type inheritsFrom: CharacterSequence) ifTrue: [ type _ CharacterSequence ]. ^ type It breaks the Preference behavior in DrGeo with my dedicated type objects (DrGTypeArrow, DrGTypePointShape, etc.), all subclasses of an Object. Indeed #inheritsFrom: is defined in Behavior not in Object. </blockquote> I see. I pushed an update that does essentially the same, but should not break your code. <blockquote cite="mid:707791d3-2868-9d04-e8ad-e09664461a8a@drgeo.eu" type="cite"> I am wondering if it is needed because we all detect type? </blockquote> People may set type String explicitly. Besides, many existing preferences have type String. That's why I also modified #type. <blockquote cite="mid:707791d3-2868-9d04-e8ad-e09664461a8a@drgeo.eu" type="cite"> Preference>>detectType: anObject "When the type is not provided, we can try to deduce it " (anObject isKindOf: CharacterSequence) ifTrue: [ ^CharacterSequence ]. ^ anObject class name caseOf: { [#True] -> [Boolean]. [#False] -> [Boolean]. [#StrikeFont] -> [AbstractFont]. [#TrueTypeFont ] -> [AbstractFont] } otherwise: [anObject class] I understand these changes are related to your utf-8 work in progress. </blockquote> Yes. Now, and Utf8String may appear anywhere a String was expected. They are fully polymorphic and this should not create any problems. But then, in all places (in _almost_ all places) where type checking or conversions is done, an Utf8String must be accepted. BTW, the Utf8 stuff is mostly done. Only sorting (collation) needs a bit more work. <blockquote cite="mid:707791d3-2868-9d04-e8ad-e09664461a8a@drgeo.eu" type="cite"> Best Hilaire </blockquote> Thanks, <pre class="moz-signature" cols="72">-- Juan Vuletich <a class="moz-txt-link-abbreviated" href="http://www.cuis-smalltalk.org">www.cuis-smalltalk.org</a> <a class="moz-txt-link-freetext" href="https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev">https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev</a> <a class="moz-txt-link-freetext" href="https://github.com/jvuletich">https://github.com/jvuletich</a> <a class="moz-txt-link-freetext" href="https://www.linkedin.com/in/juan-vuletich-75611b3">https://www.linkedin.com/in/juan-vuletich-75611b3</a> <a class="moz-txt-link-freetext" href="https://independent.academia.edu/JuanVuletich">https://independent.academia.edu/JuanVuletich</a> <a class="moz-txt-link-freetext" href="https://www.researchgate.net/profile/Juan-Vuletich">https://www.researchgate.net/profile/Juan-Vuletich</a> <a class="moz-txt-link-freetext" href="https://patents.justia.com/inventor/juan-manuel-vuletich">https://patents.justia.com/inventor/juan-manuel-vuletich</a> <a class="moz-txt-link-freetext" href="https://twitter.com/JuanVuletich">https://twitter.com/JuanVuletich</a></pre> </body> </html>