<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix"><img style="width: 3ex; height: 3ex;
min-width: 20px; min-height: 20px; display: inline-block;
margin: 0 .15em .2ex; line-height: normal; vertical-align:
middle" class="joypixels" alt="👍"
src="https://cdn.jsdelivr.net/gh/joypixels/emoji-assets@v7.0.0/png/64/1f44d.png"
width="20" height="20" align="middle"></div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">Now SqueakCompatibility needs a fix
too.<img style="width: 3ex; height: 3ex; min-width: 20px;
min-height: 20px; display: inline-block; margin: 0 .15em .2ex;
line-height: normal; vertical-align: middle" class="joypixels"
alt="😯"
src="https://cdn.jsdelivr.net/gh/joypixels/emoji-assets@v7.0.0/png/64/1f62f.png"
width="20" height="20" align="middle"> It tries to extend
StandardFileStream, which is not available anymore.</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">I don't know how to fix it myself
because I don't know about that class and why it was removed.</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix"> Mariano</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">El 31/10/22 a las 12:25, Juan Vuletich
escribió:<br>
</div>
<blockquote type="cite" cite="mid:635FE8DA.80208@cuis.st">Hi
Mariano,
<br>
<br>
Nah. Just updated the packages and fixes them.
<br>
<br>
If client code still thinks it is ok to do `aString compress` or
`aString decompress`, they will still get walkbacks. What is
compressed is bytes, not Strings. So, if further problems arise,
let's discuss and solve them.
<br>
<br>
Cheers,
<br>
<br>
On 10/30/2022 10:43 AM, Mariano Montone via Cuis-dev wrote:
<br>
<blockquote type="cite">Hi,
<br>
<br>
I would apply your "bad" solution, as lots of packages depend on
Compression right now and can't be used in the new image.
<br>
<br>
Perhaps then create an issue in Cuis issue tracker with the task
of improving/making right Compression for later.
<br>
<br>
Mariano
<br>
<br>
El 29/10/22 a las 21:21, Juan Vuletich escribió:
<br>
<blockquote type="cite">Hi Folks,
<br>
<br>
I could load it and make the tests pass. For that:
<br>
- I edited the package file and changed references to
StandardFileStream and FileStream to UniFileStream. Trivial.
<br>
- added #byteAt: and #byteAt:put: to String. This doesn't look
like a good idea.
<br>
- added #asByteString to the 'Hello World' literal in the
test. Neither this looks right.
<br>
<br>
But this is most likely not a good solution.
<br>
<br>
It seems that Compression is making the assumption that
Strings are made of Byte characters. I don't know the
compression algorithms in detail, or what is the standard way
to deal with UTF-8 content in compression. Most likely it is
byte by byte, right? If so, Compression should be adapted to
work on ByteArrays only, and claim no knowledge of how Strings
are encoded.
<br>
<br>
If any of you can take a deeper look into this, it would be a
great service to the community.
<br>
<br>
Thanks,
<br>
<br>
On 10/29/2022 10:17 AM, Gerald Klix via Cuis-dev wrote:
<br>
<blockquote type="cite">Thanks for testing, that saved me a
lot of work.
<br>
Cuis without the Compression package is rather useless to
me.
<br>
<br>
<br>
Best Regards,
<br>
<br>
Gerald
<br>
<br>
<br>
<br>
On 29.10.22 13:29, Mariano Montone via Cuis-dev wrote:
<br>
<blockquote type="cite">Hi,
<br>
<br>
Compression and SqueakCompatibility packages fail to load
in latest image because FileStream and StandardFileStream
classes are not available anymore, and they want to add
extensions to those classes.
<br>
<br>
Have a fix?
<br>
<br>
Thanks,
<br>
<br>
Mariano
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
<br>
</blockquote>
<p><br>
</p>
</body>
</html>