<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
On 11/1/2022 11:23 PM, Hernán Wilkinson via Cuis-dev wrote:
<blockquote
cite="mid:CAGgF3Gx_Kq4L4R+KjwsxBTgw0+_0j7nCA8iJQ8E7wWTpfENeyQ@mail.gmail.com"
type="cite">
<div dir="ltr">yeap, the current implementation is not correct.
<div>Juan, attached is a change set that fixes it and another
with the related tests.</div>
<div><br>
</div>
<div>Cheers!</div>
<div>Hernan.</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, Nov 1, 2022 at 3:39 AM
Luciano Notarfrancesco <<a moz-do-not-send="true"
href="mailto:luchiano@gmail.com">luchiano@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
<div dir="auto">I’m afk right now so I cannot check, but it
sounds like I made a mistake. Of course it should be the
value of aBlock at each element times the number of
occurrences.</div>
<div><br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, 1 Nov 2022 at
07:33 Hernán Wilkinson <<a moz-do-not-send="true"
href="mailto:hernan.wilkinson@10pines.com"
target="_blank">hernan.wilkinson@10pines.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
<div dir="ltr">Hi,
<div> the implementation of Bag>>#sum: aBlock
ifEmpty: emptyBlock does not use the parameter
aBlock at all and assumes that each of the elements
answers the message * </div>
<div> <a moz-do-not-send="true"
class="gmail_plusreply"
id="m_-3423588523307269653m_4335152602574426633plusReplyChip-0"
href="mailto:luchiano@gmail.com" target="_blank">@Luciano
Notarfrancesco</a> the implementation is yours and
it is very new? Is there a reason you did that way? </div>
<div><br>
</div>
<div>Thanks</div>
<div>Hernan</div>
</div>
<div dir="ltr">
<div><br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr">
<div dir="ltr">
<div>
<div dir="ltr">
<div style="font-size: small;">
<div dir="ltr">
<div dir="ltr">
<div style="font-size: 12.8px;"><span
style="font-family:
tahoma,sans-serif; font-size:
xx-small; border-collapse:
collapse;"><strong
style="font-family:
tahoma,sans-serif;"><span
style="font-size: 8pt;
font-family:
tahoma,sans-serif;"><span
style="font-size: small;
font-family:
tahoma,sans-serif;"><font
style="font-family:
tahoma,sans-serif; color:
rgb(0, 0, 0);" size="2"><span
style="font-weight:
normal; font-family:
tahoma,sans-serif;"><span
style="font-weight:
bold; font-family:
tahoma,sans-serif;">Hernán
Wilkinson</span><br>
Agile Software
Development, Teaching
& Coaching</span></font></span></span></strong></span></div>
<div style="font-size: 12.8px;"><span
style="font-family:
tahoma,sans-serif; font-size:
xx-small; border-collapse:
collapse;"><strong
style="font-family:
tahoma,sans-serif;"><span
style="font-size: 8pt;
font-family:
tahoma,sans-serif;"><span
style="font-size: small;
font-family:
tahoma,sans-serif;"><font
style="font-family:
tahoma,sans-serif; color:
rgb(0, 0, 0);" size="2"><span
style="font-weight:
normal; font-family:
tahoma,sans-serif;">Phone:
+54-011</span></font></span></span></strong></span><font
style="font-family:
tahoma,sans-serif; color: rgb(0,
0, 0);" size="2" face="tahoma,
sans-serif">-4893-2057</font></div>
<div style="font-size: 12.8px;"><strong
style="font-family:
tahoma,sans-serif; font-size:
xx-small;"><span style="font-size:
8pt; font-family:
tahoma,sans-serif;"><span
style="font-size: small;
font-family:
tahoma,sans-serif;"><font
style="font-family:
tahoma,sans-serif; color:
rgb(0, 0, 0);" size="2"><span
style="font-weight:
normal; font-family:
tahoma,sans-serif;">Twitter:
@HernanWilkinson</span></font></span></span></strong></div>
<div style="font-size: 12.8px;"><span
style="font-family:
tahoma,sans-serif; font-size:
xx-small; border-collapse:
collapse;"><strong
style="font-family:
tahoma,sans-serif;"><span
style="font-size: 8pt;
font-family:
tahoma,sans-serif;"><span
style="font-size: small;
font-family:
tahoma,sans-serif;"><font
style="font-family:
tahoma,sans-serif; color:
rgb(0, 0, 0);" size="2"><span
style="font-weight:
normal; font-family:
tahoma,sans-serif;">site: <a
moz-do-not-send="true"
href="http://www.10pines.com/" style="font-family: tahoma,sans-serif;
color: rgb(17, 65,
112);" target="_blank">http://www.10Pines.com</a></span></font></span></span></strong></span></div>
<div style="font-size: 12.8px;"><font
style="font-family:
tahoma,sans-serif; color: rgb(0,
0, 0);" face="tahoma, sans-serif"><span
style="border-collapse:
collapse; font-family:
tahoma,sans-serif;">Address:
Alem 896</span></font>, Floor 6,
Buenos Aires, Argentina</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</blockquote>
</div>
<br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr" class="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div style="font-size: small;">
<div dir="ltr">
<div dir="ltr">
<div style="font-size: 12.8px;"><span
style="font-family: tahoma,sans-serif;
font-size: xx-small; border-collapse: collapse;"><strong><span
style="font-size: 8pt;"><span
style="font-size: small;"><font size="2"><span
style="font-weight: normal;"><span
style="font-weight: bold;">Hernán
Wilkinson</span><br>
Agile Software Development, Teaching
& Coaching</span></font></span></span></strong></span></div>
<div style="font-size: 12.8px;"><span
style="font-family: tahoma,sans-serif;
font-size: xx-small; border-collapse: collapse;"><strong><span
style="font-size: 8pt;"><span
style="font-size: small;"><font size="2"><span
style="font-weight: normal;">Phone:
+54-011</span></font></span></span></strong></span><font
size="2" face="tahoma, sans-serif">-4893-2057</font></div>
<div style="font-size: 12.8px;"><strong
style="font-family: tahoma,sans-serif;
font-size: xx-small;"><span style="font-size:
8pt;"><span style="font-size: small;"><font
size="2"><span style="font-weight:
normal;">Twitter: @HernanWilkinson</span></font></span></span></strong></div>
<div style="font-size: 12.8px;"><span
style="font-family: tahoma,sans-serif;
font-size: xx-small; border-collapse: collapse;"><strong><span
style="font-size: 8pt;"><span
style="font-size: small;"><font size="2"><span
style="font-weight: normal;">site: <a
moz-do-not-send="true"
href="http://www.10pines.com/"
style="color: rgb(17, 65, 112);"
target="_blank">http://www.10Pines.com</a></span></font></span></span></strong></span></div>
<div style="font-size: 12.8px;"><font face="tahoma,
sans-serif"><span style="border-collapse:
collapse;">Address: Alem 896</span></font>,
Floor 6, Buenos Aires, Argentina</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<br>
Hi Hernán,<br>
<br>
Your fix disables the optimization Luciano did. I chose to fix
Luciano's code. Did the same for #product: (same bug). Integrated
your tests, and added another one for #product:<br>
<br>
Thanks,<br>
<pre class="moz-signature" cols="72">--
Juan Vuletich
cuis.st
github.com/jvuletich
researchgate.net/profile/Juan-Vuletich
independent.academia.edu/JuanVuletich
patents.justia.com/inventor/juan-manuel-vuletich
linkedin.com/in/juan-vuletich-75611b3
twitter.com/JuanVuletich</pre>
</body>
</html>