<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=Windows-1252"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="#954F72" style="word-wrap:break-word"> <div class="WordSection1"> Hi Juan, <o:p> </o:p> > Not sure why you removed the `push: nil` in #unwindAndStop: <o:p> </o:p> I haven't; #unwindAndStop: was not part of the latest changeset, the previous version probably sneaked back in somehow :) The correct version is included in the attached changeset. <o:p> </o:p> The attached is mostly polishing up, but also a few small bugfixes: <o:p> </o:p> #contextOn:do: ... the same bug as in #contextEnsure: #unwindTo:safely: ... a missing nil check (dealing with: [] ensure: nil); a corresponding test included #runUntilErrorOrReturnFrom: ... a missing nil check (discovered in a Squeak example but relevant for Cuis too) <o:p> </o:p> Maybe we could remove the methods associated with my initial #terminate attempt you renamed to #terminateFromForkedProcess. But it's up to you if you want to keep them for a little longer. It'd be: #terminateFromForkedProcess #complete:to: #runUnwindUntilErrorOrReturnFrom: <o:p> </o:p> This would be the final update in the "termination department" :) <o:p> </o:p> Many thanks for your always inspiring comment and suggestions! <o:p> </o:p> Best, Jaromir <o:p> </o:p> -- Jaromír Matas<o:p></o:p> mail@jaromir.net<o:p></o:p> <o:p> </o:p> <o:p> </o:p> <div style="mso-element:para-border-div;border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: <a href="mailto:juan@cuis.st">Juan Vuletich</a> Sent: Friday, February 24, 2023 11:49 To: <a href="mailto:cuis-dev@lists.cuis.st">Discussion of Cuis Smalltalk</a> Cc: <a href="mailto:mail@jaromir.net">Jaromir Matas</a> Subject: Re: [Cuis-dev] Follow-up: #terminate and #suspend update </div> <o:p> </o:p> Hi Jaromir, Thank you for your continued help with this tricky area of the system! I've just integrated your changes. Just a couple of comments: - Any update to comments is of course welcome. Thanks! - Not sure why you removed the `push: nil` in #unwindAndStop:, but I trust you know what you are doing here. Cheers, On 2/7/2023 5:49 PM, Jaromir Matas via Cuis-dev wrote: <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> Hi Juan,<o:p></o:p> <o:p></o:p> I’m enclosing a version (002) further improving the previous changeset (001), for your review/merge with the following changes:<o:p></o:p> <o:p></o:p> 1) placed "suspendedContext _ nil" assignment as close to the #suspend message as possible<o:p></o:p> <o:p></o:p> 2) improved readability (I hope) <o:p> </o:p> <o:p></o:p> If you’re ok with it I’ll refine outdated comments. It passes all Process and Exception tests in both Cuis and Squeak.<o:p></o:p> <o:p></o:p> Thanks for your time and any comments.<o:p></o:p> <o:p></o:p> Best,<o:p></o:p> <o:p></o:p> --<o:p></o:p> Jaromír Matas<o:p></o:p> <a href="mailto:mail@jaromir.net">mail@jaromir.net</a><o:p></o:p> <o:p></o:p> <o:p></o:p> <div style="border:none;border-top:solid windowtext 1.0pt;padding:3.0pt 0in 0in 0in;border-color:rgb(225, 225, 225) -moz-use-text-color -moz-use-text-color"> From: <a href="mailto:juan@cuis.st">Juan Vuletich</a> Sent: Monday, January 30, 2023 20:57 To: <a href="mailto:cuis-dev@lists.cuis.st">Discussion of Cuis Smalltalk</a> Cc: <a href="mailto:mail@jaromir.net">Jaromir Matas</a> Subject: Re: [Cuis-dev] Follow-up: #terminate and #suspend update<o:p></o:p> </div> <o:p></o:p> Hi Jaromir, Thank you very much for this. Unfortunately, I'll be out of town for a few days, and I think it could be a bit risky if I push these changes, and then I'm not available to help address any issues that could occur. I promise I'll review and integrate your contributions as usual, when back in town. Thanks for your patience. Cheers, On 1/30/2023 10:20 AM, Jaromir Matas via Cuis-dev wrote: <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> Hi Juan,<o:p></o:p> <o:p></o:p> I’m enclosing a modified #terminate that would fix the two failing tests, plus some more Semaphore tests further exploring the semantics during unwinds, and a fix of a small bug in #unwindAndStop:. All tested and green even in in Squeak :)<o:p></o:p> <o:p></o:p> Best,<o:p></o:p> Jaromir<o:p></o:p> <o:p></o:p> --<o:p></o:p> Jaromír Matas<o:p></o:p> <a href="mailto:mail@jaromir.net">mail@jaromir.net</a><o:p></o:p> <o:p></o:p> <o:p></o:p> <div style="border:none;border-top:solid windowtext 1.0pt;padding:3.0pt 0in 0in 0in;border-color:-moz-use-text-color -moz-use-text-color"> From: <a href="mailto:juan@cuis.st">Juan Vuletich</a> Sent: Tuesday, January 24, 2023 19:49 To: <a href="mailto:cuis-dev@lists.cuis.st">Discussion of Cuis Smalltalk</a> Cc: <a href="mailto:mail@jaromir.net">Jaromir Matas</a> Subject: Re: [Cuis-dev] Follow-up: #terminate and #suspend update<o:p></o:p> </div> <o:p></o:p> Hi Jaromir, Just pushed these to github, together with #expectedFailures. Thanks! On 1/23/2023 4:30 PM, Jaromir Matas via Cuis-dev wrote: <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> Hi Juan,<o:p></o:p> <o:p></o:p> Thanks again. I’m enclosing the two tests I’d like to store for future reference.<o:p></o:p> <o:p></o:p> They both illustrate system’s behavior when you attempt to resume or terminate a process that is being terminated and the termination procedure is in a vulnerable early stage: specifically when the terminating suspended context/stack is being prepared, before running the “proper” unwind. In this particular situation the termination may derail. The probability of such an event is reasonably low but why not fix it. A possible solution is commented in the tests but before integrating it I want to test it thoroughly in Squeak/Pharo as well. The idea is to nil the suspended context during the preparation of the new stack to prevent accidental resumption/termination. Once the “proper” unwind starts it’s ok to terminate the terminating process again as demonstrated in # testTerminateTerminatingProcessAfterUnwindStarted<o:p></o:p> <o:p></o:p> Best,<o:p></o:p> Jaromir<o:p></o:p> --<o:p></o:p> Jaromír Matas<o:p></o:p> <a href="mailto:mail@jaromir.net">mail@jaromir.net</a><o:p></o:p> <o:p></o:p> <o:p></o:p> <div style="border:none;border-top:solid windowtext 1.0pt;padding:3.0pt 0in 0in 0in;border-color:-moz-use-text-color"> From: <a href="mailto:cuis-dev@lists.cuis.st">Juan Vuletich via Cuis-dev</a> Sent: Monday, January 23, 2023 15:25 To: <a href="mailto:cuis-dev@lists.cuis.st">Discussion of Cuis Smalltalk</a> Cc: <a href="mailto:juan@cuis.st">Juan Vuletich</a>; <a href="mailto:mail@jaromir.net"> Jaromir Matas</a> Subject: Re: [Cuis-dev] Follow-up: #terminate and #suspend update<o:p></o:p> </div> <o:p></o:p> Hi! On 1/22/2023 4:29 PM, Jaromir Matas via Cuis-dev wrote: <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> Hi again,<o:p></o:p> <o:p></o:p> Missed the list, sorry.<o:p></o:p> <o:p></o:p> As we agree to keep the current isTerminated semantics (also consistent with Squeak/Pharo) I’d suggest to use the test as the documentation of the observed behavior; I’ve added a link to the archive in the comment.<o:p></o:p> </blockquote> Just pushed it to github. <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <o:p></o:p> Question: is there a way to make a test an “expected failure” like in Squeak? In Squeak I create a method<o:p></o:p> <o:p></o:p> ProcessTest>>#expectedFailures<o:p></o:p> <o:p></o:p> ^ #(testTerminateTerminatingProcess testResumeTerminatingProcess)<o:p></o:p> <o:p></o:p> As a result the two listed tests show green in the test runner if they fail.<o:p></o:p> <o:p></o:p> If possible, I’d like to post two tests that currently fail as a reminder/documentation. <o:p></o:p> </blockquote> Plase post those tests. If nobody beats to me, I'll add expected failure functionality. <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> Thanks,<o:p></o:p> Jaromir<o:p></o:p> </blockquote> Thanks, <o:p></o:p> <pre>-- </pre> <pre>Juan Vuletich</pre> <pre>cuis.st</pre> <pre>github.com/jvuletich</pre> <pre>researchgate.net/profile/Juan-Vuletich</pre> <pre>independent.academia.edu/JuanVuletich</pre> <pre>patents.justia.com/inventor/juan-manuel-vuletich</pre> <pre>linkedin.com/in/juan-vuletich-75611b3</pre> <pre>twitter.com/JuanVuletich</pre> <o:p></o:p> </blockquote> <o:p></o:p> <pre>-- </pre> <pre>Juan Vuletich</pre> <pre>cuis.st</pre> <pre>github.com/jvuletich</pre> <pre>researchgate.net/profile/Juan-Vuletich</pre> <pre>independent.academia.edu/JuanVuletich</pre> <pre>patents.justia.com/inventor/juan-manuel-vuletich</pre> <pre>linkedin.com/in/juan-vuletich-75611b3</pre> <pre>twitter.com/JuanVuletich</pre> <o:p></o:p> </blockquote> <o:p></o:p> <pre>-- </pre> <pre>Juan Vuletich</pre> <pre>cuis.st</pre> <pre>github.com/jvuletich</pre> <pre>researchgate.net/profile/Juan-Vuletich</pre> <pre>independent.academia.edu/JuanVuletich</pre> <pre>patents.justia.com/inventor/juan-manuel-vuletich</pre> <pre>linkedin.com/in/juan-vuletich-75611b3</pre> <pre>twitter.com/JuanVuletich</pre> <o:p></o:p> </blockquote> <o:p></o:p> <pre>-- </pre> <pre>Juan Vuletich</pre> <pre>cuis.st</pre> <pre>github.com/jvuletich</pre> <pre>researchgate.net/profile/Juan-Vuletich</pre> <pre>independent.academia.edu/JuanVuletich</pre> <pre>patents.justia.com/inventor/juan-manuel-vuletich</pre> <pre>linkedin.com/in/juan-vuletich-75611b3</pre> <pre>twitter.com/JuanVuletich</pre> <o:p> </o:p> </div> </body> </html>