<div><div dir="auto">Oh, I didn’t think it was intentional, but it makes sense. Perhaps it could be configurable in the theme, with some message like buttonContainerColorFrom: or similar (if someone prefers that look, I don’t have a strong preference, I just fixed it because I thought it was a bug).</div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 29 May 2023 at 18:59 Juan Vuletich <<a href="mailto:juan@cuis.st" target="_blank">juan@cuis.st</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)"><u></u>
<div bgcolor="#ffffff" text="#000000">
Hi Luciano,<br>
<br>
On 5/26/2023 4:56 PM, Luciano Notarfrancesco via Cuis-dev wrote:
<blockquote type="cite">
<div dir="ltr">Sorry, this method on top of that looks a little
better, I think.<br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Sat, May 27, 2023 at
3:42 AM Luciano Notarfrancesco <<a href="mailto:luchiano@gmail.com" target="_blank">luchiano@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)">
<div dir="ltr">
<div>The button rows (the LayoutMorphs that own the buttons)
have the same color, so the buttons are kind of invisible
and they look like undifferentiated strings in a row. This
change set tweaks their colors so that the row where they
live correctly adopts the widget color for their window
(instead of the button color from the theme), and the
buttons are colored better for their different states
(enabled/disabled, presed, and highlighted on mouse over).</div>
<div><br>
</div>
<div>I guess LayoutMorph>>#adoptWidgetColor: using the
theme button color was a bug, but I'm not sure, maybe
there's some logic behind it. </div>
</div>
</blockquote>
</div>
</blockquote>
<br>
The idea is that buttons only "pop" when you mouse over them. I
think this gives Cuis a less "busy" look, without all those buttons
calling for your attention. I think that a look where every button
has well defined bounds (either for having a border, or a different
color than background) is reasonable too, and may mean another
Theme.<br>
<br>
The attach, intended to be loaded after your code, goes back to
that "discreet" button look. It also adds a bit more contrast on
mouse over, so buttons really pop when hovered.<br>
<br>
<blockquote type="cite">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)">
<div dir="ltr">
<div>Also, I don't know if we still need the instance
variable doAdoptWidgetColor, it seems hacky, maybe we can
remove all that and let them always adopt the widget
color?<br>
</div>
</div>
</blockquote>
</div>
</blockquote>
<br>
Folks, to see the different, hack #doAdoptWidgetsColor to always
assign false, and see how stuff look. I think we could remove the
ivar, and make the 'true' behavior the only one. Anyone against
this?<br>
<br>
<blockquote type="cite">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)">
<div dir="ltr">
<div>Let me know what you think.</div>
<div>Luciano<br>
</div>
</div>
</blockquote>
</div>
</blockquote>
<br>
Thanks,<br>
<pre cols="72" style="font-family:monospace">--
Juan Vuletich
<a href="http://cuis.st" style="font-family:monospace" target="_blank">cuis.st</a>
<a href="http://github.com/jvuletich" style="font-family:monospace" target="_blank">github.com/jvuletich</a>
<a href="http://researchgate.net/profile/Juan-Vuletich" style="font-family:monospace" target="_blank">researchgate.net/profile/Juan-Vuletich</a>
<a href="http://independent.academia.edu/JuanVuletich" style="font-family:monospace" target="_blank">independent.academia.edu/JuanVuletich</a>
<a href="http://patents.justia.com/inventor/juan-manuel-vuletich" style="font-family:monospace" target="_blank">patents.justia.com/inventor/juan-manuel-vuletich</a>
<a href="http://linkedin.com/in/juan-vuletich-75611b3" style="font-family:monospace" target="_blank">linkedin.com/in/juan-vuletich-75611b3</a>
<a href="http://twitter.com/JuanVuletich" style="font-family:monospace" target="_blank">twitter.com/JuanVuletich</a></pre>
</div>
</blockquote></div></div>
</div>