<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Cool. Just pushed it (together with an unrelated tweak to
#minimumExtent.<br>
<br>
Thanks,<br>
<br>
On 5/29/2023 4:07 PM, Luciano Notarfrancesco via Cuis-dev wrote:
<blockquote
cite="mid:CAL5GDypswWHdXfcH=+musmRv4H6r8SVPDkAEmbnnkTbu6zNLBQ@mail.gmail.com"
type="cite">
<div dir="auto">Right, in that case we shouldn’t draw anything
else besides the icon, makes sense.</div>
<div><br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Mon, 29 May 2023 at 21:06
Juan Vuletich <<a moz-do-not-send="true"
href="mailto:juan@cuis.st">juan@cuis.st</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
<div bgcolor="#ffffff" text="#000000"> On 5/24/2023 6:54 PM,
Luciano Notarfrancesco via Cuis-dev wrote:
<blockquote type="cite">
<div dir="auto">Ah, it shows up only without round
buttons. Change Theme>>#roundButtons to return
false and you should see it.</div>
<div dir="auto"><br>
</div>
<div>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Wed, 24 May
2023 at 22:32 Juan Vuletich <<a
moz-do-not-send="true"
href="mailto:juan@cuis.st" target="_blank">juan@cuis.st</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin: 0px
0px 0px 0.8ex; border-left: 1px solid rgb(204,
204, 204); padding-left: 1ex;">On 5/24/2023 3:08
PM, Luciano Notarfrancesco via Cuis-dev wrote:<br>
> The close/collapse/expand/menu buttons in
SystemWindows are <br>
> PluggableButtonMorphs, so they adopt the
window color when the window <br>
> is opened in the world (see
SystemWindow>>#openInWorld and <br>
>
PluggableButtonMorph>>#adoptWidgetsColor:).
The color is set when <br>
> opening the window and never changes. Then,
when a window is active, <br>
> the title is draw with a lighter color, and
this doesn’t match the <br>
> color of the buttons and causes a dark square
shadow. At first I <br>
> thought this was because we were using
rasterized icons, but no, it’s <br>
> just a bug. Perhaps it’s more noticeable in
my image because of the <br>
> color scheme I’m using.<br>
><br>
> Juan, what’s the right way to fix this? I
would prefer not to add <br>
> variables to PluggableButtonMorph, or create
a subclass, or hardcode <br>
> some special case in
>>#adoptWidgetsColor:. Perhaps you have a
better <br>
> idea?<br>
<br>
Hi Luciano,<br>
<br>
I can't reproduce the problem in the stock Cuis
image. Button background <br>
pixels are transparent (pixel value = 0), so they
should not be affected <br>
at all by the window color.<br>
<br>
HTH,</blockquote>
</div>
</div>
</blockquote>
<br>
Oh, I see. Well, to me the obvious solution is: <br>
<br>
PluggableButtonMorph >> drawOn: aCanvas<br>
aCanvas drawButtonIconFromCurrentMorph ifFalse: [<br>
self isRoundButton<br>
ifTrue: [ self drawRoundLookOn: aCanvas ]<br>
ifFalse: [ self draw3DLookOn: aCanvas ]].<br>
<br>
The idea is that if a button is an icon, it is neither
"round" nor "3d", just the icon. Does this make sense and
work well for you?<br>
<br>
Thanks,</div>
<div bgcolor="#ffffff" text="#000000"><br>
<pre style="font-family: monospace;" cols="72">--
Juan Vuletich
<a moz-do-not-send="true" href="http://cuis.st" target="_blank" style="font-family: monospace;">cuis.st</a>
<a moz-do-not-send="true" href="http://github.com/jvuletich" target="_blank" style="font-family: monospace;">github.com/jvuletich</a>
<a moz-do-not-send="true" href="http://researchgate.net/profile/Juan-Vuletich" target="_blank" style="font-family: monospace;">researchgate.net/profile/Juan-Vuletich</a>
<a moz-do-not-send="true" href="http://independent.academia.edu/JuanVuletich" target="_blank" style="font-family: monospace;">independent.academia.edu/JuanVuletich</a>
<a moz-do-not-send="true" href="http://patents.justia.com/inventor/juan-manuel-vuletich" target="_blank" style="font-family: monospace;">patents.justia.com/inventor/juan-manuel-vuletich</a>
<a moz-do-not-send="true" href="http://linkedin.com/in/juan-vuletich-75611b3" target="_blank" style="font-family: monospace;">linkedin.com/in/juan-vuletich-75611b3</a>
<a moz-do-not-send="true" href="http://twitter.com/JuanVuletich" target="_blank" style="font-family: monospace;">twitter.com/JuanVuletich</a></pre>
</div>
</blockquote>
</div>
</div>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Juan Vuletich
cuis.st
github.com/jvuletich
researchgate.net/profile/Juan-Vuletich
independent.academia.edu/JuanVuletich
patents.justia.com/inventor/juan-manuel-vuletich
linkedin.com/in/juan-vuletich-75611b3
twitter.com/JuanVuletich</pre>
</body>
</html>