<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Hi Nico,<br>
<br>
On 12/29/2024 4:59 PM, Nicolás Papagna Maldonado via Cuis-dev wrote:
<blockquote
cite="mid:CADGn7BOJ6HynQz=LQ9rAOp2m0f1WoJCcE8XDCfHmMzLDOFxnGA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div dir="ltr">Turns out the failing tests were expected in OSX,
that's why the exit code is indeed 0.
<div><br>
</div>
<div>It looks like there is a feature that allows us to mark
some tests as "broken" (didn't know about this one). See:</div>
<div><font face="monospace"><br>
</font></div>
<div><font face="monospace">FloatTest expectedFailures<br>
Smalltalk platformName = 'Mac OS' ifTrue: [<br>
^#(testE testExp testPrimExpAndLn) ].<br>
^#().</font></div>
<div><font face="monospace"><br>
</font></div>
What is confusing is that these tests are reported as failures
in the console:
<div><font face="monospace"><br>
</font></div>
<div>
<div style="color: rgb(240, 246, 252); font-family:
ui-monospace,SFMono-Regular,"SF
Mono",Menlo,Consolas,"Liberation
Mono",monospace; font-size: 12px; background-color:
rgb(1, 4, 9);">
<div class="gmail-js-check-step-line gmail-CheckStep-line
gmail-d-flex gmail-log-line-plain" style="line-height:
20px;"><span class="gmail-CheckStep-line-content
gmail-d-inline-block gmail-flex-auto gmail-ml-3
gmail-js-check-line-content" style="overflow-x: auto;
display: inline-block;"><span class="gmail-ansifg-r"
style="color: rgb(255, 123, 114);">--------
</span></span></div>
</div>
<div style="color: rgb(240, 246, 252); font-family:
ui-monospace,SFMono-Regular,"SF
Mono",Menlo,Consolas,"Liberation
Mono",monospace; font-size: 12px; background-color:
rgb(1, 4, 9);">
<div class="gmail-js-check-step-line gmail-CheckStep-line
gmail-d-flex gmail-log-line-plain" style="line-height:
20px;"><a moz-do-not-send="true"
class="gmail-CheckStep-line-number
gmail-color-fg-muted gmail-d-inline-block
gmail-text-mono gmail-text-normal gmail-flex-shrink-0"
href="https://github.com/npapagna/Cuis-Smalltalk-Dev-Fix-CI-Tests/actions/runs/12538106004/job/34962890559#step:5:2053"
style="background-color: transparent; width: 48px;
overflow: hidden; text-align: right; display:
inline-block;">2052</a><span
class="gmail-CheckStep-line-content
gmail-d-inline-block gmail-flex-auto gmail-ml-3
gmail-js-check-line-content" style="overflow-x: auto;
display: inline-block;"><span class="gmail-ansifg-r"
style="color: rgb(255, 123, 114);">3 FAILURE(S)
</span></span></div>
</div>
<div style="color: rgb(240, 246, 252); font-family:
ui-monospace,SFMono-Regular,"SF
Mono",Menlo,Consolas,"Liberation
Mono",monospace; font-size: 12px; background-color:
rgb(1, 4, 9);">
<div class="gmail-js-check-step-line gmail-CheckStep-line
gmail-d-flex gmail-log-line-plain" style="line-height:
20px;"><a moz-do-not-send="true"
class="gmail-CheckStep-line-number
gmail-color-fg-muted gmail-d-inline-block
gmail-text-mono gmail-text-normal gmail-flex-shrink-0"
href="https://github.com/npapagna/Cuis-Smalltalk-Dev-Fix-CI-Tests/actions/runs/12538106004/job/34962890559#step:5:2054"
style="background-color: transparent; width: 48px;
overflow: hidden; text-align: right; display:
inline-block;">2053</a><span
class="gmail-CheckStep-line-content
gmail-d-inline-block gmail-flex-auto gmail-ml-3
gmail-js-check-line-content" style="overflow-x: auto;
display: inline-block;"><span class="gmail-ansifg-r"
style="color: rgb(255, 123, 114);">--------
</span></span></div>
</div>
<div style="color: rgb(240, 246, 252); font-family:
ui-monospace,SFMono-Regular,"SF
Mono",Menlo,Consolas,"Liberation
Mono",monospace; font-size: 12px; background-color:
rgb(1, 4, 9);">
<div class="gmail-js-check-step-line gmail-CheckStep-line
gmail-d-flex gmail-log-line-plain" style="line-height:
20px;"><a moz-do-not-send="true"
class="gmail-CheckStep-line-number
gmail-color-fg-muted gmail-d-inline-block
gmail-text-mono gmail-text-normal gmail-flex-shrink-0"
href="https://github.com/npapagna/Cuis-Smalltalk-Dev-Fix-CI-Tests/actions/runs/12538106004/job/34962890559#step:5:2055"
style="background-color: transparent; width: 48px;
overflow: hidden; text-align: right; display:
inline-block;">2054</a><span
class="gmail-CheckStep-line-content
gmail-d-inline-block gmail-flex-auto gmail-ml-3
gmail-js-check-line-content" style="overflow-x: auto;
display: inline-block;"><span class="gmail-ansifg-r"
style="color: rgb(255, 123, 114);">r274C;
FloatTest>>#testE has failed because:
Assertion (3) failed. </span></span></div>
</div>
<div style="color: rgb(240, 246, 252); font-family:
ui-monospace,SFMono-Regular,"SF
Mono",Menlo,Consolas,"Liberation
Mono",monospace; font-size: 12px; background-color:
rgb(1, 4, 9);">
<div class="gmail-js-check-step-line gmail-CheckStep-line
gmail-d-flex gmail-log-line-plain" style="line-height:
20px;"><a moz-do-not-send="true"
class="gmail-CheckStep-line-number
gmail-color-fg-muted gmail-d-inline-block
gmail-text-mono gmail-text-normal gmail-flex-shrink-0"
href="https://github.com/npapagna/Cuis-Smalltalk-Dev-Fix-CI-Tests/actions/runs/12538106004/job/34962890559#step:5:2056"
style="background-color: transparent; width: 48px;
overflow: hidden; text-align: right; display:
inline-block;">2055</a><span
class="gmail-CheckStep-line-content
gmail-d-inline-block gmail-flex-auto gmail-ml-3
gmail-js-check-line-content" style="overflow-x: auto;
display: inline-block;"><span class="gmail-ansifg-r"
style="color: rgb(255, 123, 114);">r274C;
FloatTest>>#testExp has failed because:
Assertion (2) failed. </span></span></div>
</div>
<div style="color: rgb(240, 246, 252); font-family:
ui-monospace,SFMono-Regular,"SF
Mono",Menlo,Consolas,"Liberation
Mono",monospace; font-size: 12px; background-color:
rgb(1, 4, 9);">
<div class="gmail-js-check-step-line gmail-CheckStep-line
gmail-d-flex gmail-log-line-plain" style="line-height:
20px;"><a moz-do-not-send="true"
class="gmail-CheckStep-line-number
gmail-color-fg-muted gmail-d-inline-block
gmail-text-mono gmail-text-normal gmail-flex-shrink-0"
href="https://github.com/npapagna/Cuis-Smalltalk-Dev-Fix-CI-Tests/actions/runs/12538106004/job/34962890559#step:5:2057"
style="background-color: transparent; width: 48px;
overflow: hidden; text-align: right; display:
inline-block;">2056</a><span
class="gmail-CheckStep-line-content
gmail-d-inline-block gmail-flex-auto gmail-ml-3
gmail-js-check-line-content" style="overflow-x: auto;
display: inline-block;"><span class="gmail-ansifg-r"
style="color: rgb(255, 123, 114);">r274C;
FloatTest>>#testPrimExpAndLn has failed
because: Assertion (1) failed. </span></span></div>
</div>
</div>
</div>
<div><br>
</div>
<div>Maybe we should use another color/category to let users
know these were expected failures?</div>
</div>
</blockquote>
<br>
Yes, that would be nice. Maybe yellow.<br>
<br>
<blockquote
cite="mid:CADGn7BOJ6HynQz=LQ9rAOp2m0f1WoJCcE8XDCfHmMzLDOFxnGA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div><br>
</div>
<div>Best,</div>
<div>Nico PM</div>
<div><br>
</div>
<span class="gmail_signature_prefix">-- </span><br>
<div dir="ltr" class="gmail_signature"><br>
Nicolás Papagna</div>
</div>
</blockquote>
<br>
Cheers,<br>
<pre class="moz-signature" cols="72">--
Juan Vuletich
cuis.st
github.com/jvuletich
researchgate.net/profile/Juan-Vuletich
independent.academia.edu/JuanVuletich
patents.justia.com/inventor/juan-manuel-vuletich
linkedin.com/in/juan-vuletich-75611b3
twitter.com/JuanVuletich</pre>
</body>
</html>