<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Both fixes and tests are now at GitHub.</p>
<p>Thanks!</p>
<div class="moz-cite-prefix">On 21/09/2025 4:36 PM, Hernán Wilkinson
via Cuis-dev wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAGgF3Gy7NvWWYs-RPfVjtQ8CH1oTtKzgxd2rAcfFLoQT6tu+aw@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div dir="ltr">Hi,</div>
<div> I forgot to send the test that reproduces the error for
the extract method.</div>
<div> Attached is the cs for it.</div>
<div><br>
</div>
<div>Hernan</div>
<br>
<div class="gmail_quote gmail_quote_container">
<div dir="ltr" class="gmail_attr">On Sat, Sep 20, 2025 at
6:44 PM Hernán Wilkinson <<a
href="mailto:hernan.wilkinson@10pines.com"
moz-do-not-send="true" class="moz-txt-link-freetext">hernan.wilkinson@10pines.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote"
style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div>Hi,</div>
<div> attached is a .cs that fixes an edge case when
having an unnecessary dot at the beginning of a method,
for example:</div>
<div>m1. <-- that dot </div>
<div> ^10 factorial</div>
<div><br>
</div>
<div>The method node for that source code had a node
without source range, it was:</div>
<div>m1</div>
<div> self. <-- unnecessary generated node and
without source range</div>
<div> ^10 factorial.</div>
<div><br>
</div>
<div>This only happened when the unnecessary dot was
before any other statement, it did not happen for
unnecessary dots elsewhere. For example:</div>
<div>m1</div>
<div> 1+2.</div>
<div> .</div>
<div> ^10 factorial.</div>
<div><br>
</div>
<div>generates a method node without the unnecessary self
node:</div>
<div>m1</div>
<div> 1+2.</div>
<div> ^10 factorial</div>
<div><br>
</div>
<div>(when the dot was at the beginning of a block, nil
was inserted instead of self).</div>
<div>This behavior made the extract method refactoring
fail because of that unnecessary node without source
range.</div>
<div><br>
</div>
<div>Attached is the fix and other .cs that remove
unnecessary dots I found in the source code when
checking if the fix worked fine. These other cs are not
necessary to apply.</div>
<div><br>
</div>
<div>Cheers!</div>
<div>Hernan.</div>
<div><br>
</div>
<div><br>
</div>
<span class="gmail_signature_prefix">-- </span><br>
<div dir="ltr" class="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div style="font-size:small">
<div dir="ltr">
<div dir="ltr">
<div style="font-size:12.8px"><span
style="font-family:tahoma,sans-serif;font-size:xx-small;border-collapse:collapse"><strong><span
style="font-size:8pt"><span
style="font-size:small"><font
size="2"><span
style="font-weight:normal"><span
style="font-weight:bold">Hernán
Wilkinson</span><br>
Agile Software Development,
Teaching & Coaching</span></font></span></span></strong></span></div>
<div style="font-size:12.8px"><span
style="font-family:tahoma,sans-serif;font-size:xx-small;border-collapse:collapse"><strong><span
style="font-size:8pt"><span
style="font-size:small"><font
size="2"><span
style="font-weight:normal">Phone:
+54-011</span></font></span></span></strong></span><font
face="tahoma, sans-serif" size="2">-4893-2057</font></div>
<div style="font-size:12.8px"><strong
style="font-family:tahoma,sans-serif;font-size:xx-small"><span
style="font-size:8pt"><span
style="font-size:small"><font
size="2"><span
style="font-weight:normal">Twitter:
@HernanWilkinson</span></font></span></span></strong></div>
<div style="font-size:12.8px"><span
style="font-family:tahoma,sans-serif;font-size:xx-small;border-collapse:collapse"><strong><span
style="font-size:8pt"><span
style="font-size:small"><font
size="2"><span
style="font-weight:normal">site: <a
href="http://www.10pines.com/" style="color:rgb(17,65,112)"
target="_blank"
moz-do-not-send="true">http://www.10Pines.com</a></span></font></span></span></strong></span></div>
<div style="font-size:12.8px"><font
face="tahoma, sans-serif"><span
style="border-collapse:collapse">Address:
Alem 896</span></font>, Floor 6,
Buenos Aires, Argentina</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<div><br clear="all">
</div>
<div><br>
</div>
<span class="gmail_signature_prefix">-- </span><br>
<div dir="ltr" class="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div style="font-size:small">
<div dir="ltr">
<div dir="ltr">
<div style="font-size:12.8px"><span
style="font-family:tahoma,sans-serif;font-size:xx-small;border-collapse:collapse"><strong><span
style="font-size:8pt"><span
style="font-size:small"><font size="2"><span
style="font-weight:normal"><span
style="font-weight:bold">Hernán
Wilkinson</span><br>
Agile Software Development, Teaching
& Coaching</span></font></span></span></strong></span></div>
<div style="font-size:12.8px"><span
style="font-family:tahoma,sans-serif;font-size:xx-small;border-collapse:collapse"><strong><span
style="font-size:8pt"><span
style="font-size:small"><font size="2"><span
style="font-weight:normal">Phone:
+54-011</span></font></span></span></strong></span><font
face="tahoma, sans-serif" size="2">-4893-2057</font></div>
<div style="font-size:12.8px"><strong
style="font-family:tahoma,sans-serif;font-size:xx-small"><span
style="font-size:8pt"><span
style="font-size:small"><font size="2"><span
style="font-weight:normal">Twitter:
@HernanWilkinson</span></font></span></span></strong></div>
<div style="font-size:12.8px"><span
style="font-family:tahoma,sans-serif;font-size:xx-small;border-collapse:collapse"><strong><span
style="font-size:8pt"><span
style="font-size:small"><font size="2"><span
style="font-weight:normal">site: <a
href="http://www.10pines.com/"
style="color:rgb(17,65,112)"
target="_blank"
moz-do-not-send="true">http://www.10Pines.com</a></span></font></span></span></strong></span></div>
<div style="font-size:12.8px"><font
face="tahoma, sans-serif"><span
style="border-collapse:collapse">Address:
Alem 896</span></font>, Floor 6, Buenos
Aires, Argentina</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<br>
<fieldset class="moz-mime-attachment-header"></fieldset>
</blockquote>
<pre class="moz-signature" cols="72">--
Juan Vuletich
<a class="moz-txt-link-abbreviated" href="http://www.cuis.st">www.cuis.st</a>
github.com/jvuletich
researchgate.net/profile/Juan-Vuletich
independent.academia.edu/JuanVuletich
patents.justia.com/inventor/juan-manuel-vuletich</pre>
</body>
</html>