<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hi Folks,<br>
<br>
</p>
<p>I've finally spent a couple of hours reviewing this. I like the
idea, and it seems to work. Some comments:<br>
<br>
</p>
<p>- #buildMorphicSingleMessageList uses a PluggableListMorphOfMany
and is essentially the same as #buildMorphicMultipleMessageList.<br>
- #buildMorphicMultipleMessageList has no senders at all<br>
- It looks like the intention was to allow the user to choose
between a single-selection and a multi-selection method list, but
no such preference is provided<br>
- #turnMouseButton1Into2 is deactivated, but some people may be
using it with a single-button mouse. I agree that this clashes
with the common gestures for multiple selection, but removing this
needs consensus in the community, or an alternative that keeps
support for 1-button mice working.<br>
- #OnShiftPressedSelectFrom:To: has both keywords starting in
uppercase. This is not common Smalltalk style.<br>
- The current behavior of PluggableListMorphOfMany is to allow
using click to select and to deselect elements. This is useful,
for instance in the MethodSetWindow hierarchy. Is disabling this
needed?<br>
<br>
</p>
<p>I think this code needs some more work, and some consensus on the
changes that affect existing behavior.<br>
<br>
</p>
<p>Thanks,</p>
<p><br>
</p>
<div class="moz-cite-prefix">On 2025-11-25 11:59 AM, alan wharton
via Cuis-dev wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CP4P284MB2419500C67DE45AD2348EA7DE0D5A@CP4P284MB2419.BRAP284.PROD.OUTLOOK.COM">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<style type="text/css" style="display:none;">P {margin-top:0;margin-bottom:0;}</style>
<div
style="text-align: left; text-indent: 0px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"
class="elementToProof">
Hello!</div>
<div
style="text-align: left; text-indent: 0px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"
class="elementToProof">
We've implemented together with Nicolas Halperin the possibility
to select multiple messages, and make operations like moving to
a different category, various refactors or running a test
suite. </div>
<div
style="text-align: left; text-indent: 0px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"
class="elementToProof">
One important thing to notice is that we modified a method that
seemed that it had no use when browsing its senders:</div>
<div
style="text-align: left; text-indent: 0px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"
class="elementToProof">
turnMouseButton1Into2<br>
"Answer true if modifier keys are such that button 1 should be
considered as button 2.<br>
ctrl - click -> right click<br>
"<br>
<br>
"(self controlKeyPressed and: [self shiftPressed not]) ifTrue: [
^ true ]."<br>
^ false</div>
<div
style="text-align: left; text-indent: 0px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"
class="elementToProof">
<br>
</div>
<div
style="text-align: left; text-indent: 0px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"
class="elementToProof">
We wanted to have a multipleSelect with no drag and for that we
used the controlKey, and noticed this method was impeding us
from doing that.</div>
<div
style="text-align: left; text-indent: 0px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"
class="elementToProof">
<br>
</div>
<div
style="text-align: left; text-indent: 0px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"
class="elementToProof">
Hope you take a look!</div>
<div
style="text-align: left; text-indent: 0px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"
class="elementToProof">
Alan Wharton</div>
<div
style="text-align: left; text-indent: 0px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"
class="elementToProof">
Nicolas Halperin</div>
<div
style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"
class="elementToProof">
<br>
</div>
<div
style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"
class="elementToProof">
<br>
</div>
<div
style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<br>
<fieldset class="moz-mime-attachment-header"></fieldset>
</blockquote>
<pre class="moz-signature" cols="72">--
Juan Vuletich
<a class="moz-txt-link-abbreviated" href="http://www.cuis.st">www.cuis.st</a>
github.com/jvuletich
researchgate.net/profile/Juan-Vuletich
independent.academia.edu/JuanVuletich
patents.justia.com/inventor/juan-manuel-vuletich</pre>
</body>
</html>