<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hi Facu,</p>
<p>I think both changes are perfectly safe, and good cleanup. Just
pushed them to GitHub.</p>
<p>Thanks!</p>
<div class="moz-cite-prefix">On 2026-04-07 5:19 PM, Facundo Javier
Gelatti via Cuis-dev wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAC1UKnbcPv_ZWNdTb0tX9mj0iXdGp+JEbVHyS8uQtLm+TsivSg@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div>Hi!<br>
<br>
</div>
<div>I attach two independent changes.<br>
<br>
A first one to remove some duplicated code for
#defineClass:notifying: in Browser and HierarchyBrowser (I
extracted a new message to be able to just add the
difference).</div>
<div><br>
</div>
<div>A second one, to remove the duplication in
#removeMessageCategory in Browser and CodeFileBrowser, but
which I'm not sure about and needs more explanation (which is
below).<br>
<br>
</div>
<div>The differences in #removeMessageCategory in Browser and
CodeFileBrowser are:</div>
<div>
<ul>
<li>that Browser <i>always</i> sends changed:
#messageCategoryList (which I guess is harmless?), and</li>
<li>CodeFileBrowser <i>does not</i> send changed:
#classSelectionChanged.</li>
</ul>
</div>
<div>But if we check the senders of #classSelectionChanged, we
see it's only used in the context of #changed:, but no object
seems to be listening to that change. If that's the case, then
we can remove all usages of #classSelectionChanged and then
remove the CodeFileBrowser>>#removeMessageCategory
method (so CodeFileBrowser inherits the one from Browser). And
that's what's done in the second change set.<br>
<br>
</div>
<div>Cheers!<br>
</div>
<div>Facu</div>
</div>
<br>
<fieldset class="moz-mime-attachment-header"></fieldset>
</blockquote>
<pre class="moz-signature" cols="72">--
Juan Vuletich
<a class="moz-txt-link-abbreviated" href="http://www.cuis.st">www.cuis.st</a>
github.com/jvuletich
researchgate.net/profile/Juan-Vuletich
independent.academia.edu/JuanVuletich
patents.justia.com/inventor/juan-manuel-vuletich</pre>
</body>
</html>