[Cuis-dev] Declaring undeclared variables inside block

[Eric Brandwein]

Oh, I didn't realise the tests were in the CompilerExceptionsTest class so
I assumed the Parser just wasn't being tested. I'll add tests next time.

Cheers,
Eric

El mar., 17 dic. 2019 a las 17:28, Hernan Wilkinson (<
hernan.wilkinson at 10pines.com>) escribió:

> Hi Eric,
>  thank you for the fix!
>  It is integrated and I wrote the tests for it.
>  Tests for the next fix will be appreciated :-)
>
> Thank you!
> Hernan.
>
> On Fri, Dec 13, 2019 at 1:39 AM Eric Brandwein via Cuis-dev <
> cuis-dev at lists.cuis.st> wrote:
>
>> Hi all,
>>
>> In the current image there's a bug when declaring undeclared temporary
>> variables inside a block. This one has two related consequences:
>> 1. If the block has no temporaries, but it does have two $| in the
>> temporary declaration part, then it declares the missing temporary in a new
>> set of $|. You can reproduce this one by saving this method:
>>
>> test
>>      [|| var _ 'var']
>>
>> and selecting "declare block-local temp" in the popup that appears.
>>
>> 2. If the block has temporaries, but the last temporary declared doesn't
>> have a space after it, it declares the new temporary right after that one,
>> without a space in between. You can reproduce this one by saving this
>> method:
>>
>> test
>>      [ | var1| var2 _ 'var']
>>
>> and again selecting "declare block-local temp" in the popup that appears.
>>
>> Attached is a ChangeSet that solves both issues. Comments are very
>> welcome.
>>
>> Cheers,
>> Eric
>> --
>> Cuis-dev mailing list
>> Cuis-dev at lists.cuis.st
>> https://lists.cuis.st/mailman/listinfo/cuis-dev
>>
>
>
> --
>
> *Hernán WilkinsonAgile Software Development, Teaching & Coaching*
> *Phone: +54-011*-4893-2057
> *Twitter: @HernanWilkinson*
> *site: http://www.10Pines.com <http://www.10pines.com/>*
> Address: Alem 896, Floor 6, Buenos Aires, Argentina
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20191218/b25ead62/attachment.htm>