[Cuis-dev] References to it not working

[Hernan Wilkinson]

Hi Eric,
 as you know, Symbols as unique. To keep uniqueness a table of existing
symbols is used.
 The message #hasInterned: is used to know if a string has a symbol related
to it. That is necessary because the editors handles strings not symbols
and if you want to look for sender of a message for example, the selected
string has to be converted to a symbol.
 The problem was that #selectedSymbol returned nil when the string was "not
interned" and it did not look the selected string as inst. var.
 I uploaded a fix and now it works.

Cheers
Hernan.

On Fri, Jun 7, 2019 at 8:40 PM Eric Brandwein <brandweineric at gmail.com>
wrote:

> I'm noticing it's not working again, because some instance variables
> aren't "interned" by the Symbol class. I don't really know what that means,
> and neither why it's being called in SmalltalkEditor>>#selectedSymbol,
> instead of just doing aString asSymbol. Specially because it's being called
> only by #browseIt and #referencesToIt, and I don't understand how having
> the Symbol interned changes those methods. Does anyone know?
>
> El mar., 28 may. 2019 a las 16:24, Hernan Wilkinson (<
> hernan.wilkinson at 10pines.com>) escribió:
>
>> Great! On github now.
>>
>> I made a few changes :-) There was a minor error, when the environment
>> was Smalltalk it did not answer #allInstVarNames. (The environment is
>> Smalltalk when no class is selected for example).
>>
>> Thanks!
>> Hernan.
>>
>> On Mon, May 27, 2019 at 6:15 PM Eric Brandwein <brandweineric at gmail.com>
>> wrote:
>>
>>> Great! Here's a ChangeSet that adds it then.
>>>
>>> El lun., 27 may. 2019 a las 15:50, Hernan Wilkinson (<
>>> hernan.wilkinson at 10pines.com>) escribió:
>>>
>>>> It is already implemented but not related to that shortcut...
>>>> If you press the 'inst vars' button in the browser it shows you the
>>>> references to inst vars.
>>>> It would be nice that 'references to it' worked also with inst vars...
>>>> it should not be difficult to implement
>>>>
>>>> On Mon, May 27, 2019 at 3:44 PM Eric Brandwein <brandweineric at gmail.com>
>>>> wrote:
>>>>
>>>>> Ohhhh that's why, thanks. It would be really handy though to have a
>>>>> references to it for instance variables. Maybe I'll try to add it.
>>>>>
>>>>> El lun., 27 may. 2019 a las 15:30, Hernan Wilkinson (<
>>>>> hernan.wilkinson at 10pines.com>) escribió:
>>>>>
>>>>>> References to it works for classes, it is not for instance
>>>>>> variables...
>>>>>>
>>>>>> On Mon, May 27, 2019 at 3:24 PM Eric Brandwein via Cuis-dev <
>>>>>> cuis-dev at lists.cuis.st> wrote:
>>>>>>
>>>>>>> Hi all,
>>>>>>>
>>>>>>> I've noticed that doing "references to it... (N)" in an instance
>>>>>>> variable doesn't seem to work. Attached is a .st file that shows this
>>>>>>> error; to reproduce it, just place the cursor on the instanceVariable and
>>>>>>> press ctrl-shift-n.
>>>>>>>
>>>>>>> Cheers,
>>>>>>> Eric
>>>>>>> --
>>>>>>> Cuis-dev mailing list
>>>>>>> Cuis-dev at lists.cuis.st
>>>>>>> https://lists.cuis.st/mailman/listinfo/cuis-dev
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>>
>>>>>> *Hernán WilkinsonAgile Software Development, Teaching & Coaching*
>>>>>> *Phone: +54-011*-4893-2057
>>>>>> *Twitter: @HernanWilkinson*
>>>>>> *site: http://www.10Pines.com <http://www.10pines.com/>*
>>>>>> Address: Alem 896, Floor 6, Buenos Aires, Argentina
>>>>>>
>>>>>
>>>>
>>>> --
>>>>
>>>> *Hernán WilkinsonAgile Software Development, Teaching & Coaching*
>>>> *Phone: +54-011*-4893-2057
>>>> *Twitter: @HernanWilkinson*
>>>> *site: http://www.10Pines.com <http://www.10pines.com/>*
>>>> Address: Alem 896, Floor 6, Buenos Aires, Argentina
>>>>
>>>
>>
>> --
>>
>> *Hernán WilkinsonAgile Software Development, Teaching & Coaching*
>> *Phone: +54-011*-4893-2057
>> *Twitter: @HernanWilkinson*
>> *site: http://www.10Pines.com <http://www.10pines.com/>*
>> Address: Alem 896, Floor 6, Buenos Aires, Argentina
>>
>

-- 

*Hernán WilkinsonAgile Software Development, Teaching & Coaching*
*Phone: +54-011*-4893-2057
*Twitter: @HernanWilkinson*
*site: http://www.10Pines.com <http://www.10pines.com/>*
Address: Alem 896, Floor 6, Buenos Aires, Argentina
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20190608/b9d44480/attachment.html>