[Cuis-dev] [Ann] Refinements to Exception handling

[Juan Vuletich]

Hi Phil, Folks,

On 10/13/2019 9:25 PM, Phil B wrote:
> Just did a quick look at senders of #on:do: and found these:
>
> AndreasSystemProfiler>canWork
> Browser>contents:notifying:
> FeatureRequirement>require
> FeatureRequirement>satisfyRequirementsAndInstall
> MethodNode>generatePreSpur:using:
> MethodNode>generateSpur:using:
> RefactoringApplier>createAndValueHandlingExceptions:
> SmalltalkEditor>renameTemporary:
> SmalltalkEditor>withClassDefinitionNodeAndClassDo:ifErrorsParsing:
> SmalltalkEditor>withMethodNodeAndClassDo:ifErrorsParsing:
> SystemDictionary>okayToSave
>
> That's ~15% of #on:do: senders in the base image *directly* returning 
> within the block.  (i.e. I didn't check any of the blocks passed as 
> parameters which might also do so or any of the other ways this might 
> occur)  I don't think this change is fully baked...
>
>
> On Sun, Oct 13, 2019 at 8:00 PM Phil B <pbpublist at gmail.com 
> <mailto:pbpublist at gmail.com>> wrote:
>
>     It looks like we have at least some changes in the core image to
>     resolve.  World menu->Save as... now fails.  Has a scan of the
>     image been done to identify where these cases might be buried?
>

I pushed these changes without fully analyzing their consequences, and 
without appropriate discussion. I should have discussed this with fellow 
co-maintainer Hernán and Andrés who saw the issue and suggested the 
solution some months ago. This most likely annoyed you all.

I take responsibility for this error, and apologize for this.

More comments in other responses to this thread.

Thanks for your patience.

-- 
Juan Vuletich
www.cuis-smalltalk.org
https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
https://github.com/jvuletich
https://www.linkedin.com/in/juan-vuletich-75611b3
@JuanVuletich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20191014/e4586cb9/attachment-0001.htm>