[Cuis-dev] [Integrated] Re: [Integrated] Re: Changes refactoring - Part 2

[Juan Vuletich]

Integrated @ GitHub. Thanks!

Cheers,

-- 
Juan Vuletich
www.cuis-smalltalk.org
https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
https://github.com/jvuletich
https://www.linkedin.com/in/juan-vuletich-75611b3
@JuanVuletich


On 10/29/2019 11:21 AM, Hernan Wilkinson wrote:
> Hi Juan,
>  attached is a .cs with the changes you suggested, good point!
>  Also the changes for the test that was failing :-)
>
> Cheers!
> Hernan.
>
> On Mon, Oct 28, 2019 at 4:57 PM Juan Vuletich via Cuis-dev 
> <cuis-dev at lists.cuis.st <mailto:cuis-dev at lists.cuis.st>> wrote:
>
>
>     Integrated.
>
>     BTW (inline),
>
>     On 10/28/2019 10:57 AM, Juan Vuletich via Cuis-dev wrote:
>>     On 10/27/2019 12:05 AM, Hernan Wilkinson via Cuis-dev wrote:
>>>     Hi,
>>>      attached are two more refactorings of the changes model
>>>
>>>     Cheers!
>>>     Hernan.
>>>
>>>     -- 
>>>     *Hernán Wilkinson
>>>     Agile Software Development, Teaching & Coaching*
>>>     *Phone: +54-011*-4893-2057
>>>     *Twitter: @HernanWilkinson*
>>>     *site: http://www.10Pines.com <http://www.10pines.com/>*
>>>     Address: Alem 896, Floor 6, Buenos Aires, Argentina
>>
>>     Hi Hernán,
>>
>>     I just reviewed the changes. These are very good additions, and
>>     complete quite a bit our changes model.
>>
>>     Still I have a couple of comments / questions:
>>
>>     1) In #classDefinitionRecordFrom: the category is retrieved from
>>     'tokens last' even if the call to #stampFrom: means that the
>>     method should handle a possible stamp. I guess a method
>>     #categoryFrom: , similar to #stampFrom: is in order, right?
>>
>>     2) In #stampFrom: I suggest making the last line read "^ stamp
>>     ifNil: [ '' ]", so we can review changes like your #3930 (already
>>     loaded) without a walkback.
>>
>>     3) After loading this changes, an evaluation of "ClassOrganizer
>>     allInstancesDo: [:co | co removeEmptyCategories]." is in order.
>
>     Done as part of #3941.
>
>>
>>     4) Maybe not related to all these, but
>>     #test03SuiteForNoTestCaseClassAndNoTestClassLooksForReferencesInTests
>>     fails because Object testCaseClass = ObjectTest (even if
>>     unrelated I believe you wrote both the failing test and
>>     ObjectTest class).
>>
>>     Cheers,
>>     -- 
>>     Juan Vuletich
>>     www.cuis-smalltalk.org  <http://www.cuis-smalltalk.org>
>>     https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
>>     https://github.com/jvuletich
>>     https://www.linkedin.com/in/juan-vuletich-75611b3
>>     @JuanVuletich
>
>     Cheers,
>
>     -- 
>     Juan Vuletich
>     www.cuis-smalltalk.org  <http://www.cuis-smalltalk.org>
>     https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
>     https://github.com/jvuletich
>     https://www.linkedin.com/in/juan-vuletich-75611b3
>     @JuanVuletich
>
>     -- 
>     Cuis-dev mailing list
>     Cuis-dev at lists.cuis.st <mailto:Cuis-dev at lists.cuis.st>
>     https://lists.cuis.st/mailman/listinfo/cuis-dev
>
>
>
> -- 
> *Hernán Wilkinson
> Agile Software Development, Teaching & Coaching*
> *Phone: +54-011*-4893-2057
> *Twitter: @HernanWilkinson*
> *site: http://www.10Pines.com <http://www.10pines.com/>*
> Address: Alem 896, Floor 6, Buenos Aires, Argentina

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20191029/68372add/attachment-0001.htm>