[Cuis-dev] Fwd: [ChangeSet] Extract Temporary - alpha version!

[Juan Vuletich]

Just pushed a change to GitHub.

Cheers,

-- 
Juan Vuletich
www.cuis-smalltalk.org
https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
https://github.com/jvuletich
https://www.linkedin.com/in/juan-vuletich-75611b3
@JuanVuletich


On 4/19/2020 9:00 PM, Juan Vuletich via Cuis-dev wrote:
> Hi Nahuel,
>
> Thanks. This is great!
>
> Still, there's something I don't really like in the changes, and it is 
> adding domain specific knowledge to general, basic classes.
>
> Something I've been doing over the years in Cuis, that improves 
> consistency and understandability, is to clean up base classes. Number 
> should only consist of stuff related to Numbers. Same for String, 
> Collections, etc. If you compare Object, the Collection hierarchy, the 
> Number hierarchy, etc, in Cuis against Squeak, you'll see a lot of 
> that cleanup that has been done. Please help us keep improving Cuis in 
> this way too.
>
> You added three methods to Interval that are specific to parsing 
> source code. I think a much better place for them is as class methods 
> in Refactoring, perhaps in a 'services' category. They would be 
> available for other Refactorings to use, but they wouldn't scatter 
> behavior that is specific to Refactorings to the rest of the system. 
> May I ask you to do this change?
>
> Additionally, I'd like to ask you (and everyone!) to pick a meaningful 
> filenames for ChangeSets. Especially for the bigger ones.
>
> Thanks,
> -- 
> Juan Vuletich
> www.cuis-smalltalk.org
> https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
> https://github.com/jvuletich
> https://www.linkedin.com/in/juan-vuletich-75611b3
> @JuanVuletich
>
> On 4/17/2020 11:11 PM, Hernan Wilkinson via Cuis-dev wrote:
>> Great! so cool to have this refactoring in Cuis! Congratulation 
>> Nahuel! and thank you :-)
>>
>> It is integrated and on github.
>> BTW, I moved Preferences class>>withTemporaryValue: temporaryValue 
>> of: aPreferenceName do: aBlock to the tests package as an extension 
>> because it is used only by the tests
>>
>> Thanks again!
>> Hernan
>>
>> On Mon, Apr 13, 2020 at 2:28 PM Nahuel Garbezza via Cuis-dev 
>> <cuis-dev at lists.cuis.st <mailto:cuis-dev at lists.cuis.st>> wrote:
>>
>>     Forwarding because I've included a gif and it exceeded the
>>     allowed mail size :)
>>
>>     ---------- Forwarded message ---------
>>     De: *Nahuel Garbezza* <n.garbezza at gmail.com
>>     <mailto:n.garbezza at gmail.com>>
>>     Date: lun., 13 de abr. de 2020 a la(s) 00:21
>>     Subject: [ChangeSet] Extract Temporary - alpha version!
>>     To: Cuis Smalltalk <cuis-dev at lists.cuis.st
>>     <mailto:cuis-dev at lists.cuis.st>>
>>
>>
>>     Hi!
>>
>>     I'm excited to share this refactoring I've been implementing in
>>     the last month: the "extract temporary" refactoring.
>>
>>     The most basic functionality is included, and there are some edge
>>     cases I'll be addressing in the next weeks. It has basic error
>>     handling so if you try to extract an invalid text you should see
>>     a message explaining the problem. It has a menu entry for it and
>>     it has the (J) shortcut (that is close to the (K) shortcut for
>>     the extract method).
>>
>>     The goal is to collect feedback about it, so let me know if you
>>     have any issues with it, or things to improve in general.
>>
>>     I'm also attaching a changeset for the tests, and some
>>     refactorings on the extract method refactoring as well.
>>
>>     Here's a quick demo of it: https://gfycat.com/gaseousobedienthornet
>>
>>     Thanks!
>>     Nahuel.
>>     -- 
>>     Cuis-dev mailing list
>>     Cuis-dev at lists.cuis.st <mailto:Cuis-dev at lists.cuis.st>
>>     https://lists.cuis.st/mailman/listinfo/cuis-dev
>>
>>
>>
>> -- 
>> *Hernán Wilkinson
>> Agile Software Development, Teaching & Coaching*
>> *Phone: +54-011*-4893-2057
>> *Twitter: @HernanWilkinson*
>> *site: http://www.10Pines.com <http://www.10pines.com/>*
>> Address: Alem 896, Floor 6, Buenos Aires, Argentina
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20200421/3170654d/attachment-0001.htm>