[Cuis-dev] Question re: recent updates (4342)

Phil B pbpublist at gmail.com
Wed Aug 19 19:50:14 PDT 2020


OK, I think I see the problem: it looks like this is a new vector (i.e.
this did not occur previously) for background processes to cause problems.
Unfortunately your fix didn't resolve the issue because, like so many other
of these background process issues, it's only nil momentarily (i.e. the
exact instant the code is looking at it, probably until the next process
switch.  I usually come to this realization the same way every time: put a
nil check in which doesn't work because it's not nil at the time of the
test but is nil a couple of statements later which should be impossible...
ahhh:  background process!) and by the time you get to a debugger it's no
longer nil.  I'll have to take a closer look at the recent changes to see
if this issue can be worked around or if I need to redesign things on
my end.  So for now, I'd say you can take out that nil check if you want
since it doesn't help in this situation.

On Wed, Aug 19, 2020 at 8:48 AM Juan Vuletich <juan at jvuletich.org> wrote:

> On 8/19/2020 12:28 AM, Phil B via Cuis-dev wrote:
> > Juan,
> >
> > Much better, thanks.
> >
> > FYI, in #drawWorldComputeDamage:repair:rootMorphs:rootMorphsDamage: it
> > is possible for morphBounds in 'r intersect: morphBounds' to be nil.
> > Not sure yet if this is something in my code that still needs to be
> > updated for the latest changes or if I'm hitting a case you hadn't
> > anticipated.  I'm mentioning it because I'm wondering if there should
> > be a #displayFullBoundsOrBogus (i.e. to be used by
> > #drawWorldComputeDamage:repair:rootMorphs:rootMorphsDamage:) or should
> > this case just not ever be happening?
> >
> > Thanks,
> > Phil
> >
>
> I just pushed a change to handle the case where morphBounds is nil.
> Still, I don't see how this would happen. If you can reproduce the
> problem, please describe how. I video is ok too :)
>
> Thanks,
>
> --
> Juan Vuletich
> www.cuis-smalltalk.org
> https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
> https://github.com/jvuletich
> https://www.linkedin.com/in/juan-vuletich-75611b3
> @JuanVuletich
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20200819/c0399fcc/attachment.htm>


More information about the Cuis-dev mailing list