[Cuis-dev] Update: Alt+Return as a full screen toggle shortcut

[Mauro Rizzi]

Hello Everyone!

I just realized the Cuis-University image is outdated and contains packages
that the current dev-cuis build doesn't (like the ToolFinder, which I think
belongs on the base image from an usability side but i'm not going to die
on that hill).

I made a new changeset to replace my previous collaboration with this issue
that takes into account the current implementations in the keyboardEvent
class to avoid reverting code and implementing package methods in the base
image.

I just want to be clear that this changeset only contains the modification
to the keyboardEvent class.

El vie, 18 dic 2020 a las 19:56, Franco Lucchesi (<lucchesifd at gmail.com>)
escribió:

> Hello, sorry for the late reply, I ended up getting busy with real life
> matters and couldn't dedicate any time to looking at your fix.
>
> I implemented it and reverted my Morph modification as you asked for. As a
> small sidenote, if you notice any discrepancies in the changeset format it
> was my fault, I couldn't find any way to merge them together inside of Cuis
> so I ended up manually appending it to the original changeset with an
> external text editor.
>
> This however leads to a problem I'm not sure how to fix: this changeset
> appears to modify a package related message: sentTo:localPosition: from
> Tools-Finder, which doesn't feel correct to me. I thought about
> recategorizing this message back to "dispatching" but I'm not too sure if
> that would be correct either, I'll send both changesets: one that
> recategorizes the message to "dispatching" and one that leaves the category
> as is.
>
> Would it be reasonable to leave this dependency category in the changeset?
> Or is it better to recategorize back to "dispatching"? Or would it be
> better to do a different solution with a different message?
>
> Greetings, and happy holidays.
> -Franco
>
> El sáb, 12 dic 2020 a las 21:47, Mauro Rizzi (<mrizzi at fi.uba.ar>)
> escribió:
>
>> Hello Franco,
>>
>> I looked at your implementation and the issue lies on the method you're
>> using to intercept the ALT+ENTER command.
>>
>> The attached changeset implements it in the KeyboardEvent class and it
>> allows you to avoid sending the input to the morph that currently has focus.
>>
>> Make sure to revert the change to focusKeyboardFor: and share the
>> complete changeset with us!
>>
>> Cheers!
>> *Mauro Rizzi.*
>>
>> El sáb, 12 dic 2020 a las 21:10, Franco Lucchesi via Cuis-dev (<
>> cuis-dev at lists.cuis.st>) escribió:
>>
>>> Hello, recently I've been working with Cuis Smalltalk and whilst it's
>>> been a great experience the lack of an easy full screen toggle was starting
>>> to annoy me, so I decided to examine some of the Display related code and
>>> implement it myself.
>>>
>>> As the topic says, all this changeset does is add Alt+Return as a
>>> shortcut to toggle full screen on or off, it also additionally does a small
>>> refactor on some other full screen related messages.
>>>
>>> However, it has one bug: if you do Alt+Return whilst you are editing a
>>> textbox the full screen procedure seems to abort and instead an unusual
>>> character gets written in the current textbox, I haven't been able to
>>> figure out how to fix it but my best guess is to deselect everything before
>>> going full screen, which I also couldn't figure out how to do.
>>>
>>> This is my first time writing to a mail list and contributing updates to
>>> open source software so please let me know if I have done anything wrong in
>>> the process.
>>>
>>> Kind regards, and have a good weekend.
>>>
>>> -Franco
>>> --
>>> Cuis-dev mailing list
>>> Cuis-dev at lists.cuis.st
>>> https://lists.cuis.st/mailman/listinfo/cuis-dev
>>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20201218/705cb52e/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 4427-CuisCore-MauroJulianRizzi-2020Dec18-20h52m-MJR.001.cs.st
Type: application/octet-stream
Size: 1586 bytes
Desc: not available
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20201218/705cb52e/attachment-0001.obj>