[Cuis-dev] Proposed change to StringRequestMorph

[Juan Vuletich]

Integrated, again.

Thanks!

On 12/18/2020 9:24 PM, Mauro Rizzi via Cuis-dev wrote:
> Well here I go again,
>
> I just realized Cuis-University's latest version is a couple of months 
> old and realized my changeset for this issue was both not "future 
> proof" and based on erroneous information.
>
> Please integrate the attached changeset so this feature works as intended.
>
> Cheers!
> *Mauro Rizzi*
>
> El jue, 10 dic 2020 a las 15:01, Juan Vuletich (<juan at jvuletich.org 
> <mailto:juan at jvuletich.org>>) escribió:
>
>     Integrated.
>
>     Thanks!
>
>     On 12/9/2020 9:25 PM, Mauro Rizzi via Cuis-dev wrote:
>>     Hello Juan,
>>
>>     I discovered the renameCategory option uses the class side of
>>     StringRequestMorph to make the request and made the appropriate
>>     changes so it follows the same behaviour as every other dialogue.
>>
>>     I'm unsure what you need to add this so I'm attaching two
>>     changesets, one that includes both this fix and the previous one
>>     and one that only includes the fix.
>>     Note: The fix changeset (The one made in Dec09) requires the
>>     first changeset to be installed to work.
>>
>>     Cheers!
>>     *Mauro Rizzi*
>>
>>     El mar, 8 dic 2020 a las 17:32, Juan Vuletich
>>     (<juan at jvuletich.org <mailto:juan at jvuletich.org>>) escribió:
>>
>>         On 12/7/2020 8:58 PM, Mauro Rizzi via Cuis-dev wrote:
>>>         Oops!
>>>
>>>         What I thought was a bug because of this changeset is
>>>         actually standard behaviour so the changeset actually works
>>>         as intended.
>>>
>>>         I'll happily look into any errors you guys can find!
>>>
>>>         Cheers!
>>>         *Mauro Rizzi*
>>>
>>>         El lun, 7 dic 2020 a las 18:30, Mauro Rizzi
>>>         (<mrizzi at fi.uba.ar <mailto:mrizzi at fi.uba.ar>>) escribió:
>>>
>>>             Hello everyone,
>>>
>>>             I didn't go deep enough testing it and now realized
>>>             things like the debugger will automatically focus the
>>>             last created StringRequestMorph in its composition so
>>>             maybe this isn't the final solution.
>>>
>>>             I'm looking into coming up with a fix.
>>>
>>>             Cheers!
>>>             *Mauro Rizzi*
>>>
>>>             El lun, 7 dic 2020 a las 16:38, Mauro Rizzi
>>>             (<mrizzi at fi.uba.ar <mailto:mrizzi at fi.uba.ar>>) escribió:
>>>
>>>                 Hello everyone!
>>>
>>>                 I got tired of having to click on text boxes every
>>>                 time I tried to rename something (when using click
>>>                 to focus) and decided to do something about it.
>>>
>>>                 Attached you'll find a changeset that makes it so
>>>                 those string request dialogue boxes automatically
>>>                 gain focus when created (It seems to be standard
>>>                 behaviour for the rest of the system but not for
>>>                 this particular class).
>>>
>>>                 I would also like to request this change be
>>>                 introduced to the base image.
>>>
>>>                 If you check the changeset the changes to the base
>>>                 codebase are minimal, and judging by the left over "
>>>                 textPane focusText." comment they were intended to
>>>                 exist at some point.
>>>
>>>                 Only thing I'm unsure about is if I should check
>>>                 that we're on the click to focus setting or not.
>>>
>>>                 Cheers!
>>>                 *Mauro Rizzi*
>>>
>>
>>         Integrated.
>>
>>         Thanks!
>>
>>         -- 
>>         Juan Vuletich
>>         www.cuis-smalltalk.org  <http://www.cuis-smalltalk.org>
>>         https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
>>         https://github.com/jvuletich
>>         https://www.linkedin.com/in/juan-vuletich-75611b3
>>         @JuanVuletich
>>
>
>
>     -- 
>     Juan Vuletich
>     www.cuis-smalltalk.org  <http://www.cuis-smalltalk.org>
>     https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
>     https://github.com/jvuletich
>     https://www.linkedin.com/in/juan-vuletich-75611b3
>     @JuanVuletich
>


-- 
Juan Vuletich
www.cuis-smalltalk.org
https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
https://github.com/jvuletich
https://www.linkedin.com/in/juan-vuletich-75611b3
@JuanVuletich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20201220/f18f8188/attachment-0001.htm>