[Cuis-dev] findSelector fixes

Juan Vuletich juan at jvuletich.org
Tue Dec 29 12:41:18 PST 2020


On 12/29/2020 5:35 PM, Hernan Wilkinson via Cuis-dev wrote:
>
>
>
>
>     That was added as part of
>     3525-MiscFixesForColonAsBinarySelector-JuanVuletich-2018Dec14-13h29m-jmv.1.cs.st
>     <http://3525-MiscFixesForColonAsBinarySelector-JuanVuletich-2018Dec14-13h29m-jmv.1.cs.st>
>     . I guess it is still needded. So I added it back (fixing the
>     receiver).
>
>
> The problem with that check is that if a there is a comment like this one:
> "self m1: 2"
> and you look for senders or implementors of m1: (without selecting 
> m1:, just with the cursor in the m or 1), it will not recognize m1: as 
> a selector...
> That check disregards keywords that do not end with a letter which is 
> weird...

Then I guess we'd call #isValidInIdentifiers, right?

> BTW, playing with this I found that Scanner>>#findSelectorIn: does not 
> find unary and binary selectors, something to fix latter :-)

Ther's always more fun stuff to do...

> -- 
> *Hernán Wilkinson
> Agile Software Development, Teaching & Coaching*
> *Phone: +54-011*-4893-2057
> *Twitter: @HernanWilkinson*
> *site: http://www.10Pines.com <http://www.10pines.com/>*
> Address: Alem 896, Floor 6, Buenos Aires, Argentina

Cheers,

-- 
Juan Vuletich
www.cuis-smalltalk.org
https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
https://github.com/jvuletich
https://www.linkedin.com/in/juan-vuletich-75611b3
@JuanVuletich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20201229/151cdb1c/attachment-0001.htm>


More information about the Cuis-dev mailing list