[Cuis-dev] Backtick Parse Node - Please check

[Hernan Wilkinson]

Hi,
 the original mail had an invalid change file for the tests... sorry about
that.
 Attached is the right one and another .cs that removes a method that I
forgot to remove.

Hernan.


On Tue, Jun 23, 2020 at 10:39 AM Hernan Wilkinson <
hernan.wilkinson at 10pines.com> wrote:

> 😜😜👏👏
>
> On Tue, Jun 23, 2020 at 10:38 AM Nahuel Garbezza <n.garbezza at gmail.com>
> wrote:
>
>> Hi Hernán!
>>
>> I played with it for a while and I couldn't find any issues. I took a
>> deeper look at refactorings and they seem to work as expected (I know we
>> have tests,  but... :-) )
>>
>> Nahuel
>>
>> El mar., 23 de jun. de 2020 a la(s) 09:34, Hernan Wilkinson via Cuis-dev (
>> cuis-dev at lists.cuis.st) escribió:
>>
>>> Great!
>>> Thank you for trying it out
>>>
>>> Hernan
>>>
>>> On Tue, Jun 23, 2020 at 3:33 AM Phil B <pbpublist at gmail.com> wrote:
>>>
>>>> Hernan,
>>>>
>>>> So nice to have backticks not lost after editing in pretty print mode.
>>>> Things look good in OMeta.
>>>>
>>>> Thanks for asking,
>>>> Phil
>>>>
>>>> On Mon, Jun 22, 2020 at 5:36 PM Hernan Wilkinson via Cuis-dev <
>>>> cuis-dev at lists.cuis.st> wrote:
>>>>
>>>>> Hi,
>>>>>  the current implementation that supports backtick expressions has
>>>>> some issues. For example it does not work correctly when debugging, it
>>>>> allows to define temp vars inside the backtick that when debugging makes
>>>>> the debugger hang, etc.
>>>>>
>>>>>  Attached there are a couple of changes that create a new parse node,
>>>>> BacktickNode, and change the parser to instantiate it when appropriate.
>>>>> These changes solve the problems the current implementation has.
>>>>>
>>>>>  Please try it to see if it works correctly.
>>>>>  I try it, recompile all the methods, etc. and I haven't found any
>>>>> issue, but please take a look at it.
>>>>>
>>>>>  Phil, please try it and let me know if it breaks anything in your
>>>>> OMeta project. I think it should not, but please let me know if it works
>>>>> correctly.
>>>>>
>>>>>  Cheers!
>>>>>  Hernan.
>>>>>
>>>>>
>>>>> --
>>>>>
>>>>> *Hernán WilkinsonAgile Software Development, Teaching & Coaching*
>>>>> *Phone: +54-011*-4893-2057
>>>>> *Twitter: @HernanWilkinson*
>>>>> *site: http://www.10Pines.com <http://www.10pines.com/>*
>>>>> Address: Alem 896, Floor 6, Buenos Aires, Argentina
>>>>> --
>>>>> Cuis-dev mailing list
>>>>> Cuis-dev at lists.cuis.st
>>>>> https://lists.cuis.st/mailman/listinfo/cuis-dev
>>>>>
>>>>
>>>
>>> --
>>>
>>> *Hernán WilkinsonAgile Software Development, Teaching & Coaching*
>>> *Phone: +54-011*-4893-2057
>>> *Twitter: @HernanWilkinson*
>>> *site: http://www.10Pines.com <http://www.10pines.com/>*
>>> Address: Alem 896, Floor 6, Buenos Aires, Argentina
>>> --
>>> Cuis-dev mailing list
>>> Cuis-dev at lists.cuis.st
>>> https://lists.cuis.st/mailman/listinfo/cuis-dev
>>>
>>
>
> --
>
> *Hernán WilkinsonAgile Software Development, Teaching & Coaching*
> *Phone: +54-011*-4893-2057
> *Twitter: @HernanWilkinson*
> *site: http://www.10Pines.com <http://www.10pines.com/>*
> Address: Alem 896, Floor 6, Buenos Aires, Argentina
>


-- 

*Hernán WilkinsonAgile Software Development, Teaching & Coaching*
*Phone: +54-011*-4893-2057
*Twitter: @HernanWilkinson*
*site: http://www.10Pines.com <http://www.10pines.com/>*
Address: Alem 896, Floor 6, Buenos Aires, Argentina
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20200623/18f36cc5/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: UnsavedChangesTo-BaseImageTests-HAW.002.cs.st
Type: application/octet-stream
Size: 2573 bytes
Desc: not available
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20200623/18f36cc5/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 4234-BacktickParseNode-HernanWilkinson-2020Jun23-15h40m-HAW.001.cs.st
Type: application/octet-stream
Size: 743 bytes
Desc: not available
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20200623/18f36cc5/attachment-0001.obj>