[Cuis-dev] Recently added Morph class>>releaseClassCachedState

[Phil B]

Juan,

Fair enough.  I wasn't sure if you were intentionally trying to minimize
image size on every save and was trying to offer an alternative if that was
the case.

Thanks,
Phil

On Fri, May 8, 2020 at 11:04 AM Juan Vuletich <juan at jvuletich.org> wrote:

> Hi Phil,
>
> On 5/8/2020 2:32 AM, Phil B via Cuis-dev wrote:
>
> I just ran a quick test... yes, let's please have a fast save option!
> When I eliminated the #releaseClassCachedState sends from the save process
> (and the corresponding #initClassCachedState on the other side of the
> save), the save took *maybe* 1/4 of a second.
>
> On Fri, May 8, 2020 at 1:00 AM Phil B <pbpublist at gmail.com> wrote:
>
>> I noticed that this method is significantly slowing down image saves...
>> taking upwards of 10 seconds.  Partially it's due to my Morphs now wiping
>> and recreating a bunch of state each save.  But it's also partially due
>> just to the overhead of Morph allSubInstancesDo: [:ea| ] taking ~3-4
>> seconds to execute per save. (in an image with ~2k morphs, which isn't that
>> hard to get to)
>>
>> If the goal is to minimize saved image file size, could we have options
>> for a 'fast save' vs a 'small save'?  Unless I'm going to email/publish an
>> image, I'd prefer the save to be fast rather than small.
>>
>
> We already have that. When you do a 'save as new version', additional,
> more expensive cleanup is done.
>
> The problem here is that recently I added a 'Morph allSubInstancesDo:
> [:ea| ]' on every image save. Apologies. Fix now on GitHub.
>
> Thanks,
>
> --
> Juan Vuletichwww.cuis-smalltalk.orghttps://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Devhttps://github.com/jvuletichhttps://www.linkedin.com/in/juan-vuletich-75611b3
> @JuanVuletich
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20200508/b7df0364/attachment-0001.htm>