[Cuis-dev] [ChangeSet] Fixes and enhancements to inspectors
Andres Valloud
ten at smallinteger.com
Sun May 24 07:45:55 PDT 2020
Ok, now I see why though. Update 4165 begins like this:
'From Cuis 5.0 [latest update: #4164] on 22 May 2020 at 7:53:38 pm'!
Smalltalk renameClassNamed: #OrderedCollectionInspector as:
#SequenceableCollectionInspector!
On 5/24/20 07:45, Luciano Notarfrancesco via Cuis-dev wrote:
> I just read the code, didn’t try to fileIn yet, but that’s weird if it
> didn’t delete it...
>
> On Sun, 24 May 2020 at 9:41 PM, Andres Valloud via Cuis-dev
> <cuis-dev at lists.cuis.st <mailto:cuis-dev at lists.cuis.st>> wrote:
>
> Now I understand even less. After doing that, there is still a
> SequenceableCollectionInspector, and so the fileout I sent is valid. I
> verified it loads as intended.
>
> Luciano, I can see the class deletion in 4164. Nevertheless, after
> doing what Juan says, the fileout I sent loads fine. Did you run
> into a
> problem loading the code? Or, was your comment more from a static
> perspective (i.e. just looking at code and seeing something that didn't
> make a lot of sense)?
>
> On 5/24/20 07:33, Andres Valloud via Cuis-dev wrote:
> > Yeah --- next time, only one of us pushes out to the list at the
> same
> > time :).
> >
> > On 5/24/20 07:14, Juan Vuletich wrote:
> >> Maybe to resync it would be best to start again with a git pull,
> load
> >> all updates, and then the changesets in this mail thread.
> >>
> >> On 5/24/2020 10:48 AM, Andres Valloud via Cuis-dev wrote:
> >>> /me scratches head, what's going on here?... Juan and I have been
> >>> exchanging code, maybe I got out of sync with him. We did
> agree that
> >>> there was a method with unnecessary exception handling that
> should be
> >>> removed, I meant to remove that bit.
> >>>
> >>> On 5/24/20 06:39, Luciano Notarfrancesco via Cuis-dev wrote:
> >>>> I don’t understand, didn’t you remove that class in 4164 above?
> >>>>
> >>>> On Sun, 24 May 2020 at 8:35 PM, Andres Valloud via Cuis-dev
> >>>> <cuis-dev at lists.cuis.st <mailto:cuis-dev at lists.cuis.st>
> <mailto:cuis-dev at lists.cuis.st <mailto:cuis-dev at lists.cuis.st>>> wrote:
> >>>>
> >>>> Another small change.
> >>>>
> >>>> On 5/24/20 05:32, Juan Vuletich via Cuis-dev wrote:
> >>>> > On 5/22/2020 8:08 PM, Juan Vuletich via Cuis-dev wrote:
> >>>> >> Hi Folks,
> >>>> >>
> >>>> >> Andrés Valloud and I found a couple of bugs and inconsistencies
> >>>> in the
> >>>> >> Inspector hierarchy. If you don't mind crashing your image you
> >>>> might
> >>>> >> try `(1 to: 2000) asFloat64Array`, or inspecting an
> >>>> OrderedCollection
> >>>> >> with an object that fails in #printOn:, and cycle the
> collection
> >>>> with
> >>>> >> the arrow keys.
> >>>> >>
> >>>> >> We did quite some refactor and cleanup. The result is attached.
> >>>> Please
> >>>> >> take a look.
> >>>> >>
> >>>> >> Thanks,
> >>>> >>
> >>>> >
> >>>> > After those, these follow. Any comment is appreciated.
> >>>> >
> >>>> > Cheers,
> >>>> >
> >>>> >
> >>>> -- Cuis-dev mailing list
> >>>> Cuis-dev at lists.cuis.st <mailto:Cuis-dev at lists.cuis.st>
> <mailto:Cuis-dev at lists.cuis.st <mailto:Cuis-dev at lists.cuis.st>>
> >>>> https://lists.cuis.st/mailman/listinfo/cuis-dev
> >>>>
> >>>>
> >>
> >>
> --
> Cuis-dev mailing list
> Cuis-dev at lists.cuis.st <mailto:Cuis-dev at lists.cuis.st>
> https://lists.cuis.st/mailman/listinfo/cuis-dev
>
>
More information about the Cuis-dev
mailing list