[Cuis-dev] Real Joy on Linux was ( Updates to VectorGraphics and precompiled MacVM)

[Juan Vuletich]

On 5/22/2021 9:11 PM, David T. Lewis via Cuis-dev wrote:
> On Sat, May 22, 2021 at 10:26:38AM +0200, stes--- via Cuis-dev wrote:
>> ----- Op 21 mei 2021 om 22:59 schreef cuis-dev cuis-dev at lists.cuis.st:
>>
>>> Hi Juan,
>>>
>>> Yes. I think that the only necessary update for VMMaker will be something
>>> like the attached, which moves the sqConfig.h include in the generated
>>> code for all plugins. I tried this change on classic VMMaker for interpreter
>>> VM, and everything worked as before. The generated code for VectorEnginePlugin
>>> will work on opensmalltalk-vm (after the fix_include_order branch is
>>> merged). This is probably the same thing that Gerald Klix did, and I
>>> think it is the right solution.
>>>
>>> Dave
>> An alternative solution could be to remove the #error from config.h,
>> which stops the compile if config.h is included too late.
>>
>> The #error was added in the hope to force the change that you describe.
>>
>> But another fix could be to remove the #error.
>>
>> Of course from a GNU autoconf / configure perspective an early #include of config.h is what GNU autoconf wants.
>>
>> Anyway that's more a VM-dev list issue than a Cuis issue.
>>
>> A more fundamental Cuis issue is, whether the VectorEnginePlugin can easily be added to VMMaker,
>> because Cuis is a fork of Squeak with some differences in the collection classes,
>> but with significant differences in Morphic.
>>
> Let me please try to ask the question in a slightly different way.
>
>    Can VectorEnginePlugin be added to the officially distributed VMs that are
>    used or Squeak, Cuis, and related imges?
>
> The answer is yes. It can be, it should be, and it will be.

This will be great.

> To the questions of whether it can be added to VMMaker: Again, the answer
> is yes. But in my opinion, we should not care. Juan is the author of the
> plugin, and he is developing and maintaining it in Cuis. The upstream source
> for the plugin is in the Cuis repository on Github. Any VMMaker image, regardless
> of whether it is running on Cuis or Squeak or anything else, can use Juan's
> Smalltalk source to generate and compile the VectorEnginePlugin. It just works.

I guess that adding VectorEnginePlugi to VMMaker is a good idea, as it 
will streamline the VM build procedure, and it will encourage adoption 
from the Squeak community.

Most likely I'll still be working in Cuis, as it is where I have the 
client code that can test the plugin, but I'm sure we'll make it work.

Still, I have been changing stuff around a lot, so I'd do that when the 
plugin code is reasonably stable, maybe one or two months without changes.

> As you said, this is probably a question for discussion on the vm-dev list.
> But for what it's worth, that is my opinion.
>
> Dave
>

Thanks,

-- 
Juan Vuletich
www.cuis-smalltalk.org
https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
https://github.com/jvuletich
https://www.linkedin.com/in/juan-vuletich-75611b3
@JuanVuletich