[Cuis-dev] Bug? running system category tests

[Luciano Notarfrancesco]

Hi Hernan,
I think this should fix cmd-t. I never used this and I'm not sure how you
use it, can you test it and let me know if it behaves as you expect? Notice
that I moved #classesAt: from Categorizer to SystemOrganizer because the
Categorizer is more general (it is used for method categories too), and
then I removed #testCaseClassesAt: and put that line of code in the caller
(because it made the SystemOrganizer know about test cases and I thought
that was unnecessary). I don't think I broke anything, I searched for
senders in other packages, but let me know what you think.

Also I saw the methods for #linesOfCodeOf:, #instanceMethodCountOf: and
#classMethodCountOf: you added to SystemOrganizer to show that information
in annotations. Currently, they return 0 for top categories without any
classes. I made the experiment of including all classes in all
subcategories, but it became too slow so I reverted to the original
behavior.

Regarding cmd-y I think there's not much we can do without getting dirty...
at the level of SmalltalkEditor we don't know anything of the Browser, what
system category is selected, etc, and I wouldn't want to hack my way into a
fix. What do you think?


On Wed, Feb 2, 2022 at 3:08 PM Hernan Wilkinson via Cuis-dev <
cuis-dev at lists.cuis.st> wrote:

> Hi Luciano,
>  I found another bug... well, I do not know if it is a bug really, maybe a
> "desired behavior" :-)
>  It is related to running the tests for a system category.
>  Currently, if you have the mouse over a system category and pressed
> cmd+t, it runs all the tests of that category. That works ok for the
> subcategories but if you are in a root category it only runs the tests for
> that root category and I think it should run the tests of all the
> categories because they are shown in the class list.
>
>  The same thing should happen when pressing cmd+y in the code pane. cmd+y
> runs the tests of the system category, so if you are in a root system
> category it should behave as described in the previous paragraph.
>
>  Does it make sense to you?
>
> Cheers!
> Hernan.
> --
> Cuis-dev mailing list
> Cuis-dev at lists.cuis.st
> https://lists.cuis.st/mailman/listinfo/cuis-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20220204/b5e6bdc3/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 5060-FixRunningTestsOnTopSystemCategories-LucianoEstebanNotarfrancesco-2022Feb04-04h46m-len.001.cs.st
Type: application/octet-stream
Size: 4396 bytes
Desc: not available
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20220204/b5e6bdc3/attachment-0001.obj>