[Cuis-dev] The Cuis Book for Cuis 6

Tommy Pettersson ptp at lysator.liu.se
Tue Feb 15 09:00:21 PST 2022


On Mon, Feb 14, 2022 at 03:31:31PM +0100, Hilaire Fernandes via Cuis-dev wrote:
> Please review to the edit for errors
> 
> https://github.com/Cuis-Smalltalk/TheCuisBook/commit/d922725daf5547b5c2de8cd8ffe226a19a9f45a1

This makes the example much easier to follow. Thanks!

I have more comments, but I'll send them in a separate
email. For the review, I spotted two language issues:

diff --git a/en/chapter-07/contents.texinfo b/en/chapter-07/contents.texinfo
index 6748994b..a240bdb5 100644
--- a/en/chapter-07/contents.texinfo
+++ b/en/chapter-07/contents.texinfo
@@ -737,7 +737,7 @@ SpaceShip>>left
    self heading: self heading - 0.1}
 
 
-But how this heading affects the rotation of the morph?
+But how does this heading affects the rotation of the morph?
 
 Underneath, the @class{MobileMorph} is equipped with an affine
 transformation to scale, rotate and translate the coordinates passed
@@ -745,8 +745,8 @@ as arguments to the drawing messages received by the canvas.
 Therefore, our @method{heading} methods are defined to match this
 internal representation and we use the @method{rotation:} method from
 the @class{PacedMorph} class to rotate appropriately. The
- at smalltalk{location} attribute represents an affine transformation, we
-ask its rotation angle with the @msg{radians} message.
+ at smalltalk{location} attribute represents an affine transformation, and we
+get its rotation angle with the @msg{radians} message.
 
 @cindex morph @subentry @method{rotation:}
 @cindex morph @subentry @smalltalk{location}


More information about the Cuis-dev mailing list