[Cuis-dev] Preference #warnIfNoSourcesFile

[Juan Vuletich]

On 12/23/2021 8:21 AM, Bernhard Pieber via Cuis-dev wrote:
> I was too fast. I did not test thoroughly enough. When I file in the change set and remove the sources file the image freezes on startup before the window is shown. In the console I see the following message:
> MessageNotUnderstood: UndefinedObject>>mousePoint
> See /Users/bernhard/Entwicklung/Cuis/Cuis-Smalltalk/bp-cuis/CuisDebug-2021-12-23_12.12.51.log
>
> The log file contains only:
> MessageNotUnderstood: UndefinedObject>>mousePoint
> 23 December 2021 12:12:
>
> The same happens if I don’t file in the change set but just set the preference:
> Preferences enable: #warnIfNoSourcesFile
>
> It looks like the Sensor is still nil when the warning is shown. No idea what is the right fix, though.
>
> Cheers,
> Bernhard
>
>> Am 23.12.2021 um 11:41 schrieb Bernhard Pieber via Cuis-dev<cuis-dev at lists.cuis.st>:
>>
>> Hi everyone,
>>
>> I was bitten by the fact that I had put my image and changes into a sibling folder of Cuis-Smalltalk-Dev but forgot to copy CuisV5.sources as well. I had assumed that I would get a warning about a missing sources file but there was not. I think there should be by default.
>>
>> It is interesting that the following statements return different values:
>> Preferences warnIfNoSourcesFile. "true"
>> Preferences valueOfFlag: #warnIfNoSourcesFile. "false"
>>
>> The former is not used in the default image, only the latter. That is probably the reason why there is no warning.
>>
>> Looking at senders of #valueOfFlag: shows it is only used in Preference class>>#doesNotUnderstand and in SystemDictionary>>#openSourcesAndChanges. Find attached a change set that uses #warnIfNoSources and #warnIfNoChanges directly instead of #valueOfFlag:.
>>
>> That should reinstate the warning should one forget to copy the sources file.
>>
>> Cheers,
>> Bernhard
>>
>> --
>> Cuis-dev mailing list
>> Cuis-dev at lists.cuis.st
>> https://lists.cuis.st/mailman/listinfo/cuis-dev
>> <5005-CuisCore-BernhardPieber-2021Dec23-11h28m-bp.001.cs.st>

Hi Bernhard,

Please review and test the attach, before I push it to GitHub.

Thanks,

-- 
Juan Vuletich
www.cuis-smalltalk.org
https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
https://github.com/jvuletich
https://www.researchgate.net/profile/Juan-Vuletich
https://www.linkedin.com/in/juan-vuletich-75611b3
https://independent.academia.edu/JuanVuletich
@JuanVuletich

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 5033-FixWarningForMissingSources-JuanVuletich-2022Jan03-13h57m-jmv.001.cs.st
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20220103/2babfa3a/attachment-0001.ksh>