[Cuis-dev] [RFC] Re: Drag & drop of class to system category does not work
Juan Vuletich
JuanVuletich at zoho.com
Thu Jun 16 12:42:49 PDT 2022
Hi Folks,
I've just integrated your code. Thanks! This is a very welcome improvement!
Luciano, I really appreciate your attention to detail and the effort you
spent in also cleaning PluggableListMorph and making both consistent.
Your coding style really helps keeping Cuis true to its objectives!
I did a small change, though. It is likely that some optional package
uses #rejectDrops. So, instead of removing it, I updated it and copied
it verbatim to HierarchycalListMorph.
WRT classes appearing twice in change sets, it is on purpose. This
behavior was already present in Cuis. The first part of a change set
includes any class definition needed, but not always in the final form.
For instance, new ivars are included, but removed ivars are included
too. This is to avoid compiling errors during filein. Then, new methods,
method modifications, method deletions. Only after all method changes,
the class definitions are included again, but now in the final form,
removing any removed ivars.
Cheers,
On 6/12/2022 1:18 PM, Luciano Notarfrancesco via Cuis-dev wrote:
> Sorry, the change set in last message included two instance variables
> in HierarchicalListMorph I didn't intend to include (originally from
> Gerald's code, that later I changed to be consistent with
> PluggableListMorph). You can remove them manually, or use this change
> set instead.
> BTW, I'm not sure if this is a bug, but I'm seeing multiple copies of
> a class definition in file outs of changesets. For example, look at
> the changeset for the recent core update 5232.
>
> On Sun, Jun 12, 2022 at 2:16 PM Luciano Notarfrancesco
> <luchiano at gmail.com <mailto:luchiano at gmail.com>> wrote:
>
> I implemented DND in HierarchicalListMorph following the
> implementation in PluggableListMorph in order to be more
> consistent. I also fixed a bug in DND of the PlugglableListMorph
> (when the dropActionSelector had only 1 argument, it received the
> target item instead of the dropped item), and simplified it a
> little bit. And I also added back DND of classes into system
> categories in the Browser.
> There's still one little problem: during DND into a
> HierarchicalListMorph the target item is not highlighted. I'll
> look into that soon. Other than that, everything seems to work
> fine, but please review and let me know of any problems.
>
> On Sun, Jun 12, 2022 at 7:14 AM Luciano Notarfrancesco
> <luchiano at gmail.com <mailto:luchiano at gmail.com>> wrote:
>
> Juan, if you didn’t have time yet I’ll take a look today and
> see if I can also add back dnd to the system categories list.
>
> On Sun, 12 Jun 2022 at 12:48 AM Gerald Klix <cuis.01 at klix.ch
> <mailto:cuis.01 at klix.ch>> wrote:
>
> Hi Juan,
>
> please review the attached package,
> it contains sub-classes of all the hierarchical
> list morph classes. These morph class
> support drag and drop.
>
> I tested the classes by using
> them in Haver's module tools.
> They still work!
>
>
> HTH and Best Regards,
>
> Gerald
>
>
>
>
> On 6/7/22 20:20, Juan Vuletich wrote:
> > Please do! That would be helpful.
> >
> > I'd love to review that code to integrate it in the base
> image.
> >
> > Thanks,
> >
> > On 5/27/2022 1:06 PM, Gerald Klix via Cuis-dev wrote:
> >> Should I port the aforementioned Haver package to Cuis,
> meaning remove
> >> the module stuff?
> >> That would cost me two hours including testing. That
> one contains an
> >> IndentingListItemMorph
> >> with drag and drop support.
> >>
> >> Juan, what do you think?
> >>
> >>
> >> Best Regards,
> >>
> >> Gerald
> >>
> >> On May 27 2022, at 5:30 pm, Luciano Notarfrancesco
> >> <luchiano at gmail.com <mailto:luchiano at gmail.com>> wrote:
> >>
> >> Yes, that’s the reason, we should add drag&drop to
> hierarchical
> >> lists…
> >>
> >> On Fri, 27 May 2022 at 10:01 PM Gerald Klix via
> Cuis-dev
> >> <cuis-dev at lists.cuis.st <mailto:cuis-dev at lists.cuis.st>
> <mailto:cuis-dev at lists.cuis.st
> <mailto:cuis-dev at lists.cuis.st>>> wrote:
> >>
> >> I messed around with the IndentingListItemMorph
> class quite a
> >> lot, therefore I can answer that one from the
> top of my had.
> >> The builtin IndentingListItemMorph used for the
> category list
> >> has no (working) support for drag and drop.
> >>
> >> See:
> >>
> >>
> https://hg.sr.ht/~cy-de-fect/HaverOnCuis/browse/haver/ui/DNDIndentingListItemMorph.pck.st
> <https://hg.sr.ht/%7Ecy-de-fect/HaverOnCuis/browse/haver/ui/DNDIndentingListItemMorph.pck.st>
>
> >>
> >>
> >>
> <https://hg.sr.ht/%7Ecy-de-fect/HaverOnCuis/browse/haver/ui/DNDIndentingListItemMorph.pck.st>
>
> >>
> >>
> >>
> >> HTH and Best Regards,
> >>
> >> Gerald
> >>
> >> On May 27 2022, at 4:55 pm, Hernan Wilkinson
> via Cuis-dev
> >> <cuis-dev at lists.cuis.st <mailto:cuis-dev at lists.cuis.st>
> <mailto:cuis-dev at lists.cuis.st
> <mailto:cuis-dev at lists.cuis.st>>> wrote:
> >>
> >> Hi Luciano,
> >> Before the change you made to make the
> system category
> >> look like a tree (nice!), we could drag a
> class and drop
> >> it into a system category to categorized
> the class into
> >> the dropped category. That does not work
> anymore.
> >> I have the feeling that you mentioned why,
> but I do not
> >> recall.
> >> Is there a reason for this? is it too
> difficult to make
> >> it work again?
> >>
> >> Thanks!
> >> Hernan.
> >> --
> >> Cuis-dev mailing list
> >> Cuis-dev at lists.cuis.st <mailto:Cuis-dev at lists.cuis.st>
> <mailto:Cuis-dev at lists.cuis.st
> <mailto:Cuis-dev at lists.cuis.st>>
> >> https://lists.cuis.st/mailman/listinfo/cuis-dev
> >>
> >> --
> >> Cuis-dev mailing list
> >> Cuis-dev at lists.cuis.st <mailto:Cuis-dev at lists.cuis.st>
> <mailto:Cuis-dev at lists.cuis.st
> <mailto:Cuis-dev at lists.cuis.st>>
> >> https://lists.cuis.st/mailman/listinfo/cuis-dev
> >>
> >
> >
>
--
Juan Vuletich
www.cuis-smalltalk.org
https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
https://github.com/jvuletich
https://www.linkedin.com/in/juan-vuletich-75611b3
https://independent.academia.edu/JuanVuletich
https://www.researchgate.net/profile/Juan-Vuletich
https://patents.justia.com/inventor/juan-manuel-vuletich
https://twitter.com/JuanVuletich
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20220616/7e4ad3f5/attachment-0001.htm>
More information about the Cuis-dev
mailing list